bbovenzi merged PR #39006:
URL: https://github.com/apache/airflow/pull/39006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tirkarthi commented on PR #39006:
URL: https://github.com/apache/airflow/pull/39006#issuecomment-2067480912
The legacy log view doesn't have code changes to process every line. It just
has the whole log as a single string so doing splitting and then adding ansi
codes to join them back was
jscheffl commented on code in PR #39006:
URL: https://github.com/apache/airflow/pull/39006#discussion_r1572806934
##
airflow/www/static/js/utils/index.ts:
##
@@ -185,6 +185,34 @@ const toSentenceCase = (camelCase: string): string => {
return "";
};
+const addColorKeyword
tirkarthi commented on code in PR #39006:
URL: https://github.com/apache/airflow/pull/39006#discussion_r1572653543
##
airflow/www/static/js/utils/index.ts:
##
@@ -185,6 +185,34 @@ const toSentenceCase = (camelCase: string): string => {
return "";
};
+const addColorKeyword
tirkarthi commented on PR #39006:
URL: https://github.com/apache/airflow/pull/39006#issuecomment-2066933356
@dirrao @jscheffl Used below dag which generated around 30MB log file and
the function call added around 15ms with total render time taking 9-10 seconds.
I did it with dev builds
tirkarthi commented on code in PR #39006:
URL: https://github.com/apache/airflow/pull/39006#discussion_r1572643904
##
airflow/www/static/js/utils/index.ts:
##
@@ -185,6 +185,34 @@ const toSentenceCase = (camelCase: string): string => {
return "";
};
+const addColorKeyword
tirkarthi commented on code in PR #39006:
URL: https://github.com/apache/airflow/pull/39006#discussion_r1572642067
##
airflow/config_templates/config.yml:
##
@@ -979,6 +979,22 @@ logging:
type: boolean
example: ~
default: "True"
+
tirkarthi commented on code in PR #39006:
URL: https://github.com/apache/airflow/pull/39006#discussion_r1572640444
##
airflow/www/static/js/utils/index.ts:
##
@@ -185,6 +185,34 @@ const toSentenceCase = (camelCase: string): string => {
return "";
};
+const addColorKeyword
jscheffl commented on code in PR #39006:
URL: https://github.com/apache/airflow/pull/39006#discussion_r1567847175
##
airflow/www/static/js/utils/index.ts:
##
@@ -185,6 +185,34 @@ const toSentenceCase = (camelCase: string): string => {
return "";
};
+const addColorKeyword
bbovenzi commented on code in PR #39006:
URL: https://github.com/apache/airflow/pull/39006#discussion_r1567452482
##
airflow/www/static/js/utils/index.ts:
##
@@ -185,6 +185,34 @@ const toSentenceCase = (camelCase: string): string => {
return "";
};
+const addColorKeyword
bbovenzi commented on PR #39006:
URL: https://github.com/apache/airflow/pull/39006#issuecomment-2059217203
cc: @jscheffl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dirrao commented on PR #39006:
URL: https://github.com/apache/airflow/pull/39006#issuecomment-2059174505
> @dirrao This is to do string search and it has to process each line to
apply color ansi codes. This is already done on whole log file to apply log
level class based on info, error,
tirkarthi commented on PR #39006:
URL: https://github.com/apache/airflow/pull/39006#issuecomment-2055862566
@dirrao This is to do string search and it has to process each line to apply
color ansi codes. This is already done on whole log file to apply log level
class based on info, error,
tirkarthi opened a new pull request, #39006:
URL: https://github.com/apache/airflow/pull/39006
closes: #37443
related: #37443
We have been using this feature in Airflow 2.3.4 in the legacy log page by
applying regex against lines to apply color for them. It
received positive
14 matches
Mail list logo
