Lee-W commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2041286647
As many have approved this, I plan to merge it today or tomorrow. Please let
me know if anyone want to take a deeper look
--
This is an automated message from the Apache Git
potiuk commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036833005
If you **just** want to get your PR merged faster, then it's a very selfish
reason to tap into time and attention of others when YOU want it and not when
THEY have time for it.
--
potiuk commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036830670
> @potiuk Please review this PR.
Why tagging me? @subham611 ? What's the reasoning of doing it ?
I think there are enough reviewers. generally please avoid tagging people
SubhamSinghal commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036824428
@potiuk Please review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pankajkoti commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036187771
cc: @alexott
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
subham611 commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036157949
@Lee-W All tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Lee-W commented on code in PR #38702:
URL: https://github.com/apache/airflow/pull/38702#discussion_r1550840261
##
docs/apache-airflow-providers-databricks/operators/run_now.rst:
##
@@ -45,6 +45,7 @@ All other parameters are optional and described in
documentation for
Lee-W commented on code in PR #38702:
URL: https://github.com/apache/airflow/pull/38702#discussion_r1550840261
##
docs/apache-airflow-providers-databricks/operators/run_now.rst:
##
@@ -45,6 +45,7 @@ All other parameters are optional and described in
documentation for
subham611 commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036102203
Fixed UTs and tested locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Lee-W commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036098125
> @Lee-W Where can I see test failure logs?
Scroll down a bit. You should be able to find it here. I just approved the
CI run
subham611 commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036087689
@Lee-W Where can I see test failure logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
subham611 commented on code in PR #38702:
URL: https://github.com/apache/airflow/pull/38702#discussion_r1550790198
##
tests/providers/databricks/operators/test_databricks.py:
##
@@ -1397,6 +1397,70 @@ def test_exec_failure_if_job_id_not_found(self,
db_mock_class):
Lee-W commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036021639
I just noticed the test is failing. We might need your help to resolve it.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Lee-W commented on code in PR #38702:
URL: https://github.com/apache/airflow/pull/38702#discussion_r1550766818
##
tests/providers/databricks/operators/test_databricks.py:
##
@@ -1397,6 +1397,70 @@ def test_exec_failure_if_job_id_not_found(self,
db_mock_class):
SubhamSinghal commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2034931593
@Lee-W Added UTs, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
boring-cyborg[bot] commented on PR #38702:
URL: https://github.com/apache/airflow/pull/38702#issuecomment-2034229136
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our
16 matches
Mail list logo
