Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-11 Thread via GitHub
ferruzzi merged PR #38850: URL: https://github.com/apache/airflow/pull/38850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-10 Thread via GitHub
ferruzzi commented on PR #38850: URL: https://github.com/apache/airflow/pull/38850#issuecomment-2048444921 Gah, static check is just a merge issue, imported the sensor twice. Easy fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-10 Thread via GitHub
ferruzzi commented on PR #38850: URL: https://github.com/apache/airflow/pull/38850#issuecomment-2048127209 Dependency merged; I'll get this rebased on top of that one and merge it this afternoon. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-09 Thread via GitHub
ferruzzi commented on code in PR #38850: URL: https://github.com/apache/airflow/pull/38850#discussion_r1558544946 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -25,7 +25,10 @@ from airflow.exceptions import AirflowException Review Comment: I had to refactor

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-09 Thread via GitHub
ferruzzi commented on code in PR #38850: URL: https://github.com/apache/airflow/pull/38850#discussion_r1558543614 ## tests/system/providers/amazon/aws/example_bedrock.py: ## @@ -127,6 +137,7 @@ def delete_custom_model(model_name: str):

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-09 Thread via GitHub
ferruzzi commented on code in PR #38850: URL: https://github.com/apache/airflow/pull/38850#discussion_r1558148127 ## tests/system/providers/amazon/aws/example_bedrock.py: ## @@ -127,6 +137,7 @@ def delete_custom_model(model_name: str):

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-09 Thread via GitHub
o-nikolas commented on code in PR #38850: URL: https://github.com/apache/airflow/pull/38850#discussion_r1558137372 ## tests/system/providers/amazon/aws/example_bedrock.py: ## @@ -127,6 +137,7 @@ def delete_custom_model(model_name: str):

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-09 Thread via GitHub
ferruzzi commented on code in PR #38850: URL: https://github.com/apache/airflow/pull/38850#discussion_r1558135437 ## airflow/providers/amazon/aws/sensors/bedrock.py: ## @@ -17,36 +17,89 @@ # under the License. from __future__ import annotations +import abc from typing

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-09 Thread via GitHub
ferruzzi commented on code in PR #38850: URL: https://github.com/apache/airflow/pull/38850#discussion_r1558108644 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -25,7 +25,10 @@ from airflow.exceptions import AirflowException Review Comment: dependency cleared.

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-09 Thread via GitHub
vincbeck commented on code in PR #38850: URL: https://github.com/apache/airflow/pull/38850#discussion_r1557596522 ## airflow/providers/amazon/aws/sensors/bedrock.py: ## @@ -17,36 +17,89 @@ # under the License. from __future__ import annotations +import abc from typing

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-08 Thread via GitHub
ferruzzi commented on code in PR #38850: URL: https://github.com/apache/airflow/pull/38850#discussion_r1556503642 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -25,7 +25,10 @@ from airflow.exceptions import AirflowException Review Comment: This comment is

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-08 Thread via GitHub
ferruzzi commented on code in PR #38850: URL: https://github.com/apache/airflow/pull/38850#discussion_r1556503642 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -25,7 +25,10 @@ from airflow.exceptions import AirflowException Review Comment: This comment is

[PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-08 Thread via GitHub
ferruzzi opened a new pull request, #38850: URL: https://github.com/apache/airflow/pull/38850 Adds support for provisioning model throughput on Amazon Bedrock including: operators, sensors, waiters, and triggerer, as well as unit tests and system tests for all of the above, and doc