Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-19 Thread via GitHub
Lee-W merged PR #38736: URL: https://github.com/apache/airflow/pull/38736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-18 Thread via GitHub
Lee-W commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2065676662 I'm planning on merging this one later today. Please let me know if anyone want to take a deeper look. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-18 Thread via GitHub
nathadfield commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2064320036 Is someone able to merge this soon then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-15 Thread via GitHub
nathadfield commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2056407925 @Lee-W No worries. Thanks for the input. @utkarsharma2 It'd be great to get any more thoughts from you. -- This is an automated message from the Apache Git Service. To

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-15 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1565324842 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-12 Thread via GitHub
Lee-W commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1562745520 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-11 Thread via GitHub
nathadfield commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2049342834 Just looking for someone to give it a  now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-10 Thread via GitHub
nathadfield commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2047503036 > Looks like network issue 樂 let me try again. if it still fails, I'll take a deeper look You seem to have the magic touch! -- This is an automated message from the Apache

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-10 Thread via GitHub
Lee-W commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2047305614 Looks like network issue 樂 let me try again. if it still fails, I'll take a deeper look -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-10 Thread via GitHub
nathadfield commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2047092555 @Lee-W I keep rebasing and rerunning but some unrelated tests always seem to fail. Any suggestions? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-09 Thread via GitHub
nathadfield commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2045385802 I rebased which ran the checks agan but it's now failing with a different error but still not connected to my changes. How else can I retrigger the checks? -- This is an

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-09 Thread via GitHub
Lee-W commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2045166479 > One failed test here but I don't think it's anything to do with my changes. Just retrigger it. Let's see how it works -- This is an automated message from the Apache Git

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-09 Thread via GitHub
nathadfield commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2045069186 One failed test here but I don't think it's anything to do with my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-09 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1557420968 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-09 Thread via GitHub
teowave commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2044638268 Excellent and timely addition. I was just struggling to get openai chat completions to work straight from within pythonoperator, only to silently hang. Looking forward to seeing this

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-09 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1557326945 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-09 Thread via GitHub
Lee-W commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1557308399 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-09 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1557081040 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-09 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1557072240 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
Lee-W commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1556009587 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1555881195 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1555871738 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1555871738 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1555871245 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1555854814 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1555850833 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
utkarsharma2 commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1555852061 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
nathadfield commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1555850833 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
utkarsharma2 commented on code in PR #38736: URL: https://github.com/apache/airflow/pull/38736#discussion_r1555846716 ## airflow/providers/openai/hooks/openai.py: ## @@ -77,6 +89,165 @@ def get_conn(self) -> OpenAI: **openai_client_kwargs, ) +def

Re: [PR] OpenAI Chat & Assistant hook functions [airflow]

2024-04-08 Thread via GitHub
nathadfield commented on PR #38736: URL: https://github.com/apache/airflow/pull/38736#issuecomment-2042348699 I'd love a review on this when someone gets an opportunity. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to