[GitHub] codecov-io edited a comment on issue #3992: [AIRFLOW-620] Feature to tail custom number of logs instead of rendering whole log

2018-11-05 Thread GitBox
codecov-io edited a comment on issue #3992: [AIRFLOW-620] Feature to tail custom number of logs instead of rendering whole log URL: https://github.com/apache/incubator-airflow/pull/3992#issuecomment-426519197 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3992?src=pr=h1)

[jira] [Created] (AIRFLOW-3302) Small CSS fixes

2018-11-05 Thread Sumit Maheshwari (JIRA)
Sumit Maheshwari created AIRFLOW-3302: - Summary: Small CSS fixes Key: AIRFLOW-3302 URL: https://issues.apache.org/jira/browse/AIRFLOW-3302 Project: Apache Airflow Issue Type: Improvement

[GitHub] bolkedebruin commented on issue #4136: Fix for scheduler infinite loop when evaluating non-UTC DAGs after DST

2018-11-05 Thread GitBox
bolkedebruin commented on issue #4136: Fix for scheduler infinite loop when evaluating non-UTC DAGs after DST URL: https://github.com/apache/incubator-airflow/pull/4136#issuecomment-436151122 Please verify if this issue still exists on master. A fix already went in that should have

[GitHub] msumit commented on issue #4129: [AIRFLOW-3294] Update connections form and integration docs

2018-11-05 Thread GitBox
msumit commented on issue #4129: [AIRFLOW-3294] Update connections form and integration docs URL: https://github.com/apache/incubator-airflow/pull/4129#issuecomment-436147329 @ashb yeah sure, will keep that in mind.  This

[jira] [Resolved] (AIRFLOW-3062) Add Qubole in integration docs

2018-11-05 Thread Sumit Maheshwari (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumit Maheshwari resolved AIRFLOW-3062. --- Resolution: Fixed Fix Version/s: 2.0.0 > Add Qubole in integration docs >

[GitHub] XD-DENG edited a comment on issue #4138: [AIRFLOW-3301] Update DockerOperator unit test for PR #3977 to fix CI failure

2018-11-05 Thread GitBox
XD-DENG edited a comment on issue #4138: [AIRFLOW-3301] Update DockerOperator unit test for PR #3977 to fix CI failure URL: https://github.com/apache/incubator-airflow/pull/4138#issuecomment-436117694 The CI is still failing due to unrelated part

[GitHub] XD-DENG commented on issue #4138: [AIRFLOW-3301] Update unit test for PR #3977 to fix CI failure

2018-11-05 Thread GitBox
XD-DENG commented on issue #4138: [AIRFLOW-3301] Update unit test for PR #3977 to fix CI failure URL: https://github.com/apache/incubator-airflow/pull/4138#issuecomment-436117694 The CI is still failing, but due to unrelated part

[GitHub] Cplo commented on issue #3519: [AIRFLOW-2642] fix wrong value git-sync initcontainer env GIT_SYNC_ROOT

2018-11-05 Thread GitBox
Cplo commented on issue #3519: [AIRFLOW-2642] fix wrong value git-sync initcontainer env GIT_SYNC_ROOT URL: https://github.com/apache/incubator-airflow/pull/3519#issuecomment-436117521 I have run it in our kubernetes environment and it is very stable. My configuration is as follows(XXX

[GitHub] Cplo removed a comment on issue #3519: [AIRFLOW-2642] fix wrong value git-sync initcontainer env GIT_SYNC_ROOT

2018-11-05 Thread GitBox
Cplo removed a comment on issue #3519: [AIRFLOW-2642] fix wrong value git-sync initcontainer env GIT_SYNC_ROOT URL: https://github.com/apache/incubator-airflow/pull/3519#issuecomment-436117076 I have run it in our kubernetes environment and it is very stable. My configuration is as

[GitHub] Cplo commented on issue #3519: [AIRFLOW-2642] fix wrong value git-sync initcontainer env GIT_SYNC_ROOT

2018-11-05 Thread GitBox
Cplo commented on issue #3519: [AIRFLOW-2642] fix wrong value git-sync initcontainer env GIT_SYNC_ROOT URL: https://github.com/apache/incubator-airflow/pull/3519#issuecomment-436117076 I have run it in our kubernetes environment and it is very stable. My configuration is as follows `

[GitHub] XD-DENG commented on issue #4138: [AIRFLOW-3301] Update CI test for PR #3977

2018-11-05 Thread GitBox
XD-DENG commented on issue #4138: [AIRFLOW-3301] Update CI test for PR #3977 URL: https://github.com/apache/incubator-airflow/pull/4138#issuecomment-436113109 No worries. We all made/make/making mistakes ;-) This is an

[GitHub] deagon commented on issue #4138: [AIRFLOW-3301] Update CI test for PR #3977

2018-11-05 Thread GitBox
deagon commented on issue #4138: [AIRFLOW-3301] Update CI test for PR #3977 URL: https://github.com/apache/incubator-airflow/pull/4138#issuecomment-436112371 Sorry for my mistake. LGTM. This is an automated message from the

[GitHub] XD-DENG edited a comment on issue #4138: [AIRFLOW-3301] Update CI test for PR #3977

2018-11-05 Thread GitBox
XD-DENG edited a comment on issue #4138: [AIRFLOW-3301] Update CI test for PR #3977 URL: https://github.com/apache/incubator-airflow/pull/4138#issuecomment-436111972 Hi @deagon , in your PR https://github.com/apache/incubator-airflow/pull/3977, new argument `auto_remove` was added but

[GitHub] XD-DENG commented on issue #4138: [AIRFLOW-3301] Update CI test for PR #3977

2018-11-05 Thread GitBox
XD-DENG commented on issue #4138: [AIRFLOW-3301] Update CI test for PR #3977 URL: https://github.com/apache/incubator-airflow/pull/4138#issuecomment-436111972 Hi @deagon , in your PR https://github.com/apache/incubator-airflow/pull/3977, new argument `auto_remove` was added but the

[GitHub] XD-DENG opened a new pull request #4138: [AIRFLOW-3301] Update CI test for PR #3977

2018-11-05 Thread GitBox
XD-DENG opened a new pull request #4138: [AIRFLOW-3301] Update CI test for PR #3977 URL: https://github.com/apache/incubator-airflow/pull/4138 ### Jira - https://issues.apache.org/jira/browse/AIRFLOW-3301 ### Description In PR

[jira] [Commented] (AIRFLOW-3301) Update CI test for [AIRFLOW-3132] (PR #3977)

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676055#comment-16676055 ] ASF GitHub Bot commented on AIRFLOW-3301: - XD-DENG opened a new pull request #4138:

[jira] [Created] (AIRFLOW-3301) Update CI test for [AIRFLOW-3132] (PR #3977)

2018-11-05 Thread Xiaodong DENG (JIRA)
Xiaodong DENG created AIRFLOW-3301: -- Summary: Update CI test for [AIRFLOW-3132] (PR #3977) Key: AIRFLOW-3301 URL: https://issues.apache.org/jira/browse/AIRFLOW-3301 Project: Apache Airflow

[GitHub] r39132 commented on issue #4137: [AIRFLOW-XXX] Fix Docstrings in Hooks, Sensors & Operators

2018-11-05 Thread GitBox
r39132 commented on issue #4137: [AIRFLOW-XXX] Fix Docstrings in Hooks, Sensors & Operators URL: https://github.com/apache/incubator-airflow/pull/4137#issuecomment-436109582 @kaxil Do you have a count before and after your change that shows a reduction in flake8 errors?

[GitHub] fordguo closed pull request #2227: [AIRFLOW-1083] Fixes the connect error when jaydebeapi >1.0 and the jdbc's autocommit bug

2018-11-05 Thread GitBox
fordguo closed pull request #2227: [AIRFLOW-1083] Fixes the connect error when jaydebeapi >1.0 and the jdbc's autocommit bug URL: https://github.com/apache/incubator-airflow/pull/2227 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[jira] [Commented] (AIRFLOW-1083) after jaydebeapi >=1.0, use the connect(jclassname, url, driver_args...)

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676004#comment-16676004 ] ASF GitHub Bot commented on AIRFLOW-1083: - fordguo closed pull request #2227: [AIRFLOW-1083]

[GitHub] fordguo commented on issue #2227: [AIRFLOW-1083] Fixes the connect error when jaydebeapi >1.0 and the jdbc's autocommit bug

2018-11-05 Thread GitBox
fordguo commented on issue #2227: [AIRFLOW-1083] Fixes the connect error when jaydebeapi >1.0 and the jdbc's autocommit bug URL: https://github.com/apache/incubator-airflow/pull/2227#issuecomment-436107108 > @fordguo are you still working on this? @ron819 it worked on my legacy

[jira] [Commented] (AIRFLOW-3272) Create gRPC hook for creating generic grpc connection

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675947#comment-16675947 ] ASF GitHub Bot commented on AIRFLOW-3272: - morgendave opened a new pull request #4101:

[jira] [Commented] (AIRFLOW-3272) Create gRPC hook for creating generic grpc connection

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675946#comment-16675946 ] ASF GitHub Bot commented on AIRFLOW-3272: - morgendave closed pull request #4101: [AIRFLOW-3272]

[GitHub] morgendave closed pull request #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave closed pull request #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] morgendave opened a new pull request #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave opened a new pull request #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101 Make sure you have checked all steps below. Jira My PR addresses the following Airflow Jira issues and references them in the PR title. For

[GitHub] codecov-io edited a comment on issue #4030: [AIRFLOW-XXX] Log the task_id in the PendingDeprecationWarning for BaseOperator

2018-11-05 Thread GitBox
codecov-io edited a comment on issue #4030: [AIRFLOW-XXX] Log the task_id in the PendingDeprecationWarning for BaseOperator URL: https://github.com/apache/incubator-airflow/pull/4030#issuecomment-428644838 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4030?src=pr=h1)

[GitHub] kaxil edited a comment on issue #4137: [AIRFLOW-XXX] Fix Docstrings in Hooks, Sensors & Operators

2018-11-05 Thread GitBox
kaxil edited a comment on issue #4137: [AIRFLOW-XXX] Fix Docstrings in Hooks, Sensors & Operators URL: https://github.com/apache/incubator-airflow/pull/4137#issuecomment-436084787 @Fokko @ashb @r39132I found https://pypi.org/project/flake8-docstrings/ which we can include it in

[GitHub] kaxil commented on issue #4137: [AIRFLOW-XXX] Fix Docstrings in Hooks, Sensors & Operators

2018-11-05 Thread GitBox
kaxil commented on issue #4137: [AIRFLOW-XXX] Fix Docstrings in Hooks, Sensors & Operators URL: https://github.com/apache/incubator-airflow/pull/4137#issuecomment-436084787 @Fokko @ashb I found https://pypi.org/project/flake8-docstrings/ which we can include it in

[GitHub] kaxil opened a new pull request #4137: [AIRFLOW-XXX] Fix Docstrings in Hooks, Sensors & Operators

2018-11-05 Thread GitBox
kaxil opened a new pull request #4137: [AIRFLOW-XXX] Fix Docstrings in Hooks, Sensors & Operators URL: https://github.com/apache/incubator-airflow/pull/4137 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] exploy commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator

2018-11-05 Thread GitBox
exploy commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator URL: https://github.com/apache/incubator-airflow/pull/4134#discussion_r230953238 ## File path: airflow/contrib/operators/adls_to_gcs.py ## @@ -0,0 +1,144 @@ +# -*- coding: utf-8

[GitHub] exploy commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator

2018-11-05 Thread GitBox
exploy commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator URL: https://github.com/apache/incubator-airflow/pull/4134#discussion_r230950581 ## File path: airflow/contrib/operators/adls_to_gcs.py ## @@ -0,0 +1,144 @@ +# -*- coding: utf-8

[GitHub] Padarn commented on issue #4089: adding image_pull_secrets into pod at creation inside operator

2018-11-05 Thread GitBox
Padarn commented on issue #4089: adding image_pull_secrets into pod at creation inside operator URL: https://github.com/apache/incubator-airflow/pull/4089#issuecomment-436070775 Apologies I thought I had, I’ll read more closely. On Tue, 6 Nov 2018 at 1:24 AM, Fokko Driesprong

[GitHub] exploy commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator

2018-11-05 Thread GitBox
exploy commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator URL: https://github.com/apache/incubator-airflow/pull/4134#discussion_r230948173 ## File path: airflow/contrib/operators/adls_to_gcs.py ## @@ -0,0 +1,144 @@ +# -*- coding: utf-8

[GitHub] exploy commented on a change in pull request #4118: [AIRFLOW-3271] Airflow RBAC Permissions modification via UI do not persist

2018-11-05 Thread GitBox
exploy commented on a change in pull request #4118: [AIRFLOW-3271] Airflow RBAC Permissions modification via UI do not persist URL: https://github.com/apache/incubator-airflow/pull/4118#discussion_r230946740 ## File path: airflow/www_rbac/security.py ## @@ -181,13 +181,17

[GitHub] matt-land opened a new pull request #4136: Fix for scheduler infinite loop when evaluating non-UTC DAGs after DST

2018-11-05 Thread GitBox
matt-land opened a new pull request #4136: Fix for scheduler infinite loop when evaluating non-UTC DAGs after DST URL: https://github.com/apache/incubator-airflow/pull/4136 …ing than their start state Make sure you have checked _all_ steps below. ### Jira - [ ] My PR

[jira] [Commented] (AIRFLOW-3272) Create gRPC hook for creating generic grpc connection

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675856#comment-16675856 ] ASF GitHub Bot commented on AIRFLOW-3272: - morgendave opened a new pull request #4101:

[GitHub] aoen commented on issue #4005: [AIRFLOW-3160] Load latest_dagruns asynchronously, speed up front page load time

2018-11-05 Thread GitBox
aoen commented on issue #4005: [AIRFLOW-3160] Load latest_dagruns asynchronously, speed up front page load time URL: https://github.com/apache/incubator-airflow/pull/4005#issuecomment-436066368 @Fokko thanks! I owe you a PR review :).

[jira] [Commented] (AIRFLOW-3272) Create gRPC hook for creating generic grpc connection

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675855#comment-16675855 ] ASF GitHub Bot commented on AIRFLOW-3272: - morgendave closed pull request #4101: [AIRFLOW-3272]

[GitHub] morgendave opened a new pull request #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave opened a new pull request #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101 Make sure you have checked all steps below. Jira My PR addresses the following Airflow Jira issues and references them in the PR title. For

[GitHub] morgendave closed pull request #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave closed pull request #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] janhicken commented on issue #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates

2018-11-05 Thread GitBox
janhicken commented on issue #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates URL: https://github.com/apache/incubator-airflow/pull/4125#issuecomment-436064621 Alright, I will do this as you descriubed @kaxil

[GitHub] codecov-io edited a comment on issue #2551: [AIRFLOW-1543] Improve error message for incorrect fernet_key

2018-11-05 Thread GitBox
codecov-io edited a comment on issue #2551: [AIRFLOW-1543] Improve error message for incorrect fernet_key URL: https://github.com/apache/incubator-airflow/pull/2551#issuecomment-325708902 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/2551?src=pr=h1) Report > Merging

[GitHub] kaxil commented on issue #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates

2018-11-05 Thread GitBox
kaxil commented on issue #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates URL: https://github.com/apache/incubator-airflow/pull/4125#issuecomment-436060616 I have Reverted the changes becaue for the location API, `location` is is required. You will need

[GitHub] kaxil closed pull request #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates

2018-11-05 Thread GitBox
kaxil closed pull request #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates URL: https://github.com/apache/incubator-airflow/pull/4125 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[jira] [Commented] (AIRFLOW-2715) Dataflow template operator dosenot support region parameter

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675820#comment-16675820 ] ASF GitHub Bot commented on AIRFLOW-2715: - kaxil closed pull request #4125: [AIRFLOW-2715] Pick

[GitHub] morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-436054758 > At the bottom of your PR, click “close pull request”, and then re-open it to trigger the build. > […](#) > On 5 Nov 2018, at

[jira] [Commented] (AIRFLOW-3272) Create gRPC hook for creating generic grpc connection

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675813#comment-16675813 ] ASF GitHub Bot commented on AIRFLOW-3272: - morgendave closed pull request #4101: [AIRFLOW-3272]

[jira] [Commented] (AIRFLOW-3272) Create gRPC hook for creating generic grpc connection

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675814#comment-16675814 ] ASF GitHub Bot commented on AIRFLOW-3272: - morgendave opened a new pull request #4101:

[GitHub] morgendave opened a new pull request #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave opened a new pull request #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101 Make sure you have checked all steps below. Jira My PR addresses the following Airflow Jira issues and references them in the PR title. For

[GitHub] morgendave closed pull request #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave closed pull request #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2018-11-05 Thread GitBox
odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#issuecomment-436051806 @Fokko rebased This is an automated message from the

[GitHub] odracci commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2018-11-05 Thread GitBox
odracci commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#discussion_r230929668 ## File path: scripts/ci/kubernetes/kube/deploy.sh ## @@ -22,16 +22,130 @@ set -x

[GitHub] odracci commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2018-11-05 Thread GitBox
odracci commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#discussion_r230929468 ## File path: airflow/contrib/executors/kubernetes_executor.py ## @@ -197,10 +209,15

[GitHub] cbandy commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2018-11-05 Thread GitBox
cbandy commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#discussion_r230925125 ## File path: airflow/contrib/executors/kubernetes_executor.py ## @@ -197,10 +209,15

[GitHub] BasPH commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
BasPH commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-436046161 At the bottom of your PR, click “close pull request”, and then re-open it to trigger the build. > On 5 Nov 2018, at 20:59, morgendave

[GitHub] morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-436014689 New test failures seem to be irrelevant to this PR, how can I re trigger the build?

[jira] [Commented] (AIRFLOW-2192) Don't authenticate on Google Authentication

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675696#comment-16675696 ] Fokko Driesprong commented on AIRFLOW-2192: --- Ah check, thanks! > Don't authenticate on

[GitHub] Fokko commented on issue #4133: [AIRFLOW-3270] Allow passwordless-binding for LDAP auth backend

2018-11-05 Thread GitBox
Fokko commented on issue #4133: [AIRFLOW-3270] Allow passwordless-binding for LDAP auth backend URL: https://github.com/apache/incubator-airflow/pull/4133#issuecomment-436011338 @ashb Would it be possible to test this? This

[GitHub] Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-05 Thread GitBox
Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r230886597 ## File path: airflow/contrib/operators/azure_container_instances_operator.py ## @@ -0,0

[GitHub] Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-05 Thread GitBox
Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r230887240 ## File path: airflow/contrib/operators/azure_container_instances_operator.py ## @@ -0,0

[GitHub] Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-05 Thread GitBox
Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r230887303 ## File path: airflow/contrib/operators/azure_container_instances_operator.py ## @@ -0,0

[GitHub] Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-05 Thread GitBox
Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r230887887 ## File path: airflow/contrib/hooks/azure_container_hook.py ## @@ -0,0 +1,129 @@ + +# -*-

[GitHub] Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-05 Thread GitBox
Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r230887912 ## File path: airflow/contrib/hooks/azure_container_hook.py ## @@ -0,0 +1,129 @@ + +# -*-

[jira] [Comment Edited] (AIRFLOW-2192) Don't authenticate on Google Authentication

2018-11-05 Thread holdenk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675691#comment-16675691 ] holdenk edited comment on AIRFLOW-2192 at 11/5/18 7:47 PM: --- [~Fokko]So

[jira] [Commented] (AIRFLOW-2192) Don't authenticate on Google Authentication

2018-11-05 Thread holdenk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675691#comment-16675691 ] holdenk commented on AIRFLOW-2192: -- [~Fokko]So looking up the specific character the user reports as

[GitHub] codecov-io commented on issue #4133: [AIRFLOW-3270] Allow passwordless-binding for LDAP auth backend

2018-11-05 Thread GitBox
codecov-io commented on issue #4133: [AIRFLOW-3270] Allow passwordless-binding for LDAP auth backend URL: https://github.com/apache/incubator-airflow/pull/4133#issuecomment-436009600 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4133?src=pr=h1) Report > Merging

[GitHub] Fokko closed pull request #4135: [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com

2018-11-05 Thread GitBox
Fokko closed pull request #4135: [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com URL: https://github.com/apache/incubator-airflow/pull/4135 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (AIRFLOW-3262) Can't get log containing Response when using SimpleHttpOperator

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675671#comment-16675671 ] ASF GitHub Bot commented on AIRFLOW-3262: - Fokko closed pull request #4135: [AIRFLOW-3262]

[GitHub] Fokko commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator

2018-11-05 Thread GitBox
Fokko commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator URL: https://github.com/apache/incubator-airflow/pull/4134#discussion_r230882277 ## File path: airflow/contrib/operators/adls_to_gcs.py ## @@ -0,0 +1,144 @@ +# -*- coding: utf-8

[GitHub] Fokko commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator

2018-11-05 Thread GitBox
Fokko commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator URL: https://github.com/apache/incubator-airflow/pull/4134#discussion_r230882680 ## File path: airflow/contrib/operators/adls_to_gcs.py ## @@ -0,0 +1,144 @@ +# -*- coding: utf-8

[GitHub] Fokko commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator

2018-11-05 Thread GitBox
Fokko commented on a change in pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator URL: https://github.com/apache/incubator-airflow/pull/4134#discussion_r230882903 ## File path: airflow/contrib/operators/adls_to_gcs.py ## @@ -0,0 +1,144 @@ +# -*- coding: utf-8

[GitHub] codecov-io commented on issue #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates

2018-11-05 Thread GitBox
codecov-io commented on issue #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates URL: https://github.com/apache/incubator-airflow/pull/4125#issuecomment-436005504 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4125?src=pr=h1) Report >

[jira] [Commented] (AIRFLOW-1368) Automatically remove the container when it exits

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675652#comment-16675652 ] ASF GitHub Bot commented on AIRFLOW-1368: - Fokko closed pull request #3741: [AIRFLOW-1368] Add

[GitHub] Fokko closed pull request #3741: [AIRFLOW-1368] Add auto_remove for DockerOperator

2018-11-05 Thread GitBox
Fokko closed pull request #3741: [AIRFLOW-1368] Add auto_remove for DockerOperator URL: https://github.com/apache/incubator-airflow/pull/3741 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] Fokko commented on issue #3741: [AIRFLOW-1368] Add auto_remove for DockerOperator

2018-11-05 Thread GitBox
Fokko commented on issue #3741: [AIRFLOW-1368] Add auto_remove for DockerOperator URL: https://github.com/apache/incubator-airflow/pull/3741#issuecomment-436003996 Supersed by https://github.com/apache/incubator-airflow/pull/3977

[jira] [Resolved] (AIRFLOW-3132) Allow to specify auto_remove option for DockerOperator

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-3132. --- Resolution: Fixed > Allow to specify auto_remove option for DockerOperator >

[jira] [Reopened] (AIRFLOW-3132) Allow to specify auto_remove option for DockerOperator

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong reopened AIRFLOW-3132: --- > Allow to specify auto_remove option for DockerOperator >

[jira] [Resolved] (AIRFLOW-3132) Allow to specify auto_remove option for DockerOperator

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-3132. --- Resolution: Fixed Fix Version/s: 2.0.0 > Allow to specify auto_remove

[jira] [Resolved] (AIRFLOW-516) docker_operator - remove unused container

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-516. -- Resolution: Fixed Fix Version/s: 2.0.0 > docker_operator - remove unused

[jira] [Resolved] (AIRFLOW-465) docker_operator - Destroy docker container on success

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-465. -- Resolution: Fixed Fix Version/s: 2.0.0 > docker_operator - Destroy docker

[jira] [Commented] (AIRFLOW-3132) Allow to specify auto_remove option for DockerOperator

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675646#comment-16675646 ] ASF GitHub Bot commented on AIRFLOW-3132: - Fokko closed pull request #3977: [AIRFLOW-3132] Add

[GitHub] Fokko closed pull request #3977: [AIRFLOW-3132] Add option for DockerOperator

2018-11-05 Thread GitBox
Fokko closed pull request #3977: [AIRFLOW-3132] Add option for DockerOperator URL: https://github.com/apache/incubator-airflow/pull/3977 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] bolkedebruin commented on issue #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP

2018-11-05 Thread GitBox
bolkedebruin commented on issue #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP URL: https://github.com/apache/incubator-airflow/pull/4006#issuecomment-436002752 @ashb I think we should require ldap to be secure. If somebody doesn't want secure they should hack

[jira] [Commented] (AIRFLOW-3193) Pin docker requirement version

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675639#comment-16675639 ] ASF GitHub Bot commented on AIRFLOW-3193: - Fokko closed pull request #4130: [AIRFLOW-3193] Pin

[jira] [Resolved] (AIRFLOW-3193) Pin docker requirement version

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-3193. --- Resolution: Fixed Fix Version/s: 2.0.0 > Pin docker requirement version >

[jira] [Reopened] (AIRFLOW-3193) Pin docker requirement version

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong reopened AIRFLOW-3193: --- > Pin docker requirement version > -- > >

[GitHub] Fokko closed pull request #4130: [AIRFLOW-3193] Pin docker requirement version

2018-11-05 Thread GitBox
Fokko closed pull request #4130: [AIRFLOW-3193] Pin docker requirement version URL: https://github.com/apache/incubator-airflow/pull/4130 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] ashb commented on a change in pull request #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP

2018-11-05 Thread GitBox
ashb commented on a change in pull request #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP URL: https://github.com/apache/incubator-airflow/pull/4006#discussion_r230875122 ## File path: airflow/contrib/auth/backends/ldap_auth.py ## @@ -55,16 +55,20

[GitHub] bolkedebruin commented on issue #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP

2018-11-05 Thread GitBox
bolkedebruin commented on issue #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP URL: https://github.com/apache/incubator-airflow/pull/4006#issuecomment-435997392 Please verify if you are really negotating the highest level of security. Maybe with a test. Docs seem

[GitHub] bolkedebruin commented on a change in pull request #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP

2018-11-05 Thread GitBox
bolkedebruin commented on a change in pull request #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP URL: https://github.com/apache/incubator-airflow/pull/4006#discussion_r230873322 ## File path: airflow/contrib/auth/backends/ldap_auth.py ## @@

[jira] [Commented] (AIRFLOW-3253) KubernetesPodOperator Unauthorized Code 401

2018-11-05 Thread Trevor Edwards (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675618#comment-16675618 ] Trevor Edwards commented on AIRFLOW-3253: - The fix is merged now. I think it will be in the

[GitHub] Fokko commented on issue #4127: Bug Fix: Secrets object and key separated by ":"

2018-11-05 Thread GitBox
Fokko commented on issue #4127: Bug Fix: Secrets object and key separated by ":" URL: https://github.com/apache/incubator-airflow/pull/4127#issuecomment-435996676 @uesenthi Travis is failing. Can't we supply a dict instead of exploding strings?

[GitHub] bolkedebruin commented on a change in pull request #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP

2018-11-05 Thread GitBox
bolkedebruin commented on a change in pull request #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP URL: https://github.com/apache/incubator-airflow/pull/4006#discussion_r230873322 ## File path: airflow/contrib/auth/backends/ldap_auth.py ## @@

[GitHub] bolkedebruin commented on a change in pull request #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP

2018-11-05 Thread GitBox
bolkedebruin commented on a change in pull request #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP URL: https://github.com/apache/incubator-airflow/pull/4006#discussion_r230873322 ## File path: airflow/contrib/auth/backends/ldap_auth.py ## @@

[GitHub] Fokko commented on a change in pull request #4126: [AIRFLOW-2524] More AWS SageMaker operators, sensors for model, endpoint-config and endpoint

2018-11-05 Thread GitBox
Fokko commented on a change in pull request #4126: [AIRFLOW-2524] More AWS SageMaker operators, sensors for model, endpoint-config and endpoint URL: https://github.com/apache/incubator-airflow/pull/4126#discussion_r230872182 ## File path:

[GitHub] Fokko commented on issue #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates

2018-11-05 Thread GitBox
Fokko commented on issue #4125: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates URL: https://github.com/apache/incubator-airflow/pull/4125#issuecomment-435994411 @janhicken Retriggered the CI.

[GitHub] ashb commented on issue #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP

2018-11-05 Thread GitBox
ashb commented on issue #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP URL: https://github.com/apache/incubator-airflow/pull/4006#issuecomment-435993735 In the fixup commit I just pushed I have re-enabled the ability to not have to use a certificate on the ldap

[GitHub] Fokko closed pull request #4087: [AIRFLOW-2192] Allow non-latin1 usernames with MySQL back-end

2018-11-05 Thread GitBox
Fokko closed pull request #4087: [AIRFLOW-2192] Allow non-latin1 usernames with MySQL back-end URL: https://github.com/apache/incubator-airflow/pull/4087 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Commented] (AIRFLOW-2192) Don't authenticate on Google Authentication

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675596#comment-16675596 ] ASF GitHub Bot commented on AIRFLOW-2192: - Fokko closed pull request #4087: [AIRFLOW-2192]

[GitHub] Fokko commented on issue #4087: [AIRFLOW-2192] Allow non-latin1 usernames with MySQL back-end

2018-11-05 Thread GitBox
Fokko commented on issue #4087: [AIRFLOW-2192] Allow non-latin1 usernames with MySQL back-end URL: https://github.com/apache/incubator-airflow/pull/4087#issuecomment-435992032 Thanks Holden, another happy saved This is an

  1   2   3   >