NielsZeilemaker commented on issue #4322: [AIRFLOW-3518] Performance fixes for 
topological_sort
URL: 
https://github.com/apache/incubator-airflow/pull/4322#issuecomment-447553072
 
 
   @feng-tao that's correct, i've modified the condition to check for `task_id` 
and in the other equality check to check for `dag_id` as a performance 
optimization. The original check (using `self._comps`) is still there.
   
   During our performance test we saw a lot of calls to both `__eq__` methods, 
and hence the small modification to make them perform better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to