[GitHub] kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables

2018-08-15 Thread GitBox
kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables URL: https://github.com/apache/incubator-airflow/pull/3748#issuecomment-413151970 @ron819 I didn't get mad at all, apologies and sorry if you felt so. I seriously think that it should have been a

[GitHub] kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables

2018-08-15 Thread GitBox
kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables URL: https://github.com/apache/incubator-airflow/pull/3748#issuecomment-413141931 @ron819 Even if a user decides whether a field is sensitive or not, you would still need to add the functionality

[GitHub] kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables

2018-08-15 Thread GitBox
kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables URL: https://github.com/apache/incubator-airflow/pull/3748#issuecomment-413134052 @ashb No worries. The aim of this PR was to obfuscate sensitive variables from UI export but it would still allow

[GitHub] kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables

2018-08-15 Thread GitBox
kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables URL: https://github.com/apache/incubator-airflow/pull/3748#issuecomment-413132605 @ashb Thoughts? This is an automated message from

[GitHub] kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables

2018-08-15 Thread GitBox
kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables URL: https://github.com/apache/incubator-airflow/pull/3748#issuecomment-413132540 @Fokko Fixing this on API level will mean we won't be able to get the variables in plain text through CLI as well.

[GitHub] kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables

2018-08-14 Thread GitBox
kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables URL: https://github.com/apache/incubator-airflow/pull/3748#issuecomment-413024537 @feng-tao Would you or someone with good Flask experience (e.g. @jgao54 , @Fokko ) be able to help with adding a

[GitHub] kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables

2018-08-14 Thread GitBox
kaxil commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when Exporting Variables URL: https://github.com/apache/incubator-airflow/pull/3748#issuecomment-412897241 cc @Fokko @feng-tao @bolkedebruin This is an