[GitHub] morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-19 Thread GitBox
morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-440013513 > Would it be possible to add some tests to this PR as well? In progress. I would lean to merge this first since the operator and

[GitHub] morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-07 Thread GitBox
morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-436780285 The build error is due to DockerOperatorTest and has nothing to do with this PR at all. Should be ok to merge. Thanks

[GitHub] morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-436054758 > At the bottom of your PR, click “close pull request”, and then re-open it to trigger the build. > […](#) > On 5 Nov 2018, at

[GitHub] morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-436014689 New test failures seem to be irrelevant to this PR, how can I re trigger the build?

[GitHub] morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-435987126 > @morgendave Can you rebase onto master as well? Sure, thanks for the reminder