[
https://issues.apache.org/jira/browse/AIRFLOW-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626845#comment-16626845
]
ASF GitHub Bot commented on AIRFLOW-3112:
-----------------------------------------
ckljohn opened a new pull request #3945: [AIRFLOW-3112] Make SFTP hook to
inherit SSH hook
URL: https://github.com/apache/incubator-airflow/pull/3945
This is to aline the arguments of SFTP hook with SSH hook
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3112
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This PR is to aline the arguments of SFTP hook with SSH hook
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
There is no new feature. The existing tests should cover this PR.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Aline SFTP hook with SSH hook
> -----------------------------
>
> Key: AIRFLOW-3112
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3112
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
> Affects Versions: 1.10.0
> Reporter: John Cheng
> Assignee: John Cheng
> Priority: Minor
> Fix For: 1.10.1
>
>
> SFTP hook input arguments should be alined with SSH hook so that it can use
> SSH connections.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
