[GitHub] feng-tao edited a comment on issue #3732: Fix typos detected by github.com/client9/misspell

feng-tao edited a comment on issue #3732: Fix typos detected by github.com/client9/misspell URL: https://github.com/apache/incubator-airflow/pull/3732#issuecomment-412148787 hey @seratch , the tool looks very useful :). Your change lgtm. But could you help to create a jira ticket and

[GitHub] ashb commented on a change in pull request #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …

ashb commented on a change in pull request #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook … URL: https://github.com/apache/incubator-airflow/pull/3722#discussion_r208868122 ## File path: airflow/contrib/hooks/gcp_api_base_hook.py ## @@ -147,6

[GitHub] ashb commented on a change in pull request #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …

ashb commented on a change in pull request #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook … URL: https://github.com/apache/incubator-airflow/pull/3722#discussion_r208867850 ## File path: airflow/hooks/base_hook.py ## @@ -88,6 +89,20 @@ def

[GitHub] ashb commented on a change in pull request #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …

ashb commented on a change in pull request #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook … URL: https://github.com/apache/incubator-airflow/pull/3722#discussion_r208867658 ## File path: airflow/hooks/base_hook.py ## @@ -88,6 +89,20 @@ def

[GitHub] XD-DENG commented on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()

XD-DENG commented on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView() URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411683117 Thanks @feng-tao . Not sure whether Ad Hoc Query can be considered safe under `Admin` role.

[GitHub] XD-DENG closed pull request #3688: [AIRFLOW-2843] ExternalTaskSensor-check if external task exists

XD-DENG closed pull request #3688: [AIRFLOW-2843] ExternalTaskSensor-check if external task exists URL: https://github.com/apache/incubator-airflow/pull/3688 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ashb commented on issue #3721: [AIRFLOW-2875] Escape env vars in tmp config

ashb commented on issue #3721: [AIRFLOW-2875] Escape env vars in tmp config URL: https://github.com/apache/incubator-airflow/pull/3721#issuecomment-411702501 What if someone is using `%` interpolation in their config file? Have they already been replaced by the stage we run the replace?

[GitHub] ashb commented on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …

ashb commented on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook … URL: https://github.com/apache/incubator-airflow/pull/3722#issuecomment-411699690 As Ravi mentioned on the Jira: it looks like httplib2 can use HTTP_PROXY and HTTPS_PROXY environment

[GitHub] verdan commented on issue #3572: [AIRFLOW-2691] Makes Airflow's JS code (and dependencies) manageable via npm and webpack

verdan commented on issue #3572: [AIRFLOW-2691] Makes Airflow's JS code (and dependencies) manageable via npm and webpack URL: https://github.com/apache/incubator-airflow/pull/3572#issuecomment-411667830 @JacobHayes the release process page will be updated after the release of 1.10.x, as

[GitHub] lxneng closed pull request #3554: [AIRFLOW-2686] Fix Default Variables not base on default_timezone

lxneng closed pull request #3554: [AIRFLOW-2686] Fix Default Variables not base on default_timezone URL: https://github.com/apache/incubator-airflow/pull/3554 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] XD-DENG commented on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()

XD-DENG commented on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView() URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411634875 Hi @bolkedebruin , as suggested, I have implemented the **Ad Hoc Query** view for RBAC under

[GitHub] feng-tao edited a comment on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()

feng-tao edited a comment on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView() URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411650521 cc @bolkedebruin who gave the initial comment.

[GitHub] codecov-io edited a comment on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …

codecov-io edited a comment on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook … URL: https://github.com/apache/incubator-airflow/pull/3722#issuecomment-411556404 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3722?src=pr=h1) Report

[GitHub] codecov-io edited a comment on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()

codecov-io edited a comment on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView() URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411331261 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3718?src=pr=h1) Report

[GitHub] lxneng commented on issue #3554: [AIRFLOW-2686] Fix Default Variables not base on default_timezone

lxneng commented on issue #3554: [AIRFLOW-2686] Fix Default Variables not base on default_timezone URL: https://github.com/apache/incubator-airflow/pull/3554#issuecomment-411614674 Agree with @Fokko , That would be mush better.

[GitHub] feng-tao commented on a change in pull request #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing

feng-tao commented on a change in pull request #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing URL: https://github.com/apache/incubator-airflow/pull/3648#discussion_r208799225 ## File path: tests/www_rbac/test_views.py ## @@ -172,6 +172,26 @@ def

[GitHub] feng-tao commented on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()

feng-tao commented on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView() URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411650450 1. all the js, css are unnecesary as they are managed by npm. 2. more importantly, Ad HOC query

[GitHub] feng-tao commented on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()

feng-tao commented on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView() URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411650521 cc @bolkedebruin who gave initial comment.

[GitHub] feng-tao edited a comment on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()

feng-tao edited a comment on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView() URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411650450 1. All the js, css are unnecesary as they are managed by npm. 2. More importantly, Ad HOC

[GitHub] XD-DENG opened a new pull request #3724: [AIRFLOW-2781] Fix www_rbac display issue

XD-DENG opened a new pull request #3724: [AIRFLOW-2781] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in

[GitHub] Fokko commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

Fokko commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/incubator-airflow/pull/3723#issuecomment-411749409 Auch, thanks @r39132 This is an automated message from the Apache Git

[GitHub] codecov-io commented on issue #3724: [AIRFLOW-2781] Fix www_rbac display issue

codecov-io commented on issue #3724: [AIRFLOW-2781] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724#issuecomment-411752086 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3724?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue

codecov-io edited a comment on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724#issuecomment-411752086 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3724?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue

codecov-io edited a comment on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724#issuecomment-411752086 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3724?src=pr=h1) Report > Merging

[GitHub] sekikn commented on issue #3555: [AIRFLOW-2687] Move unittest2 to devel in setup.py

sekikn commented on issue #3555: [AIRFLOW-2687] Move unittest2 to devel in setup.py URL: https://github.com/apache/incubator-airflow/pull/3555#issuecomment-411797639 @ron819 @ashb Thanks for notifying and closing ;) This is

[GitHub] ron819 commented on issue #3555: [AIRFLOW-2687] Move unittest2 to devel in setup.py

ron819 commented on issue #3555: [AIRFLOW-2687] Move unittest2 to devel in setup.py URL: https://github.com/apache/incubator-airflow/pull/3555#issuecomment-411789303 @sekikn The jira ticket is still open This is an

[GitHub] wdhorton edited a comment on issue #3721: [AIRFLOW-2875] Escape env vars in tmp config

wdhorton edited a comment on issue #3721: [AIRFLOW-2875] Escape env vars in tmp config URL: https://github.com/apache/incubator-airflow/pull/3721#issuecomment-411796810 This doesn't affect values that are in the config file, just ones that are being pulled from the env (like

[GitHub] wdhorton commented on issue #3721: [AIRFLOW-2875] Escape env vars in tmp config

wdhorton commented on issue #3721: [AIRFLOW-2875] Escape env vars in tmp config URL: https://github.com/apache/incubator-airflow/pull/3721#issuecomment-411796810 This doesn't affect values that are in the config file, just ones that are being pulled from the env (like

[GitHub] XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY URL: https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412227570 Hi @feng-tao , in cluster mode, given the `.cfg` files are initiated on different nodes, the SECRET_KEY will be different.

[GitHub] kaxil commented on issue #3733: [WIP] [AIRFLOW-491] Add cache parameter in BigQuery query method

kaxil commented on issue #3733: [WIP] [AIRFLOW-491] Add cache parameter in BigQuery query method URL: https://github.com/apache/incubator-airflow/pull/3733#issuecomment-412239088 Don't remove any previous parameters, just add support to add new ones

[GitHub] XD-DENG commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue

XD-DENG commented on issue #3724: [AIRFLOW-2878] Fix www_rbac display issue URL: https://github.com/apache/incubator-airflow/pull/3724#issuecomment-412246789 Hi @verdan , FYI, this commit is already reverted via https://github.com/apache/incubator-airflow/pull/3737 . Thanks.

[GitHub] XD-DENG commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

XD-DENG commented on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY URL: https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412227570 Hi @feng-tao , in cluster mode, given the `.cfg` files are initiated on different nodes, the SECRET_KEY will be different. That's also

[GitHub] seratch commented on issue #3732: Fix typos detected by github.com/client9/misspell

seratch commented on issue #3732: Fix typos detected by github.com/client9/misspell URL: https://github.com/apache/incubator-airflow/pull/3732#issuecomment-412304728 @feng-tao I created an issue on JIRA. Also, the description of this PR has been updated.

[GitHub] feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id

feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id URL: https://github.com/apache/incubator-airflow/pull/3629#issuecomment-410876498 thanks @gwax . LGTM. This is an automated

[GitHub] feng-tao closed pull request #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id

feng-tao closed pull request #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id URL: https://github.com/apache/incubator-airflow/pull/3629 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] codecov-io commented on issue #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception

codecov-io commented on issue #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception URL: https://github.com/apache/incubator-airflow/pull/3711#issuecomment-410885905 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3711?src=pr=h1) Report > Merging

[GitHub] Fokko commented on a change in pull request #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception

Fokko commented on a change in pull request #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception URL: https://github.com/apache/incubator-airflow/pull/3711#discussion_r208014056 ## File path: airflow/contrib/hooks/gcp_container_hook.py ## @@ -24,6 +24,7 @@

[GitHub] Fokko commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized

Fokko commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized URL: https://github.com/apache/incubator-airflow/pull/3709#issuecomment-410840187 I think this also requires a database migration.

[GitHub] abdul-stripe commented on issue #3657: [AIRFLOW-2145] fix deadlock on clearing running task instance

abdul-stripe commented on issue #3657: [AIRFLOW-2145] fix deadlock on clearing running task instance URL: https://github.com/apache/incubator-airflow/pull/3657#issuecomment-410862356 friendly bump! cc @bolkedebruin @Fokko

[GitHub] yrqls21 commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file()

yrqls21 commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file() URL: https://github.com/apache/incubator-airflow/pull/3698#discussion_r208049867 ## File path: tests/models.py ## @@ -1038,6 +1038,23 @@ def

[GitHub] yrqls21 commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file()

yrqls21 commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file() URL: https://github.com/apache/incubator-airflow/pull/3698#discussion_r208050009 ## File path: tests/models.py ## @@ -1038,6 +1038,23 @@ def

[GitHub] tedmiston commented on issue #3703: [AIRFLOW-2857] Fix verify_gpl_dependency for Read the Docs

tedmiston commented on issue #3703: [AIRFLOW-2857] Fix verify_gpl_dependency for Read the Docs URL: https://github.com/apache/incubator-airflow/pull/3703#issuecomment-410836135 @ashb @kaxil Replying to all comments here since some are now hidden from lines changing in my force push.

[GitHub] Noremac201 opened a new pull request #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception

Noremac201 opened a new pull request #3711: [AIRFLOW-2863] Fix GKEClusterHook catching wrong exception URL: https://github.com/apache/incubator-airflow/pull/3711 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] feng-tao commented on issue #3703: [AIRFLOW-2857] Fix verify_gpl_dependency for Read the Docs

feng-tao commented on issue #3703: [AIRFLOW-2857] Fix verify_gpl_dependency for Read the Docs URL: https://github.com/apache/incubator-airflow/pull/3703#issuecomment-410851724 I saw a different pr(https://github.com/apache/incubator-airflow/pull/3701). Will that one solve the same issue

[GitHub] Fokko closed pull request #3612: [AIRFLOW-2755] Added `kubernetes.worker_dags_folder` configuration

Fokko closed pull request #3612: [AIRFLOW-2755] Added `kubernetes.worker_dags_folder` configuration URL: https://github.com/apache/incubator-airflow/pull/3612 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id

feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id URL: https://github.com/apache/incubator-airflow/pull/3629#issuecomment-410859702 thanks @gwax . Could you rebase the pr with master? There was an issue with the master which fails the CI. It

[GitHub] feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id

feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id URL: https://github.com/apache/incubator-airflow/pull/3629#issuecomment-410859827 feel free to ping me once you rebase with master and we are good to go.

[GitHub] bolkedebruin commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook

bolkedebruin commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook URL: https://github.com/apache/incubator-airflow/pull/3710#discussion_r208007062 ## File path: airflow/hooks/druid_hook.py ## @@ -53,6 +54,8 @@ def __init__(

[GitHub] cnidus commented on issue #3504: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow

cnidus commented on issue #3504: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow URL: https://github.com/apache/incubator-airflow/pull/3504#issuecomment-410836839 @OElesin I'm also really interested in this submission.

[GitHub] Fokko commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook

Fokko commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook URL: https://github.com/apache/incubator-airflow/pull/3710#discussion_r208008753 ## File path: airflow/hooks/druid_hook.py ## @@ -53,6 +54,8 @@ def __init__(

[GitHub] codecov-io edited a comment on issue #3703: [AIRFLOW-2857] Fix verify_gpl_dependency for Read the Docs

codecov-io edited a comment on issue #3703: [AIRFLOW-2857] Fix verify_gpl_dependency for Read the Docs URL: https://github.com/apache/incubator-airflow/pull/3703#issuecomment-410578804 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3703?src=pr=h1) Report > Merging

[GitHub] tedmiston commented on issue #3703: [AIRFLOW-2857] Fix verify_gpl_dependency for Read the Docs

tedmiston commented on issue #3703: [AIRFLOW-2857] Fix verify_gpl_dependency for Read the Docs URL: https://github.com/apache/incubator-airflow/pull/3703#issuecomment-410855271 @feng-tao That PR makes a related change to the docker run command for local development, but doesn't cover the

[GitHub] gwax commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id

gwax commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id URL: https://github.com/apache/incubator-airflow/pull/3629#issuecomment-410866094 @feng-tao rebased This is an automated message

[GitHub] OElesin commented on issue #3504: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow

OElesin commented on issue #3504: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow URL: https://github.com/apache/incubator-airflow/pull/3504#issuecomment-410857891 @suma-ps and @cnidus , I have plans of working fixing this. But I kinda get squashing commits mixed up at

[GitHub] XD-DENG commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

XD-DENG commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410390539 Hi @kaxil , I didn’t do that since I found detailed examples are already provided under **doc/howto** (

[GitHub] r4vi commented on issue #3612: [AIRFLOW-2755] Added `kubernetes.worker_dags_folder` configuration

r4vi commented on issue #3612: [AIRFLOW-2755] Added `kubernetes.worker_dags_folder` configuration URL: https://github.com/apache/incubator-airflow/pull/3612#issuecomment-410390439 @Fokko I can do it tomorrow This is an

[GitHub] holdenk commented on issue #3692: [AIRFLOW-2847][WIP] Remove legacy imports support for plugins for 2.0 deprecation.

holdenk commented on issue #3692: [AIRFLOW-2847][WIP] Remove legacy imports support for plugins for 2.0 deprecation. URL: https://github.com/apache/incubator-airflow/pull/3692#issuecomment-410399892 It would also be cool if someone knows if this is the right way to execute the tests and

[GitHub] holdenk opened a new pull request #3692: [AIRFLOW-2847][WIP] Remove legacy imports support for plugins

holdenk opened a new pull request #3692: [AIRFLOW-2847][WIP] Remove legacy imports support for plugins URL: https://github.com/apache/incubator-airflow/pull/3692 [AIRFLOW-2847] Remove legacy imports support for plugins This is a WIP since the tests on master aren't passing locally

[GitHub] Fokko commented on a change in pull request #3690: [AIRFLOW-2845] Remove asserts from the contrib package

Fokko commented on a change in pull request #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#discussion_r207702792 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -1518,14 +1517,17 @@ def

[GitHub] codecov-io commented on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package

codecov-io commented on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#issuecomment-410424110 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3690?src=pr=h1) Report > Merging

[GitHub] XD-DENG opened a new pull request #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

XD-DENG opened a new pull request #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and

[GitHub] codecov-io edited a comment on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package

codecov-io edited a comment on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#issuecomment-410424110 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3690?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

codecov-io edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-410963628 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3708?src=pr=h1) Report > Merging

[GitHub] Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208483513 ## File path: airflow/contrib/operators/oracle_to_azure_data_lake_transfer.py

[GitHub] Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208478718 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -238,6

[GitHub] Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208483352 ## File path: airflow/contrib/operators/mongo_to_s3.py ## @@ -105,7

[GitHub] Fokko commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training

Fokko commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training URL: https://github.com/apache/incubator-airflow/pull/3658#discussion_r208486017 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -0,0 +1,239 @@ +# -*- coding: utf-8

[GitHub] codecov-io edited a comment on issue #3710: [AIRFLOW-2860] Update tests for druid hook

codecov-io edited a comment on issue #3710: [AIRFLOW-2860] Update tests for druid hook URL: https://github.com/apache/incubator-airflow/pull/3710#issuecomment-410760084 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3710?src=pr=h1) Report > Merging

[GitHub] tedmiston commented on issue #3587: [WIP][AIRFLOW-2732] Remove hooks and operators from core

tedmiston commented on issue #3587: [WIP][AIRFLOW-2732] Remove hooks and operators from core URL: https://github.com/apache/incubator-airflow/pull/3587#issuecomment-411135195 Closing this PR for now as the next step for this issue is drafting an AIP.

[GitHub] verdan commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues

verdan commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues URL: https://github.com/apache/incubator-airflow/pull/3656#issuecomment-411138672 @tedmiston sounds good to me!!  This is an automated message from

[GitHub] tedmiston commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

tedmiston commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-411139302 Thank you both for the review and initial comments! It sounds like the next step here is probably to get a quick

[GitHub] mistercrunch closed pull request #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

mistercrunch closed pull request #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mistercrunch commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

mistercrunch commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-411163359 I'm unclear as to why contributors went around their way to alias imports, but it appears to be 100% unnecessary.

[GitHub] yrqls21 commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file()

yrqls21 commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file() URL: https://github.com/apache/incubator-airflow/pull/3698#discussion_r208079735 ## File path: tests/models.py ## @@ -1038,6 +1038,23 @@ def

[GitHub] Cplo commented on issue #3697: [AIRFLOW-2854] kubernetes_pod_operator add more configuration items

Cplo commented on issue #3697: [AIRFLOW-2854] kubernetes_pod_operator add more configuration items URL: https://github.com/apache/incubator-airflow/pull/3697#issuecomment-410906442 PTAL？ This is an automated message from

[GitHub] XD-DENG commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file()

XD-DENG commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file() URL: https://github.com/apache/incubator-airflow/pull/3698#discussion_r208080167 ## File path: tests/models.py ## @@ -1038,6 +1038,23 @@ def

[GitHub] feng-tao commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized

feng-tao commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized URL: https://github.com/apache/incubator-airflow/pull/3709#issuecomment-410932006 @vardancse , you need to add an alemic migration script for index change(e.g

[GitHub] yrqls21 commented on issue #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file()

yrqls21 commented on issue #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file() URL: https://github.com/apache/incubator-airflow/pull/3698#issuecomment-410911196 Definitely, looking forward for more of your good work too! Xiaodong 于2018年8月6日 周一下午7:15写道：

[GitHub] codecov-io commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

codecov-io commented on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-410963628 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3708?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

codecov-io edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-410963628 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3708?src=pr=h1) Report > Merging

[GitHub] yeluolei commented on issue #3675: [AIRFLOW-2834] fix build script for k8s docker

yeluolei commented on issue #3675: [AIRFLOW-2834] fix build script for k8s docker URL: https://github.com/apache/incubator-airflow/pull/3675#issuecomment-410954187 wired, the test complains the files in airflow/www_rbac/node_modules/ but there already a rule in .rat-excludes with

[GitHub] bolkedebruin commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized

bolkedebruin commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized URL: https://github.com/apache/incubator-airflow/pull/3709#issuecomment-410962651 Please correct your commit message per guidelines (shorten, remove [improvement],

[GitHub] vardancse commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized

vardancse commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized URL: https://github.com/apache/incubator-airflow/pull/3709#issuecomment-410930822 @Fokko I think I might be missing something, could you please correct me why we need

[GitHub] verdan commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues

verdan commented on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues URL: https://github.com/apache/incubator-airflow/pull/3656#issuecomment-410965163 @r39132 @tedmiston I am working on extracting all inline JS from html files in another PR i.e.,

[GitHub] vardancse commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized

vardancse commented on issue #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized URL: https://github.com/apache/incubator-airflow/pull/3709#issuecomment-410956941 @feng-tao @Fokko Thanks for reviewing and explaining process, I've added migration

[GitHub] r39132 commented on issue #3716: [AIRFLOW-XXX] Remove smart quote from default config

r39132 commented on issue #3716: [AIRFLOW-XXX] Remove smart quote from default config URL: https://github.com/apache/incubator-airflow/pull/3716#issuecomment-411222958 +1 This is an automated message from the Apache Git

[GitHub] feng-tao closed pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

feng-tao closed pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] codecov-io commented on issue #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

codecov-io commented on issue #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#issuecomment-411232814 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3714?src=pr=h1) Report >

[GitHub] xnuinside commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

xnuinside commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208438535 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -238,6

[GitHub] kaxil commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

kaxil commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-411169973 @mistercrunch 樂 I might have definitely done it on `gcs_hook`. Sorry about that. Not sure if I ever use `_os`.

[GitHub] kaxil commented on issue #3714: [WIP][AIRFLOW-2867] Refactor code to conform Python standards & guidelines

kaxil commented on issue #3714: [WIP][AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#issuecomment-411190182 Hi @ashb, Sorry, I need to sort couple of things here. I have added a WIP flag. Will ping you as

[GitHub] ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208377732 ## File path: tests/core.py ## @@ -2423,7 +2423,7 @@ def

[GitHub] codecov-io edited a comment on issue #3586: [AIRFLOW-2733] Reconcile psutil and subprocess in webserver cli

codecov-io edited a comment on issue #3586: [AIRFLOW-2733] Reconcile psutil and subprocess in webserver cli URL: https://github.com/apache/incubator-airflow/pull/3586#issuecomment-403631506 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3586?src=pr=h1) Report >

[GitHub] XD-DENG commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file()

XD-DENG commented on a change in pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file() URL: https://github.com/apache/incubator-airflow/pull/3698#discussion_r208416023 ## File path: tests/models.py ## @@ -56,7 +56,7 @@ from

[GitHub] codecov-io commented on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators

codecov-io commented on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators URL: https://github.com/apache/incubator-airflow/pull/3717#issuecomment-411257030 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3717?src=pr=h1) Report > Merging

[GitHub] r39132 closed pull request #3716: [AIRFLOW-2869] Remove smart quote from default config

r39132 closed pull request #3716: [AIRFLOW-2869] Remove smart quote from default config URL: https://github.com/apache/incubator-airflow/pull/3716 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] feng-tao closed pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file()

feng-tao closed pull request #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file() URL: https://github.com/apache/incubator-airflow/pull/3698 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] feng-tao commented on issue #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file()

feng-tao commented on issue #3698: [AIRFLOW-2855] Check Cron Expression Validity in DagBag.process_file() URL: https://github.com/apache/incubator-airflow/pull/3698#issuecomment-411251048 thanks @XD-DENG @yrqls21 This is

[GitHub] xnuinside commented on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators

xnuinside commented on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators URL: https://github.com/apache/incubator-airflow/pull/3717#issuecomment-411263370 apt-get install failed $ cat ~/apt-get-update.log Ign:1 http://repo.mongodb.org/apt/ubuntu

[GitHub] xnuinside edited a comment on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators

xnuinside edited a comment on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators URL: https://github.com/apache/incubator-airflow/pull/3717#issuecomment-411263370 apt-get install failed

<    1   2   3   4   5   6   7   8   9   10   >