[AIRFLOW-906] Update Code icon from lightning bolt to file Lightning bolts are not a visual metaphor for code or files. Since Glyphicon doesn't have a code icon (<>, for instance), we should use its file icon.
Dear Airflow Maintainers, Please accept this PR that addresses the following issues: AIRFLOW-906 Testing Done: None. Before/After screenshots in AIRFLOW-906 (https://i ssues.apache.org/jira/browse/AIRFLOW-906) Update Code icon from lightning bolt to file Lightning bolts are not a visual metaphor for code or files. Since Glyphicon doesn't have a code icon (<>, for instance), we should use its file icon. Merge pull request #1 from djarratt/djarratt- patch-1 Update Code icon from lightning bolt to file AIRFLOW-906 change glyphicon flash to file Merge pull request #2 from djarratt/djarratt- patch-2 AIRFLOW-906 change glyphicon flash to file Closes #2104 from djarratt/master (cherry picked from commit bc47200711be4d2c0b36b772651dae4f5e01a204) Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/46ca569a Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/46ca569a Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/46ca569a Branch: refs/heads/v1-8-test Commit: 46ca569a37513f3d13c529786f65c7e443c9837e Parents: 2106ff5 Author: Dan Jarratt <djarr...@users.noreply.github.com> Authored: Fri Feb 24 15:00:51 2017 -0800 Committer: Chris Riccomini <criccom...@apache.org> Committed: Wed Mar 29 14:10:33 2017 -0700 ---------------------------------------------------------------------- airflow/www/static/bootstrap-theme.css | 2 +- airflow/www/templates/airflow/dag.html | 2 +- airflow/www/templates/airflow/dags.html | 2 +- airflow/www/templates/airflow/list_dags.html | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/46ca569a/airflow/www/static/bootstrap-theme.css ---------------------------------------------------------------------- diff --git a/airflow/www/static/bootstrap-theme.css b/airflow/www/static/bootstrap-theme.css index 5b126ae..734f940 100644 --- a/airflow/www/static/bootstrap-theme.css +++ b/airflow/www/static/bootstrap-theme.css @@ -3068,7 +3068,7 @@ tbody.collapse.in { .glyphicon-log-in:before { content: "\e161"; } -.glyphicon-flash:before { +.glyphicon-file:before { content: "\e162"; } .glyphicon-log-out:before { http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/46ca569a/airflow/www/templates/airflow/dag.html ---------------------------------------------------------------------- diff --git a/airflow/www/templates/airflow/dag.html b/airflow/www/templates/airflow/dag.html index 8a4793d..c695f04 100644 --- a/airflow/www/templates/airflow/dag.html +++ b/airflow/www/templates/airflow/dag.html @@ -90,7 +90,7 @@ </li> <li> <a href="{{ url_for("airflow.code", dag_id=dag.dag_id, root=root) }}"> - <span class="glyphicon glyphicon-flash" aria-hidden="true"></span> + <span class="glyphicon glyphicon-file" aria-hidden="true"></span> Code </a> </li> http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/46ca569a/airflow/www/templates/airflow/dags.html ---------------------------------------------------------------------- diff --git a/airflow/www/templates/airflow/dags.html b/airflow/www/templates/airflow/dags.html index 5792c6a..7c59dea 100644 --- a/airflow/www/templates/airflow/dags.html +++ b/airflow/www/templates/airflow/dags.html @@ -167,7 +167,7 @@ <!-- Code --> <a href="{{ url_for("airflow.code", dag_id=dag.dag_id) }}" title="Code View"> - <span class="glyphicon glyphicon-flash" aria-hidden="true"></span> + <span class="glyphicon glyphicon-file" aria-hidden="true"></span> </a> <!-- Logs --> http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/46ca569a/airflow/www/templates/airflow/list_dags.html ---------------------------------------------------------------------- diff --git a/airflow/www/templates/airflow/list_dags.html b/airflow/www/templates/airflow/list_dags.html index 2ad9416..9ace2fd 100644 --- a/airflow/www/templates/airflow/list_dags.html +++ b/airflow/www/templates/airflow/list_dags.html @@ -167,7 +167,7 @@ <i class="icon-align-left"></i> </a> <a href="{{ url_for("airflow.code", dag_id=row.dag_id) }}" title="Code View"> - <span class="glyphicon glyphicon-flash" aria-hidden="true"></span> + <span class="glyphicon glyphicon-file" aria-hidden="true"></span> </a> <a href="{{ url_for("airflow.refresh", dag_id=row.dag_id) }}" title="Refresh"> <span class="glyphicon glyphicon-refresh" aria-hidden="true"></span>