ashb commented on a change in pull request #3983: [AIRFLOW-3137] Make ProxyFix
middleware optional.
URL: https://github.com/apache/incubator-airflow/pull/3983#discussion_r221967217
##########
File path: docs/integration.rst
##########
@@ -65,6 +65,12 @@ Your reverse proxy (ex: nginx) should be configured as
follow:
}
}
+To ensure that Airflow generates URLs with the correct scheme when
+running behind a TLS-terminating proxy, you should configure the proxy
+to set the `X-Forwarded-Proto` header, and enable the `ProxyFix`
+middleware in your `airflow.cfg`::
+
+ enable_proxy_fix = True
Review comment:
Can we add a note here saying only enable this when you do have a trusted
proxy in front of Airflow (i.e. nginx, AWS ELB etc.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
