[GitHub] ashb commented on issue #3700: [AIRFLOW-2140] Don't require kubernetes for the SparkSubmit hook

2018-08-06 Thread GitBox
ashb commented on issue #3700: [AIRFLOW-2140] Don't require kubernetes for the 
SparkSubmit hook
URL: 
https://github.com/apache/incubator-airflow/pull/3700#issuecomment-410767604
 
 
   I thought about a local import, but thought that getting told about the 
error as soon as possible would be better, rather than when it delaying it to 
_just_ when the on_kill handler was run.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ashb commented on issue #3700: [AIRFLOW-2140] Don't require kubernetes for the SparkSubmit hook

2018-08-05 Thread GitBox
ashb commented on issue #3700: [AIRFLOW-2140] Don't require kubernetes for the 
SparkSubmit hook
URL: 
https://github.com/apache/incubator-airflow/pull/3700#issuecomment-410545540
 
 
   @bolkedebruin Updated as you suggested


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ashb commented on issue #3700: [AIRFLOW-2140] Don't require kubernetes for the SparkSubmit hook

2018-08-05 Thread GitBox
ashb commented on issue #3700: [AIRFLOW-2140] Don't require kubernetes for the 
SparkSubmit hook
URL: 
https://github.com/apache/incubator-airflow/pull/3700#issuecomment-410544687
 
 
   Confirmed, no other occurances in hooks, and 
airflow/contrib/operators/kubernetes_pod_operator.py loads via 
`airflow.contrib.kubernetes` already.
   
   Yes, doing via a.c.k8s makes sense actually. Will change over.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services