feng-tao closed pull request #4305: [AIRFLOW-3397] Fix integrety error in rbac
AirflowSecurityManager
URL: https://github.com/apache/incubator-airflow/pull/4305
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/www_rbac/security.py b/airflow/www_rbac/security.py
index 8f9b6287ac..369ec71ca7 100644
--- a/airflow/www_rbac/security.py
+++ b/airflow/www_rbac/security.py
@@ -395,8 +395,8 @@ def merge_pv(perm, view_menu):
existing_perm_view_by_user =
self.get_session.query(ab_perm_view_role)\
.filter(ab_perm_view_role.columns.role_id == role.id)
- existing_perms_views = set([role.permission_view_id
- for role in
existing_perm_view_by_user])
+ existing_perms_views = set([pv.permission_view_id
+ for pv in existing_perm_view_by_user])
missing_perm_views = all_perm_views - existing_perms_views
for perm_view_id in missing_perm_views:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
