[GitHub] gwax commented on issue #3720: [AIRFLOW-2870] Use abstract TaskInstance for migration

2018-08-08 Thread GitBox
gwax commented on issue #3720: [AIRFLOW-2870] Use abstract TaskInstance for 
migration
URL: 
https://github.com/apache/incubator-airflow/pull/3720#issuecomment-411480640
 
 
   That works for me now.
   
   :shipit: !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] gwax commented on issue #3720: [AIRFLOW-2870] Use abstract TaskInstance for migration

2018-08-08 Thread GitBox
gwax commented on issue #3720: [AIRFLOW-2870] Use abstract TaskInstance for 
migration
URL: 
https://github.com/apache/incubator-airflow/pull/3720#issuecomment-411461955
 
 
   Clever approach; thanks for taking this on @bolkedebruin 
   
   On attempting `upgradedb`, I run into the following error with this branch:
   
   ```
 File 
"/Users/georgelesliewaksman/.pyenv/versions/2.7.15/envs/temp2/lib/python2.7/site-packages/airflow/migrations/versions/cc1e65623dc7_add_max_tries_column_to_task_instance.py",
 line 98, in upgrade
   ti.max_tries = ti.try_number
   AttributeError: 'TaskInstance' object has no attribute 'try_number'
   ```
   
   Looks like we also need the "try_number" column on the migration version of 
the model:
   
   ```
   try_number = Column(Integer, default=0)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services