xnuinside commented on a change in pull request #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#discussion_r207708750
########## File path: airflow/contrib/hooks/bigquery_hook.py ########## @@ -1518,14 +1517,17 @@ def _bq_cast(string_field, bq_type): elif bq_type == 'FLOAT' or bq_type == 'TIMESTAMP': return float(string_field) elif bq_type == 'BOOLEAN': - assert string_field in set(['true', 'false']) + if string_field not in (['true', 'false']): Review comment: done :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services