[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[ https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632929#comment-16632929 ] ASF GitHub Bot commented on AIRFLOW-2238: - kaxil closed pull request #3978: [AIRFLOW-2238] Update PR tool to remove outdated info URL: https://github.com/apache/incubator-airflow/pull/3978 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/dev/README.md b/dev/README.md index 2f1ecd75ae..0b3797ee0a 100755 --- a/dev/README.md +++ b/dev/README.md @@ -4,7 +4,7 @@ The `airflow-pr` tool interactively guides committers through the process of merging GitHub PRs into Airflow and closing associated JIRA issues. -It is very important that PRs reference a JIRA issue. The preferred way to do that is for the PR title to begin with [AIRFLOW-XX]. However, the PR tool can recognize and parse many other JIRA issue formats in the title and will offer to correct them if possible. +It is very important that PRs reference a JIRA issue. The preferred way to do that is for the PR title to begin with [AIRFLOW-XXX]. However, the PR tool can recognize and parse many other JIRA issue formats in the title and will offer to correct them if possible. __Please note:__ this tool will restore your current branch when it finishes, but you will lose any uncommitted changes. Make sure you commit any changes you wish to keep before proceeding. @@ -61,14 +61,12 @@ pip install click jira tl;dr run `airflow-pr setup_git_remotes` before using the tool for the first time. -Before using the merge tool, users need to make sure their git remotes are configured. By default, the tool assumes a setup like the one below, where the github repo remote is named `github` and the Apache repo remote is named `apache`. If users have other remote names, they can be supplied by setting environment variables `GITHUB_REMOTE_NAME` and `APACHE_REMOTE_NAME`, respectively. +Before using the merge tool, users need to make sure their git remotes are configured. By default, the tool assumes a setup like the one below, where the github repo remote is named `github`. If users have other remote names, they can be supplied by setting environment variables `GITHUB_REMOTE_NAME`. Users can configure this automatically by running `airflow-pr setup_git_remotes`. ```bash $ git remote -v -apache https://git-wip-us.apache.org/repos/asf/incubator-airflow.git (fetch) -apache https://git-wip-us.apache.org/repos/asf/incubator-airflow.git (push) github https://github.com/apache/incubator-airflow.git (fetch) github https://github.com/apache/incubator-airflow.git (push) origin https://github.com//airflow (fetch) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update dev/airflow-pr to work with gitub for merge targets > -- > > Key: AIRFLOW-2238 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2238 > Project: Apache Airflow > Issue Type: Improvement > Components: PR tool >Reporter: Ash Berlin-Taylor >Priority: Major > > We are planning on migrating the to the Apache "GitBox" project which lets > committers work directly on github. This will mean we might not _need_ to use > the pr tool, but we should update it so that it merges and pushes back to > github, not the ASF repo. > I think we need to do this before we ask the ASF infra team to migrate our > repo over. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[
https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632920#comment-16632920
]
ASF GitHub Bot commented on AIRFLOW-2238:
-
kaxil opened a new pull request #3978: [AIRFLOW-2238] Update PR tool to remove
outdated info
URL: https://github.com/apache/incubator-airflow/pull/3978
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2238
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Remove outdated info in Airflow PR tool and its doc
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update dev/airflow-pr to work with gitub for merge targets
> --
>
> Key: AIRFLOW-2238
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2238
> Project: Apache Airflow
> Issue Type: Improvement
> Components: PR tool
>Reporter: Ash Berlin-Taylor
>Priority: Major
>
> We are planning on migrating the to the Apache "GitBox" project which lets
> committers work directly on github. This will mean we might not _need_ to use
> the pr tool, but we should update it so that it merges and pushes back to
> github, not the ASF repo.
> I think we need to do this before we ask the ASF infra team to migrate our
> repo over.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[ https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567407#comment-16567407 ] ASF GitHub Bot commented on AIRFLOW-2238: - kaxil closed pull request #3680: [AIRFLOW-2238] Use SSH protocol for pushing to Github URL: https://github.com/apache/incubator-airflow/pull/3680 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update dev/airflow-pr to work with gitub for merge targets > -- > > Key: AIRFLOW-2238 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2238 > Project: Apache Airflow > Issue Type: Improvement > Components: PR tool >Reporter: Ash Berlin-Taylor >Priority: Major > > We are planning on migrating the to the Apache "GitBox" project which lets > committers work directly on github. This will mean we might not _need_ to use > the pr tool, but we should update it so that it merges and pushes back to > github, not the ASF repo. > I think we need to do this before we ask the ASF infra team to migrate our > repo over. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[ https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567408#comment-16567408 ] ASF subversion and git services commented on AIRFLOW-2238: -- Commit d843f65af24b237d5066292916cb4700f82f7729 in incubator-airflow's branch refs/heads/master from [~ashb] [ https://gitbox.apache.org/repos/asf?p=incubator-airflow.git;h=d843f65 ] [AIRFLOW-2238] Use SSH protocol for pushing to Github (#3680) Since we have MFA enforced we won't be able to use passwords to push and will have to use SSH keypairs. > Update dev/airflow-pr to work with gitub for merge targets > -- > > Key: AIRFLOW-2238 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2238 > Project: Apache Airflow > Issue Type: Improvement > Components: PR tool >Reporter: Ash Berlin-Taylor >Priority: Major > > We are planning on migrating the to the Apache "GitBox" project which lets > committers work directly on github. This will mean we might not _need_ to use > the pr tool, but we should update it so that it merges and pushes back to > github, not the ASF repo. > I think we need to do this before we ask the ASF infra team to migrate our > repo over. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[
https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566470#comment-16566470
]
ASF GitHub Bot commented on AIRFLOW-2238:
-
ashb opened a new pull request #3680: [AIRFLOW-2238] Use SSH protocol for
pushing to Github
URL: https://github.com/apache/incubator-airflow/pull/3680
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2238
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes: Since we have MFA enforced we won't be able to use passwords to push
and will have to use SSH keypairs. I missed this in the original PR.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason: tested manually on another PR
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update dev/airflow-pr to work with gitub for merge targets
> --
>
> Key: AIRFLOW-2238
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2238
> Project: Apache Airflow
> Issue Type: Improvement
> Components: PR tool
>Reporter: Ash Berlin-Taylor
>Priority: Major
>
> We are planning on migrating the to the Apache "GitBox" project which lets
> committers work directly on github. This will mean we might not _need_ to use
> the pr tool, but we should update it so that it merges and pushes back to
> github, not the ASF repo.
> I think we need to do this before we ask the ASF infra team to migrate our
> repo over.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[ https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563402#comment-16563402 ] ASF subversion and git services commented on AIRFLOW-2238: -- Commit 6fdc79980b378222bb0706035bedfe5fcefb982d in incubator-airflow's branch refs/heads/master from [~ashb] [ https://gitbox.apache.org/repos/asf?p=incubator-airflow.git;h=6fdc799 ] Merge pull request #3413 from ashb/pr-tool-git-config [AIRFLOW-2238] Switch PR tool to push to Github > Update dev/airflow-pr to work with gitub for merge targets > -- > > Key: AIRFLOW-2238 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2238 > Project: Apache Airflow > Issue Type: Improvement > Components: PR tool >Reporter: Ash Berlin-Taylor >Priority: Major > > We are planning on migrating the to the Apache "GitBox" project which lets > committers work directly on github. This will mean we might not _need_ to use > the pr tool, but we should update it so that it merges and pushes back to > github, not the ASF repo. > I think we need to do this before we ask the ASF infra team to migrate our > repo over. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[ https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563400#comment-16563400 ] ASF subversion and git services commented on AIRFLOW-2238: -- Commit 4484286e49b7272d2f82e022c0ee5a8690ccc564 in incubator-airflow's branch refs/heads/master from [~ashb] [ https://gitbox.apache.org/repos/asf?p=incubator-airflow.git;h=4484286 ] [AIRFLOW-2238] Flake8 fixes on dev/airflow-pr > Update dev/airflow-pr to work with gitub for merge targets > -- > > Key: AIRFLOW-2238 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2238 > Project: Apache Airflow > Issue Type: Improvement > Components: PR tool >Reporter: Ash Berlin-Taylor >Priority: Major > > We are planning on migrating the to the Apache "GitBox" project which lets > committers work directly on github. This will mean we might not _need_ to use > the pr tool, but we should update it so that it merges and pushes back to > github, not the ASF repo. > I think we need to do this before we ask the ASF infra team to migrate our > repo over. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[ https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563401#comment-16563401 ] ASF subversion and git services commented on AIRFLOW-2238: -- Commit d3793c0a5021df6555a720e9038ccf14b79a1196 in incubator-airflow's branch refs/heads/master from [~ashb] [ https://gitbox.apache.org/repos/asf?p=incubator-airflow.git;h=d3793c0 ] [AIRFLOW-2238] Update PR tool to push directly to Github > Update dev/airflow-pr to work with gitub for merge targets > -- > > Key: AIRFLOW-2238 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2238 > Project: Apache Airflow > Issue Type: Improvement > Components: PR tool >Reporter: Ash Berlin-Taylor >Priority: Major > > We are planning on migrating the to the Apache "GitBox" project which lets > committers work directly on github. This will mean we might not _need_ to use > the pr tool, but we should update it so that it merges and pushes back to > github, not the ASF repo. > I think we need to do this before we ask the ASF infra team to migrate our > repo over. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[
https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563399#comment-16563399
]
ASF GitHub Bot commented on AIRFLOW-2238:
-
ashb closed pull request #3413: [AIRFLOW-2238] Switch PR tool to push to Github
URL: https://github.com/apache/incubator-airflow/pull/3413
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/dev/airflow-pr b/dev/airflow-pr
index 65243ddf87..08eb9aad36 100755
--- a/dev/airflow-pr
+++ b/dev/airflow-pr
@@ -54,7 +54,8 @@ except ImportError:
try:
import keyring
except ImportError:
-print("Could not find the keyring library. Run 'sudo pip install keyring'
to install.")
+print("Could not find the keyring library. "
+ "Run 'sudo pip install keyring' to install.")
sys.exit(-1)
# Location of your Airflow git development area
@@ -64,12 +65,12 @@ AIRFLOW_GIT_LOCATION = os.environ.get(
# Remote name which points to the Gihub site
GITHUB_REMOTE_NAME = os.environ.get("GITHUB_REMOTE_NAME", "github")
-# Remote name which points to Apache git
-APACHE_REMOTE_NAME = os.environ.get("APACHE_REMOTE_NAME", "apache")
-# OAuth key used for issuing requests against the GitHub API. If this is not
defined, then requests
-# will be unauthenticated. You should only need to configure this if you find
yourself regularly
-# exceeding your IP's unauthenticated request rate limit. You can create an
OAuth key at
-# https://github.com/settings/tokens. This tool only requires the
"public_repo" scope.
+# OAuth key used for issuing requests against the GitHub API. If this is not
+# defined, then requests will be unauthenticated. You should only need to
+# configure this if you find yourself regularly exceeding your IP's
+# unauthenticated request rate limit. You can create an OAuth key at
+# https://github.com/settings/tokens. This tool only requires the "public_repo"
+# scope.
GITHUB_OAUTH_KEY = os.environ.get("GITHUB_OAUTH_KEY")
GITHUB_BASE = "https://github.com/apache/incubator-airflow/pull;
@@ -172,7 +173,7 @@ def merge_pr(pr_num, target_ref, title, body, pr_repo_desc,
local):
pr_branch_name = "%s_MERGE_PR_%s" % (BRANCH_PREFIX, pr_num)
target_branch_name = "%s_MERGE_PR_%s_%s" % (BRANCH_PREFIX, pr_num,
target_ref.upper())
run_cmd("git fetch %s pull/%s/head:%s" % (GITHUB_REMOTE_NAME, pr_num,
pr_branch_name))
-run_cmd("git fetch %s %s:%s" % (APACHE_REMOTE_NAME, target_ref,
target_branch_name))
+run_cmd("git fetch %s %s:%s" % (GITHUB_REMOTE_NAME, target_ref,
target_branch_name))
run_cmd("git checkout %s" % target_branch_name)
had_conflicts = False
@@ -205,7 +206,8 @@ def merge_pr(pr_num, target_ref, title, body, pr_repo_desc,
local):
except Exception as e:
msg = "Error merging: %s\nWould you like to manually fix-up this
merge?" % e
continue_maybe(msg)
-msg = "Okay, please fix any conflicts and 'git add' conflicting
files... Finished?"
+msg = ("Okay, please fix any conflicts and 'git add' conflicting
files... " +
+ "Finished?")
continue_maybe(msg)
had_conflicts = True
@@ -216,7 +218,6 @@ def merge_pr(pr_num, target_ref, title, body, pr_repo_desc,
local):
if pr_commits:
all_text += ' '.join(c['commit']['message'] for c in pr_commits)
all_jira_refs = standardize_jira_ref(all_text, only_jira=True)
-all_jira_issues = re.findall("AIRFLOW-[0-9]{1,6}", all_jira_refs)
merge_message_flags = []
@@ -315,7 +316,6 @@ def merge_pr(pr_num, target_ref, title, body, pr_repo_desc,
local):
if primary_author == "":
primary_author = distinct_authors[0]
-authors = "\n".join(["Author: %s" % a for a in distinct_authors])
merge_message_flags.append(u'--author="{}"'.format(primary_author))
else:
@@ -327,7 +327,7 @@ def merge_pr(pr_num, target_ref, title, body, pr_repo_desc,
local):
# reflow commit message
seen_first_line = False
for i in range(1, len(merge_message_flags)):
-if merge_message_flags[i-1] == '-m':
+if merge_message_flags[i - 1] == '-m':
# let the first line be as long as the user wants
if not seen_first_line:
if '\n\n' in merge_message_flags[i]:
@@ -376,7 +376,7 @@ def merge_pr(pr_num, target_ref, title, body, pr_repo_desc,
local):
run_cmd(['git', 'commit'] + commit_flags, echo_cmd=False)
if local:
-msg ='\n' + reflow("""
+msg = '\n' + reflow("""
The PR has been merged locally in branch {}.
You may leave this program running while you work on it. When
you are finished, press any key to delete the
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[ https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563350#comment-16563350 ] ASF GitHub Bot commented on AIRFLOW-2238: - codecov-io edited a comment on issue #3413: [AIRFLOW-2238] Switch PR tool to push to Github URL: https://github.com/apache/incubator-airflow/pull/3413#issuecomment-391769983 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3413?src=pr=h1) Report > Merging [#3413](https://codecov.io/gh/apache/incubator-airflow/pull/3413?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-airflow/commit/dfa7b26ddaca80ee8fd9915ee9f6eac50fac77f6?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-airflow/pull/3413?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3413 +/- ## === Coverage 77.51% 77.51% === Files 205 205 Lines 1575115751 === Hits1221012210 Misses 3541 3541 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3413?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3413?src=pr=footer). Last update [dfa7b26...d3793c0](https://codecov.io/gh/apache/incubator-airflow/pull/3413?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update dev/airflow-pr to work with gitub for merge targets > -- > > Key: AIRFLOW-2238 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2238 > Project: Apache Airflow > Issue Type: Improvement > Components: PR tool >Reporter: Ash Berlin-Taylor >Priority: Major > > We are planning on migrating the to the Apache "GitBox" project which lets > committers work directly on github. This will mean we might not _need_ to use > the pr tool, but we should update it so that it merges and pushes back to > github, not the ASF repo. > I think we need to do this before we ask the ASF infra team to migrate our > repo over. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[ https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496391#comment-16496391 ] Ash Berlin-Taylor commented on AIRFLOW-2238: Requested migration https://issues.apache.org/jira/browse/INFRA-16602 > Update dev/airflow-pr to work with gitub for merge targets > -- > > Key: AIRFLOW-2238 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2238 > Project: Apache Airflow > Issue Type: Improvement > Components: PR tool >Reporter: Ash Berlin-Taylor >Priority: Major > > We are planning on migrating the to the Apache "GitBox" project which lets > committers work directly on github. This will mean we might not _need_ to use > the pr tool, but we should update it so that it merges and pushes back to > github, not the ASF repo. > I think we need to do this before we ask the ASF infra team to migrate our > repo over. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[
https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489030#comment-16489030
]
Ash Berlin-Taylor commented on AIRFLOW-2238:
Done a little bit of digging into this, and the previous script has "duplicate
merged prevention" that relies on actions happening as {{asfgit}} that we won't
be able to duplicate. I don't think that is a huge problem though.
> Update dev/airflow-pr to work with gitub for merge targets
> --
>
> Key: AIRFLOW-2238
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2238
> Project: Apache Airflow
> Issue Type: Improvement
> Components: PR tool
>Reporter: Ash Berlin-Taylor
>Priority: Major
>
> We are planning on migrating the to the Apache "GitBox" project which lets
> committers work directly on github. This will mean we might not _need_ to use
> the pr tool, but we should update it so that it merges and pushes back to
> github, not the ASF repo.
> I think we need to do this before we ask the ASF infra team to migrate our
> repo over.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets
[ https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408066#comment-16408066 ] Ash Berlin-Taylor commented on AIRFLOW-2238: Result of vote calling for this https://lists.apache.org/thread.html/f55014f097849be4e5d86269e4b7b2dfd569348a5c71d1589d6fe706@%3Cdev.airflow.apache.org%3E > Update dev/airflow-pr to work with gitub for merge targets > -- > > Key: AIRFLOW-2238 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2238 > Project: Apache Airflow > Issue Type: Improvement > Components: PR tool >Reporter: Ash Berlin-Taylor >Priority: Major > > We are planning on migrating the to the Apache "GitBox" project which lets > committers work directly on github. This will mean we might not _need_ to use > the pr tool, but we should update it so that it merges and pushes back to > github, not the ASF repo. > I think we need to do this before we ask the ASF infra team to migrate our > repo over. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
