[jira] [Commented] (AIRFLOW-258) Always load plugin executors
[ https://issues.apache.org/jira/browse/AIRFLOW-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15539875#comment-15539875 ] ASF subversion and git services commented on AIRFLOW-258: - Commit eb5982d4aac135051666d2977bbf6adfc8b9e2a7 in incubator-airflow's branch refs/heads/master from [~gwax] [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=eb5982d ] [AIRFLOW-333][AIRFLOW-258] Fix non-module plugin components * Distinguish between module and non-module plugin components * Fix handling of non-module plugin components * admin views, flask blueprints, and menu links need to not be wrapped in modules * Fix improper use of zope.deprecation.deprecated * zope.deprecation.deprecated does NOT support classes as first parameter * deprecating classes must be handled by calling the deprecate function on the class name * Added tests for plugin loading * Updated plugin documentation to match test plugin * Updated executors to always load plugins * More logging Closes #1738 from gwax/plugin_module_fixes > Always load plugin executors > > > Key: AIRFLOW-258 > URL: https://issues.apache.org/jira/browse/AIRFLOW-258 > Project: Apache Airflow > Issue Type: Improvement > Components: plugins >Reporter: Alexandr Nikitin >Assignee: George Leslie-Waksman > > At the moment we load plugin executors only when the specified `EXECUTOR` > field in config isn't from existing executors: 'LocalExecutor', > 'CeleryExecutor', 'SequentialExecutor', 'MesosExecutor'. > If the default executor belongs to existing executors we won't load plugins > executors at all. This breaks if the plugin executor used in SubDAG. > We should load plugin executors always. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AIRFLOW-258) Always load plugin executors
[ https://issues.apache.org/jira/browse/AIRFLOW-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517012#comment-15517012 ] George Leslie-Waksman commented on AIRFLOW-258: --- I ran into a fixed this as a part of trying to solve AIRFLOW-333 > Always load plugin executors > > > Key: AIRFLOW-258 > URL: https://issues.apache.org/jira/browse/AIRFLOW-258 > Project: Apache Airflow > Issue Type: Improvement > Components: plugins >Reporter: Alexandr Nikitin > > At the moment we load plugin executors only when the specified `EXECUTOR` > field in config isn't from existing executors: 'LocalExecutor', > 'CeleryExecutor', 'SequentialExecutor', 'MesosExecutor'. > If the default executor belongs to existing executors we won't load plugins > executors at all. This breaks if the plugin executor used in SubDAG. > We should load plugin executors always. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AIRFLOW-258) Always load plugin executors
[ https://issues.apache.org/jira/browse/AIRFLOW-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341003#comment-15341003 ] Chris Riccomini commented on AIRFLOW-258: - Makes sense to me. Want to send a PR? > Always load plugin executors > > > Key: AIRFLOW-258 > URL: https://issues.apache.org/jira/browse/AIRFLOW-258 > Project: Apache Airflow > Issue Type: Improvement > Components: plugins >Reporter: Alexandr Nikitin > > At the moment we load plugin executors only when the specified `EXECUTOR` > field in config isn't from existing executors: 'LocalExecutor', > 'CeleryExecutor', 'SequentialExecutor', 'MesosExecutor'. > If the default executor belongs to existing executors we won't load plugins > executors at all. This breaks if the plugin executor used in SubDAG. > We should load plugin executors always. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
