[jira] [Commented] (AIRFLOW-2839) Answer a question in doc: what if I have connections with the same conn_id in both metadata and environment variables?

2018-08-05 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569532#comment-16569532
 ] 

ASF GitHub Bot commented on AIRFLOW-2839:
-

kaxil closed pull request #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections
URL: https://github.com/apache/incubator-airflow/pull/3678
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/concepts.rst b/docs/concepts.rst
index f879ced012..09c1293806 100644
--- a/docs/concepts.rst
+++ b/docs/concepts.rst
@@ -333,6 +333,17 @@ from ``BaseHook``, Airflow will choose one connection 
randomly, allowing
 for some basic load balancing and fault tolerance when used in conjunction
 with retries.
 
+Airflow also has the ability to reference connections via environment
+variables from the operating system. But it only supports URI format. If you
+need to specify ``extra`` for your connection, please use web UI.
+
+If connections with the same ``conn_id`` are defined in both Airflow metadata
+database and environment variables, only the one in environment variables
+will be referenced by Airflow (for example, given ``conn_id`` 
``postgres_master``,
+Airflow will search for ``AIRFLOW_CONN_POSTGRES_MASTER``
+in environment variables first and directly reference it if found,
+before it starts to search in metadata database).
+
 Many hooks have a default ``conn_id``, where operators using that hook do not
 need to supply an explicit connection ID. For example, the default
 ``conn_id`` for the :class:`~airflow.hooks.postgres_hook.PostgresHook` is


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Answer a question in doc: what if I have connections with the same conn_id in 
> both metadata and environment variables?
> --
>
> Key: AIRFLOW-2839
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2839
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: configuration, Documentation
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
> Fix For: 2.0.0
>
>
> We can define connections either in metadata database or environment 
> variables.
>  
> However, how about there are connections with the same conn_id in both 
> metadata database and environment variables? Will one of them be picked? 
> Which one? Or a random one will be picked?
>  
> The answer is: Airflow will check environment variables 
> first.[https://github.com/apache/incubator-airflow/blob/master/airflow/hooks/base_hook.py#L70]
>   The "random picking" mechanism will only be applicable for multiple 
> connections with the same conn_id in metadata database (if there is no 
> connection with the same conn_id defined in environment variables).
>  
> This should be made clear in the documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AIRFLOW-2839) Answer a question in doc: what if I have connections with the same conn_id in both metadata and environment variables?

2018-08-05 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569533#comment-16569533
 ] 

ASF subversion and git services commented on AIRFLOW-2839:
--

Commit c0c63ae2a495b8f808c36acc35d752e916393954 in incubator-airflow's branch 
refs/heads/master from Xiaodong
[ https://gitbox.apache.org/repos/asf?p=incubator-airflow.git;h=c0c63ae ]

[AIRFLOW-2839] Refine Doc Concepts->Connections (#3678)



> Answer a question in doc: what if I have connections with the same conn_id in 
> both metadata and environment variables?
> --
>
> Key: AIRFLOW-2839
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2839
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: configuration, Documentation
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
> Fix For: 2.0.0
>
>
> We can define connections either in metadata database or environment 
> variables.
>  
> However, how about there are connections with the same conn_id in both 
> metadata database and environment variables? Will one of them be picked? 
> Which one? Or a random one will be picked?
>  
> The answer is: Airflow will check environment variables 
> first.[https://github.com/apache/incubator-airflow/blob/master/airflow/hooks/base_hook.py#L70]
>   The "random picking" mechanism will only be applicable for multiple 
> connections with the same conn_id in metadata database (if there is no 
> connection with the same conn_id defined in environment variables).
>  
> This should be made clear in the documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AIRFLOW-2839) Answer a question in doc: what if I have connections with the same conn_id in both metadata and environment variables?

2018-08-01 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566253#comment-16566253
 ] 

ASF GitHub Bot commented on AIRFLOW-2839:
-

XD-DENG opened a new pull request #3678: [AIRFLOW-2839] Refine Doc 
Concepts->Connections
URL: https://github.com/apache/incubator-airflow/pull/3678
 
 
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-2839
 - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   We can define connections either in metadata database or environment 
variables.

   However, how about there are connections with the same conn_id in both 
metadata database and environment variables? Will one of them be picked? Which 
one? Or a random one will be picked?

   The answer is: Airflow will check environment variables 
first.https://github.com/apache/incubator-airflow/blob/master/airflow/hooks/base_hook.py#L70
  The "random picking" mechanism will only be applicable for multiple 
connections with the same conn_id in metadata database (if there is no 
connection with the same conn_id defined in environment variables).

   This should be made clear in the documentation.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Answer a question in doc: what if I have connections with the same conn_id in 
> both metadata and environment variables?
> --
>
> Key: AIRFLOW-2839
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2839
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: configuration, Documentation
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> We can define connections either in metadata database or environment 
> variables.
>  
> However, how about there are connections with the same conn_id in both 
> metadata database and environment variables? Will one of them be picked? 
> Which one? Or a random one will be picked?
>  
> The answer is: Airflow will check environment variables 
> first.[https://github.com/apache/incubator-airflow/blob/master/airflow/hooks/base_hook.py#L70]
>   The "random picking" mechanism will only be applicable for multiple 
> connections with the same conn_id in metadata database (if there is no 
> connection with the same conn_id defined in environment variables).
>  
> This should be made clear in the documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)