[jira] [Commented] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569219#comment-16569219 ] ASF subversion and git services commented on AIRFLOW-2849: -- Commit 33dd33c89d4b6454d224ca34bab5ae37fb9812a6 in incubator-airflow's branch refs/heads/master from [~etrabelsi] [ https://gitbox.apache.org/repos/asf?p=incubator-airflow.git;h=33dd33c ] [AIRFLOW-2849] Add flake8 to setup.py Closes #3694 from eyaltrabelsi/AIRFLOW-2849-add-flake8-to-setup.py-dev-req-to-run-quality-check-locally > devel requirement is not sufficient to check code quality locally > - > > Key: AIRFLOW-2849 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2849 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Reporter: Eyal Trabelsi >Assignee: Eyal Trabelsi >Priority: Trivial > Fix For: 2.0.0 > > > The devel requirement doesn't list flake8, but in order to check code quality > locally one need to install it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569221#comment-16569221 ] ASF GitHub Bot commented on AIRFLOW-2849: - ashb closed pull request #3694: [AIRFLOW-2849] Add missing dependency flake8 to setup to allow running code quality checks locally URL: https://github.com/apache/incubator-airflow/pull/3694 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/setup.py b/setup.py index e69572c51d..d84c981ccb 100644 --- a/setup.py +++ b/setup.py @@ -246,7 +246,8 @@ def write_version(filename=os.path.join(*['airflow', 'pywinrm', 'qds-sdk>=1.9.6', 'rednose', -'requests_mock' +'requests_mock', +'flake8' ] if not PY3: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > devel requirement is not sufficient to check code quality locally > - > > Key: AIRFLOW-2849 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2849 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Reporter: Eyal Trabelsi >Assignee: Eyal Trabelsi >Priority: Trivial > Fix For: 2.0.0 > > > The devel requirement doesn't list flake8, but in order to check code quality > locally one need to install it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569218#comment-16569218 ] ASF subversion and git services commented on AIRFLOW-2849: -- Commit 33dd33c89d4b6454d224ca34bab5ae37fb9812a6 in incubator-airflow's branch refs/heads/master from [~etrabelsi] [ https://gitbox.apache.org/repos/asf?p=incubator-airflow.git;h=33dd33c ] [AIRFLOW-2849] Add flake8 to setup.py Closes #3694 from eyaltrabelsi/AIRFLOW-2849-add-flake8-to-setup.py-dev-req-to-run-quality-check-locally > devel requirement is not sufficient to check code quality locally > - > > Key: AIRFLOW-2849 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2849 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Reporter: Eyal Trabelsi >Assignee: Eyal Trabelsi >Priority: Trivial > Fix For: 2.0.0 > > > The devel requirement doesn't list flake8, but in order to check code quality > locally one need to install it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally
[
https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569192#comment-16569192
]
ASF GitHub Bot commented on AIRFLOW-2849:
-
eyaltrabelsi opened a new pull request #3694: [AIRFLOW-2849] Add missing
dependency flake8 to setup to allow running code quality checks locally
URL: https://github.com/apache/incubator-airflow/pull/3694
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Adding dependency.
### Commits
- [X ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [ X] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> devel requirement is not sufficient to check code quality locally
> -
>
> Key: AIRFLOW-2849
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2849
> Project: Apache Airflow
> Issue Type: Improvement
> Components: core
>Reporter: Eyal Trabelsi
>Assignee: Eyal Trabelsi
>Priority: Trivial
>
> The devel requirement doesn't list flake8, but in order to check code quality
> locally one need to install it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
