[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576596#comment-16576596
]
ASF subversion and git services commented on AIRFLOW-2878:
--
Commit f999ce22c16b11e8b9205d1bbb6af0683a0c7a3d in incubator-airflow's branch
refs/heads/master from [~TaoFeng]
[ https://gitbox.apache.org/repos/asf?p=incubator-airflow.git;h=f999ce2 ]
Revert "[AIRFLOW-2878] Fix www_rbac display issue" (#3737)
This reverts commit 1f57dafd70ac41da8295f20793f8913b7f5a5dff.
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576595#comment-16576595
]
ASF GitHub Bot commented on AIRFLOW-2878:
-
feng-tao closed pull request #3737: Revert "[AIRFLOW-2878] Fix www_rbac display
issue"
URL: https://github.com/apache/incubator-airflow/pull/3737
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/www_rbac/templates/appbuilder/baselayout.html
b/airflow/www_rbac/templates/appbuilder/baselayout.html
index b0728ca14b..1653a909d0 100644
--- a/airflow/www_rbac/templates/appbuilder/baselayout.html
+++ b/airflow/www_rbac/templates/appbuilder/baselayout.html
@@ -43,9 +43,6 @@
-
-
-
{% block messages %}
{% include 'appbuilder/flash.html' %}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576546#comment-16576546
]
ASF GitHub Bot commented on AIRFLOW-2878:
-
feng-tao opened a new pull request #3737: Revert "[AIRFLOW-2878] Fix www_rbac
display issue"
URL: https://github.com/apache/incubator-airflow/pull/3737
This reverts commit 1f57dafd70ac41da8295f20793f8913b7f5a5dff.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576536#comment-16576536
]
ASF GitHub Bot commented on AIRFLOW-2878:
-
XD-DENG opened a new pull request #3734: Revert "[AIRFLOW-2878] Fix www_rbac
display issue"
URL: https://github.com/apache/incubator-airflow/pull/3734
Hi @r39132 , this is to revert my earlier PR
https://github.com/apache/incubator-airflow/pull/3724.
As pointed out by @verdan , I encountered the issues that I tried to fix in
my earlier PR because I didn't build the frontend packages using `npm` and
`webpack`. That commit may also introduce extra spaces in each page.
Please refer to my conversation with Verdan in PR
https://github.com/apache/incubator-airflow/pull/3724.
Sorry for the inconvenience cause, and thanks @verdan for having pointed
this out.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576532#comment-16576532
]
ASF GitHub Bot commented on AIRFLOW-2878:
-
feng-tao closed pull request #3736: Revert "[AIRFLOW-2878] Fix www_rbac display
issue"
URL: https://github.com/apache/incubator-airflow/pull/3736
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576519#comment-16576519
]
ASF GitHub Bot commented on AIRFLOW-2878:
-
XD-DENG closed pull request #3734: Revert "[AIRFLOW-2878] Fix www_rbac display
issue"
URL: https://github.com/apache/incubator-airflow/pull/3734
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/www_rbac/templates/appbuilder/baselayout.html
b/airflow/www_rbac/templates/appbuilder/baselayout.html
index b0728ca14b..1653a909d0 100644
--- a/airflow/www_rbac/templates/appbuilder/baselayout.html
+++ b/airflow/www_rbac/templates/appbuilder/baselayout.html
@@ -43,9 +43,6 @@
-
-
-
{% block messages %}
{% include 'appbuilder/flash.html' %}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576518#comment-16576518
]
ASF GitHub Bot commented on AIRFLOW-2878:
-
feng-tao opened a new pull request #3736: Revert "[AIRFLOW-2878] Fix www_rbac
display issue"
URL: https://github.com/apache/incubator-airflow/pull/3736
Reverts apache/incubator-airflow#3724
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576514#comment-16576514
]
ASF GitHub Bot commented on AIRFLOW-2878:
-
feng-tao closed pull request #3735: Revert "[AIRFLOW-2878] Fix www_rbac display
issue"
URL: https://github.com/apache/incubator-airflow/pull/3735
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576512#comment-16576512
]
ASF GitHub Bot commented on AIRFLOW-2878:
-
feng-tao opened a new pull request #3735: Revert "[AIRFLOW-2878] Fix www_rbac
display issue"
URL: https://github.com/apache/incubator-airflow/pull/3735
Reverts apache/incubator-airflow#3724
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576369#comment-16576369
]
ASF GitHub Bot commented on AIRFLOW-2878:
-
XD-DENG opened a new pull request #3734: Revert "[AIRFLOW-2878] Fix www_rbac
display issue"
URL: https://github.com/apache/incubator-airflow/pull/3734
Hi @r39132 , this is to revert my earlier PR
https://github.com/apache/incubator-airflow/pull/3724.
As pointed out by @verdan , I encountered the issues that I tried to fix in
my earlier PR because I didn't build the frontend packages using `npm` and
`webpack`. That commit may also introduce extra spaces in each page.
Please refer to my conversation with Verdan in PR
https://github.com/apache/incubator-airflow/pull/3724.
Sorry for the inconvenience cause, and thanks @verdan for having pointed
this out.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575501#comment-16575501
]
ASF subversion and git services commented on AIRFLOW-2878:
--
Commit 1f57dafd70ac41da8295f20793f8913b7f5a5dff in incubator-airflow's branch
refs/heads/master from Xiaodong
[ https://gitbox.apache.org/repos/asf?p=incubator-airflow.git;h=1f57daf ]
[AIRFLOW-2878] Fix www_rbac display issue
The new RBAC UI has some issues about layout/UI display.
The header () is not shown ("hidden" by the Nav Bar),
or tables are not shown completely.
This is addressed by a simple change on
templates/appbuilder/baselayout.html
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2878) "/www_rbac" Layout/UI Display Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575499#comment-16575499
]
ASF GitHub Bot commented on AIRFLOW-2878:
-
r39132 closed pull request #3724: [AIRFLOW-2878] Fix www_rbac display issue
URL: https://github.com/apache/incubator-airflow/pull/3724
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/www_rbac/templates/appbuilder/baselayout.html
b/airflow/www_rbac/templates/appbuilder/baselayout.html
index 1653a909d0..b0728ca14b 100644
--- a/airflow/www_rbac/templates/appbuilder/baselayout.html
+++ b/airflow/www_rbac/templates/appbuilder/baselayout.html
@@ -43,6 +43,9 @@
+
+
+
{% block messages %}
{% include 'appbuilder/flash.html' %}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "/www_rbac" Layout/UI Display Issue
> ---
>
> Key: AIRFLOW-2878
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2878
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Reporter: Xiaodong DENG
>Assignee: Xiaodong DENG
>Priority: Critical
>
> The new RBAC UI has some issues about layout/UI display.
> The header () is not shown ("hidden" by the Nav Bar), or tables are not
> shown completely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
