[jira] [Commented] (AIRFLOW-3125) Add monitoring on Task Instance creation rate
[ https://issues.apache.org/jira/browse/AIRFLOW-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635100#comment-16635100 ] Iuliia Volkova commented on AIRFLOW-3125: - [~xiamingye], don't forget to close JIRA issue :) your PR already merged! [~ashb] > Add monitoring on Task Instance creation rate > - > > Key: AIRFLOW-3125 > URL: https://issues.apache.org/jira/browse/AIRFLOW-3125 > Project: Apache Airflow > Issue Type: Improvement >Reporter: Mingye Xia >Assignee: Mingye Xia >Priority: Major > > Monitoring on Task Instance creation rate can give us some visibility on how > much workload we are putting on Airflow. It can be used for resource > allocation in the long run (i.e. to determine when we should scale up > workers) and and debugging in scenarios like creation rate for certain types > of Task Instances spike. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-3125) Add monitoring on Task Instance creation rate
[
https://issues.apache.org/jira/browse/AIRFLOW-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632138#comment-16632138
]
ASF GitHub Bot commented on AIRFLOW-3125:
-
feng-tao closed pull request #3966: [AIRFLOW-3125] Monitor Task Instances
creation rates
URL: https://github.com/apache/incubator-airflow/pull/3966
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/models.py b/airflow/models.py
index e4a50bc476..9d1d64ee73 100755
--- a/airflow/models.py
+++ b/airflow/models.py
@@ -5282,6 +5282,9 @@ def verify_integrity(self, session=None):
continue
if task.task_id not in task_ids:
+Stats.incr(
+"task_instance_created-{}".format(task.__class__.__name__),
+1, 1)
ti = TaskInstance(task, self.execution_date)
session.add(ti)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add monitoring on Task Instance creation rate
> -
>
> Key: AIRFLOW-3125
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3125
> Project: Apache Airflow
> Issue Type: Improvement
>Reporter: Mingye Xia
>Assignee: Mingye Xia
>Priority: Major
>
> Monitoring on Task Instance creation rate can give us some visibility on how
> much workload we are putting on Airflow. It can be used for resource
> allocation in the long run (i.e. to determine when we should scale up
> workers) and and debugging in scenarios like creation rate for certain types
> of Task Instances spike.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-3125) Add monitoring on Task Instance creation rate
[
https://issues.apache.org/jira/browse/AIRFLOW-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631191#comment-16631191
]
ASF GitHub Bot commented on AIRFLOW-3125:
-
mingyexia opened a new pull request #3966: [AIRFLOW-3125] Monitor Task
Instances creation rates
URL: https://github.com/apache/incubator-airflow/pull/3966
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following
[AIRFLOW-3125](https://issues.apache.org/jira/browse/AIRFLOW-3125)
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Montor Task Instances creation rates by Operator type.
These stats can provide some visibility on how much workload Airflow is
getting. They can be used for resource allocation in the long run (i.e. to
determine when we should scale up workers) and debugging in scenarios like the
creation rate of certain type of Task Instances spikes.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Just adding stats.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add monitoring on Task Instance creation rate
> -
>
> Key: AIRFLOW-3125
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3125
> Project: Apache Airflow
> Issue Type: Improvement
>Reporter: Mingye Xia
>Assignee: Mingye Xia
>Priority: Major
>
> Monitoring on Task Instance creation rate can give us some visibility on how
> much workload we are putting on Airflow. It can be used for resource
> allocation in the long run (i.e. to determine when we should scale up
> workers) and and debugging in scenarios like creation rate for certain types
> of Task Instances spike.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
