Repository: ambari
Updated Branches:
refs/heads/trunk 8b820346c -> 786d4b633
AMBARI-22462 Remove hard-code from StackAdvisorCommand requests to another
resources (dgrinenko)
Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/786d4b63
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/786d4b63
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/786d4b63
Branch: refs/heads/trunk
Commit: 786d4b63349d2c0f18d8a06a29fe1cc5598cf8fc
Parents: 8b82034
Author: Dmytro Grinenko
Authored: Mon Nov 20 07:37:02 2017 +0200
Committer: Dmytro Grinenko
Committed: Mon Nov 20 07:37:02 2017 +0200
--
.../stackadvisor/commands/StackAdvisorCommand.java | 15 +++
.../ambari/server/controller/KerberosHelperImpl.java | 6 +++---
...erviceComponentConfigurationResourceProvider.java | 8
.../AbstractPrepareKerberosServerAction.java | 6 --
.../PrepareKerberosIdentitiesServerAction.java | 5 -
.../apache/ambari/server/topology/AmbariContext.java | 3 ++-
.../ambari/server/topology/BlueprintFactory.java | 3 ++-
.../validators/RequiredPasswordValidator.java| 3 ++-
8 files changed, 32 insertions(+), 17 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/ambari/blob/786d4b63/ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
--
diff --git
a/ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
b/ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
index 17591ec..1b89c4f 100644
---
a/ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
+++
b/ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
@@ -47,6 +47,7 @@ import
org.apache.ambari.server.api.services.stackadvisor.StackAdvisorResponse;
import org.apache.ambari.server.api.services.stackadvisor.StackAdvisorRunner;
import org.apache.ambari.server.controller.RootComponent;
import org.apache.ambari.server.controller.RootService;
+import
org.apache.ambari.server.controller.internal.RootServiceComponentConfigurationResourceProvider;
import org.apache.ambari.server.controller.spi.Resource;
import org.apache.ambari.server.state.ServiceInfo;
import org.apache.ambari.server.utils.DateUtils;
@@ -77,6 +78,8 @@ public abstract class StackAdvisorCommand extend
private static final String GET_HOSTS_INFO_URI = "/api/v1/hosts"
+ "?fields=Hosts/*/host_name.in(%s)";
+ static final String LDAP_CONFIGURATION_PROPERTY = "ldap-configuration";
+
private static final String GET_SERVICES_INFO_URI =
"/api/v1/stacks/%s/versions/%s/"
+
"?fields=Versions/stack_name,Versions/stack_version,Versions/parent_stack_version"
+
",services/StackServices/service_name,services/StackServices/service_version"
@@ -86,9 +89,14 @@ public abstract class StackAdvisorCommand extend
+
",services/configurations/dependencies/StackConfigurationDependency/dependency_name"
+
",services/configurations/dependencies/StackConfigurationDependency/dependency_type,services/configurations/StackConfigurations/type"
+ "/StackServices/service_name.in(%s)";
- private static final String GET_AMBARI_LDAP_CONFIG_URI =
"/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations" +
- "?Configuration/category=ldap-configuration" +
- "=Configuration/properties";
+
+ private static final String GET_AMBARI_LDAP_CONFIG_URI =
String.format("/api/v1/services/%s/components/%s/configurations?%s=%s=%s",
+RootService.AMBARI.name(),
+RootComponent.AMBARI_SERVER.name(),
+
RootServiceComponentConfigurationResourceProvider.CONFIGURATION_CATEGORY_PROPERTY_ID,
+LDAP_CONFIGURATION_PROPERTY,
+
RootServiceComponentConfigurationResourceProvider.CONFIGURATION_PROPERTIES_PROPERTY_ID);
+
private static final String SERVICES_PROPERTY = "services";
private static final String SERVICES_COMPONENTS_PROPERTY = "components";
private static final String CONFIG_GROUPS_PROPERTY = "config-groups";
@@ -100,7 +108,6 @@ public abstract class StackAdvisorCommand extend
private static final String CHANGED_CONFIGURATIONS_PROPERTY =
"changed-configurations";
private static final String USER_CONTEXT_PROPERTY = "user-context";
private static final String AMBARI_SERVER_CONFIGURATIONS_PROPERTY =
"ambari-server-properties";
- static final String LDAP_CONFIGURATION_PROPERTY = "ldap-configuration";
private File recommendationsDir;
private String