[GitHub] kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra Manager: REST api cleanup
kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra
Manager: REST api cleanup
URL: https://github.com/apache/ambari-infra/pull/20#discussion_r238059613
##
File path: ambari-infra-manager-it/pom.xml
##
@@ -182,6 +211,53 @@
src/test/resources
+
+
+io.swagger
+swagger-codegen-maven-plugin
+2.3.1
+
+
+
+ generate
+
+
+
${project.parent.basedir}/ambari-infra-manager/src/main/resources/swagger/swagger.yaml
+ java
+ false
+ false
+ ${generated-sources-path}
+
+${generated-sources-java-path}
+org.apache.ambari.infra.client.api
+
org.apache.ambari.infra.client.model
+
org.apache.ambari.infra.client.invoker
+java8
Review comment:
I've just run the integration tests with java11 and it works after adding
`javax.annotation:javax.annotation-api` and `javax.xml.bind:jaxb-api`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra Manager: REST api cleanup
kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra
Manager: REST api cleanup
URL: https://github.com/apache/ambari-infra/pull/20#discussion_r238056617
##
File path: ambari-infra-manager-it/pom.xml
##
@@ -36,6 +36,9 @@
2.20
localhost
NONE
+2.7.5
+main/java
+
${project.build.directory}/generated-sources
Review comment:
I renamed these properties.
I googled a bit about maven naming conventions and found that camel case is
used for multiword property names and `.` "refers to the pom structure where
the variable is located".
```${project.build.outputDirectory}```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra Manager: REST api cleanup
kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra
Manager: REST api cleanup
URL: https://github.com/apache/ambari-infra/pull/20#discussion_r238056502
##
File path: ambari-infra-manager/pom.xml
##
@@ -117,6 +118,49 @@
+
+com.github.kongchen
+swagger-maven-plugin
+${swagger-maven-plugin-version}
+
+
+
+ false
+ org.apache.ambari.infra.rest
+
+http
+https
+
+ /api/v1
+
+Infra Manager REST API
+1.0.0
+Ambari Infra Manager REST APIs has inherent
support for querying, sorting and pagination
+
+ http://www.apache.org/licenses/LICENSE-2.0
+ Apache License, Version 2.0
+
+
+ yaml,json
+ src/main/resources/swagger
Review comment:
That was the trick, thanks @adoroszlai
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra Manager: REST api cleanup
kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra
Manager: REST api cleanup
URL: https://github.com/apache/ambari-infra/pull/20#discussion_r238056495
##
File path:
ambari-infra-manager/src/test/java/org/apache/ambari/infra/model/ISO8601DateFormatterTest.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.ambari.infra.model;
+
+import static org.hamcrest.core.Is.is;
+import static org.junit.Assert.assertThat;
+
+import java.text.ParseException;
+import java.time.OffsetDateTime;
+import java.time.ZoneOffset;
+import java.util.Date;
+
+import org.junit.Test;
+
+public class ISO8601DateFormatterTest {
+
+ @Test
+ public void testParsingTheFormattedDateIsEqualsWithTheInitialDate() throws
ParseException {
Review comment:
Renamed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra Manager: REST api cleanup
kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra Manager: REST api cleanup URL: https://github.com/apache/ambari-infra/pull/20#discussion_r238056488 ## File path: ambari-infra-manager-it/pom.xml ## @@ -182,6 +211,53 @@ src/test/resources + + +io.swagger Review comment: The generation can be skipped by adding the `codegen.skip` property to the command line but I would not recommend that if the build was cleaned because generated code is referenced by integration tests code and compile would fail. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra Manager: REST api cleanup
kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra
Manager: REST api cleanup
URL: https://github.com/apache/ambari-infra/pull/20#discussion_r238056450
##
File path: ambari-infra-manager-it/pom.xml
##
@@ -182,6 +211,53 @@
src/test/resources
+
+
+io.swagger
+swagger-codegen-maven-plugin
+2.3.1
+
+
+
+ generate
+
+
+
${project.parent.basedir}/ambari-infra-manager/src/main/resources/swagger/swagger.yaml
+ java
+ false
+ false
+ ${generated-sources-path}
+
+${generated-sources-java-path}
+org.apache.ambari.infra.client.api
+
org.apache.ambari.infra.client.model
+
org.apache.ambari.infra.client.invoker
+java8
Review comment:
I think this affects only that the generated source is going to use java
`java.time`.
I am going to prepare and test Infra manager for java11 in another PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra Manager: REST api cleanup
kasakrisz commented on a change in pull request #20: AMBARI-24969 - Infra
Manager: REST api cleanup
URL: https://github.com/apache/ambari-infra/pull/20#discussion_r238056410
##
File path: ambari-infra-manager-it/pom.xml
##
@@ -36,6 +36,9 @@
2.20
localhost
NONE
+2.7.5
+main/java
Review comment:
this property value is a relative path it is used with
```${project.build.directory}/generated-sources```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
