[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449742 --- Diff: aria/modeling/utils.py --- @@ -52,84 +53,95 @@ def service_template(self): return self.container.service_template

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449679 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/functions.py --- @@ -69,7 +69,7 @@ def __evaluate__(self, container_holder):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449695 --- Diff: aria/orchestrator/workflows/events_logging.py --- @@ -35,20 +35,20 @@ def _get_task_name(task):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119449568 --- Diff: aria/modeling/exceptions.py --- @@ -57,3 +57,9 @@ class UndeclaredParametersException(ParameterException): """ ARIA

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119446847 --- Diff: tests/orchestrator/test_workflow_runner.py --- @@ -259,8 +258,9 @@ def _setup_mock_workflow_in_service(request, inputs=None):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119446252 --- Diff: aria/modeling/exceptions.py --- @@ -57,3 +57,9 @@ class UndeclaredParametersException(ParameterException): """ ARIA

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119446194 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/functions.py --- @@ -69,7 +69,7 @@ def __evaluate__(self, container_holder):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445955 --- Diff: aria/orchestrator/workflow_runner.py --- @@ -136,10 +137,11 @@ def _validate_no_active_executions(self, execution):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445875 --- Diff: aria/orchestrator/execution_plugin/instantiation.py --- @@ -16,107 +16,132 @@ # TODO: this module will eventually be moved to a

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119444625 --- Diff: tests/resources/service-templates/tosca-simple-1.0/node-cellar/node-cellar.yaml --- @@ -309,7 +311,7 @@ policy_types:

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119443130 --- Diff: aria/modeling/exceptions.py --- @@ -57,3 +57,9 @@ class UndeclaredParametersException(ParameterException): """ ARIA

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119427199 --- Diff: aria/orchestrator/workflow_runner.py --- @@ -136,10 +137,11 @@ def _validate_no_active_executions(self, execution):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119428842 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/functions.py --- @@ -69,7 +69,7 @@ def __evaluate__(self, container_holder):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119428083 --- Diff: aria/orchestrator/workflows/events_logging.py --- @@ -35,20 +35,20 @@ def _get_task_name(task):

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119443917 --- Diff: aria/orchestrator/execution_plugin/instantiation.py --- @@ -16,107 +16,132 @@ # TODO: this module will eventually be moved to a new

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-26 Thread tliron
Github user tliron closed the pull request at: https://github.com/apache/incubator-ariatosca/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-26 Thread tliron
GitHub user tliron reopened a pull request: https://github.com/apache/incubator-ariatosca/pull/138 ARIA-149 Enhance operation configuration * Parse special "dependencies" configuration parameters as YAML and treat as Parameter models, allowing them full use of intrinsic

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r118375237 --- Diff: aria/orchestrator/execution_plugin/instantiation.py --- @@ -16,107 +16,132 @@ # TODO: this module will eventually be moved to a

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r118375175 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/__init__.py --- @@ -384,18 +387,37 @@ def

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r118374966 --- Diff: aria/modeling/exceptions.py --- @@ -22,9 +22,9 @@ class ModelingException(AriaException): """ -class

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-24 Thread ran-z
Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r118293230 --- Diff: aria/modeling/service_instance.py --- @@ -1728,34 +1732,41 @@ def operation_template(cls): def inputs(cls): return