[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130399573 --- Diff: aria/storage/collection_instrumentation.py --- @@ -213,32 +235,32 @@ def __init__(self, mapi, *args, **kwargs

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-08-15 Thread tliron
GitHub user tliron opened a pull request: https://github.com/apache/incubator-ariatosca/pull/191 ARIA-321 Provide Clearwater IMS example Related fixes included in this commit: * Allows capabilities, interfaces, and properties to override parent definition types only

[GitHub] incubator-ariatosca pull request #183: ARIA-76 Parallelize PyTest

2017-07-12 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/183#discussion_r126884450 --- Diff: .travis.yml --- @@ -23,11 +23,12 @@ env: - TOX_ENV=py26e2e - TOX_ENV=py27ssh - TOX_ENV=py26ssh +- TOX_ENV=docs

[GitHub] incubator-ariatosca pull request #183: ARIA-76 Parallelize PyTest

2017-07-12 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/183#discussion_r126884207 --- Diff: .travis.yml --- @@ -23,11 +23,12 @@ env: - TOX_ENV=py26e2e - TOX_ENV=py27ssh - TOX_ENV=py26ssh +- TOX_ENV=docs

[GitHub] incubator-ariatosca pull request #184: ARIA-307 Automate release process

2017-07-11 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/184#discussion_r126630635 --- Diff: release.sh --- @@ -0,0 +1,235 @@ +#!/bin/bash --- End diff -- I think it would help readers to have a short comment

[GitHub] incubator-ariatosca pull request #184: ARIA-307 Automate release process

2017-07-11 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/184#discussion_r126629909 --- Diff: release.sh --- @@ -0,0 +1,235 @@ +#!/bin/bash --- End diff -- Missing Apache license header --- If your project

[GitHub] incubator-ariatosca pull request #183: ARIA-76 Parallelize PyTest

2017-07-11 Thread tliron
GitHub user tliron reopened a pull request: https://github.com/apache/incubator-ariatosca/pull/183 ARIA-76 Parallelize PyTest Use the PyTest xdist plugin to parallelize tests in boxed subprocesses. Through benchmarking we discovered that paralellizing on the number of CPU

[GitHub] incubator-ariatosca pull request #183: ARIA-76 Parallelize PyTest

2017-07-11 Thread tliron
Github user tliron closed the pull request at: https://github.com/apache/incubator-ariatosca/pull/183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...

2017-07-10 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/143#discussion_r126353859 --- Diff: aria/modeling/service_template.py --- @@ -690,19 +666,104 @@ def dump(self): console.puts(context.style.meta

[GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...

2017-07-10 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/143#discussion_r126353998 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/capabilities.py --- @@ -162,6 +164,30 @@ def

[GitHub] incubator-ariatosca pull request #183: ARIA-76 Parallelize PyTest

2017-07-10 Thread tliron
GitHub user tliron opened a pull request: https://github.com/apache/incubator-ariatosca/pull/183 ARIA-76 Parallelize PyTest Use the PyTest xdist plugin to parallelize tests in boxed subprocesses. Through benchmarking we discovered that paralellizing on the number of CPU

[GitHub] incubator-ariatosca pull request #181: ARIA-103 Remove dependency on Clint

2017-07-10 Thread tliron
GitHub user tliron opened a pull request: https://github.com/apache/incubator-ariatosca/pull/181 ARIA-103 Remove dependency on Clint We no longer require this third-party library, instead the utils/console module uses the existing cli/color module. This commit also

[GitHub] incubator-ariatosca pull request #168: ARIA-286 Sphinx documentation for cod...

2017-06-28 Thread tliron
GitHub user tliron opened a pull request: https://github.com/apache/incubator-ariatosca/pull/168 ARIA-286 Sphinx documentation for code and CLI You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-ariatosca ARIA-286

[GitHub] incubator-ariatosca pull request #145: ARIA-260 Send interface inputs as arg...

2017-07-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/145#discussion_r125752870 --- Diff: tests/instantiation/test_configuration.py --- @@ -0,0 +1,175 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #145: ARIA-260 Send interface inputs as arg...

2017-07-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/145#discussion_r125753009 --- Diff: tests/instantiation/test_configuration.py --- @@ -0,0 +1,175 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...

2017-07-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/143#discussion_r125753620 --- Diff: extensions/aria_extension_tosca/profiles/tosca-simple-1.0/capabilities.yaml --- @@ -132,6 +132,7 @@ capability_types

[GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...

2017-07-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/143#discussion_r125754130 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/capabilities.py --- @@ -162,6 +164,30 @@ def

[GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...

2017-07-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/143#discussion_r125754664 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/capabilities.py --- @@ -162,6 +164,30 @@ def

[GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...

2017-07-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/143#discussion_r125755316 --- Diff: aria/modeling/service_template.py --- @@ -690,19 +666,104 @@ def dump(self): console.puts(context.style.meta

[GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...

2017-07-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/143#discussion_r125755887 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/capabilities.py --- @@ -162,6 +164,30 @@ def

[GitHub] incubator-ariatosca pull request #143: ARIA-254 Create multiple nodes per te...

2017-07-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/143#discussion_r125756533 --- Diff: aria/modeling/service_template.py --- @@ -690,19 +666,104 @@ def dump(self): console.puts(context.style.meta

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247255 --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py --- @@ -150,43 +150,101 @@ def __exit__(self, *args, **kwargs

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247244 --- Diff: aria/storage/collection_instrumentation.py --- @@ -213,32 +235,32 @@ def __init__(self, mapi, *args, **kwargs

[GitHub] incubator-ariatosca issue #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on the issue: https://github.com/apache/incubator-ariatosca/pull/188 Hey guys, I suggest going over the complex use cases in the [Clearwater example](https://github.com/apache/incubator-ariatosca/blob/ARIA-321-clearwater/examples/clearwater/scripts/host

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247176 --- Diff: aria/orchestrator/workflows/api/task.py --- @@ -140,13 +140,18 @@ def __init__(self, self.arguments

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247158 --- Diff: aria/orchestrator/workflows/api/task.py --- @@ -140,13 +140,18 @@ def __init__(self, self.arguments

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247470 --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py --- @@ -150,43 +150,101 @@ def __exit__(self, *args, **kwargs

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247602 --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py --- @@ -150,43 +150,101 @@ def __exit__(self, *args, **kwargs

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247616 --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py --- @@ -150,43 +150,101 @@ def __exit__(self, *args, **kwargs

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247609 --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py --- @@ -150,43 +150,101 @@ def __exit__(self, *args, **kwargs

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247107 --- Diff: aria/orchestrator/context/common.py --- @@ -38,10 +38,27 @@ class BaseContext(object

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-07-30 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r130247513 --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py --- @@ -150,43 +150,101 @@ def __exit__(self, *args, **kwargs

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx access

2017-07-27 Thread tliron
GitHub user tliron opened a pull request: https://github.com/apache/incubator-ariatosca/pull/188 ARIA-324 Refactor ctx access Our previous use of "." to delimit nested dict keys was wrong (keys could have a ".") and inflexible. The new implementation uses

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-08-07 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r131700894 --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py --- @@ -150,17 +146,29 @@ def __exit__(self, *args, **kwargs

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-08-07 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r131700830 --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py --- @@ -170,101 +178,59 @@ def _process_ctx_request(ctx, args): # pylint

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-08-07 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r131702731 --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py --- @@ -170,101 +178,59 @@ def _process_ctx_request(ctx, args): # pylint

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-08-07 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r131693627 --- Diff: tests/orchestrator/execution_plugin/test_ctx_proxy_server.py --- @@ -55,61 +55,32 @@ def test_dict_prop_access_set(self, server, ctx

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-08-07 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r131693585 --- Diff: examples/hello-world/scripts/stop.sh --- @@ -16,14 +16,13 @@ set -e -TEMP_DIR="/tmp" -PYTHON_FILE_S

[GitHub] incubator-ariatosca pull request #188: ARIA-324 Refactor ctx proxy access

2017-08-07 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/188#discussion_r131703163 --- Diff: aria/orchestrator/execution_plugin/ctx_proxy/server.py --- @@ -170,101 +178,59 @@ def _process_ctx_request(ctx, args): # pylint

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-26 Thread tliron
Github user tliron closed the pull request at: https://github.com/apache/incubator-ariatosca/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-26 Thread tliron
GitHub user tliron reopened a pull request: https://github.com/apache/incubator-ariatosca/pull/138 ARIA-149 Enhance operation configuration * Parse special "dependencies" configuration parameters as YAML and treat as Parameter models, allowing them full use of

[GitHub] incubator-ariatosca pull request #144: ARIA-64 Remove PyYAML dependency

2017-06-02 Thread tliron
GitHub user tliron opened a pull request: https://github.com/apache/incubator-ariatosca/pull/144 ARIA-64 Remove PyYAML dependency You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-ariatosca ARIA-64-remove-pyyaml

[GitHub] incubator-ariatosca pull request #145: ARIA-260 Send interface inputs as arg...

2017-06-02 Thread tliron
GitHub user tliron opened a pull request: https://github.com/apache/incubator-ariatosca/pull/145 ARIA-260 Send interface inputs as arguments You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-ariatosca ARIA-260

[GitHub] incubator-ariatosca pull request #146: ARIA-199 Add "services outputs" CLI c...

2017-06-02 Thread tliron
GitHub user tliron opened a pull request: https://github.com/apache/incubator-ariatosca/pull/146 ARIA-199 Add "services outputs" CLI command You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-ariatosca

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445875 --- Diff: aria/orchestrator/execution_plugin/instantiation.py --- @@ -16,107 +16,132 @@ # TODO: this module will eventually be moved

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119445955 --- Diff: aria/orchestrator/workflow_runner.py --- @@ -136,10 +137,11 @@ def _validate_no_active_executions(self, execution

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119446252 --- Diff: aria/modeling/exceptions.py --- @@ -57,3 +57,9 @@ class UndeclaredParametersException(ParameterException): """

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119446194 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/functions.py --- @@ -69,7 +69,7 @@ def __evaluate__(self, container_holder

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-31 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r119446847 --- Diff: tests/orchestrator/test_workflow_runner.py --- @@ -259,8 +258,9 @@ def _setup_mock_workflow_in_service(request, inputs=None

[GitHub] incubator-ariatosca pull request #143: ARIA-254 Create of multiple nodes per...

2017-06-01 Thread tliron
GitHub user tliron opened a pull request: https://github.com/apache/incubator-ariatosca/pull/143 ARIA-254 Create of multiple nodes per template * New aria.Scaling policy (and "scaling" role) * NodeTemplate model no longer stores scaling values (default_instance

[GitHub] incubator-ariatosca pull request #146: ARIA-199 Add "services outputs" CLI c...

2017-06-06 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/146#discussion_r120391233 --- Diff: tests/resources/service-templates/tosca-simple-1.0/node-cellar/node-cellar.yaml --- @@ -302,6 +306,14 @@ topology_template

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r118375175 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/__init__.py --- @@ -384,18 +387,37 @@ def create_operation_template_model(context

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r118374966 --- Diff: aria/modeling/exceptions.py --- @@ -22,9 +22,9 @@ class ModelingException(AriaException): """

[GitHub] incubator-ariatosca pull request #138: ARIA-149 Enhance operation configurat...

2017-05-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/138#discussion_r118375237 --- Diff: aria/orchestrator/execution_plugin/instantiation.py --- @@ -16,107 +16,132 @@ # TODO: this module will eventually be moved

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-09-11 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r138103044 --- Diff: .travis.yml --- @@ -10,36 +10,55 @@ # See the License for the specific language governing permissions and # limitations under

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-09-11 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r138102421 --- Diff: .travis.yml --- @@ -10,36 +10,55 @@ # See the License for the specific language governing permissions and # limitations under

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-09-06 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r137270329 --- Diff: examples/clearwater/scripts/bono/delete.sh --- @@ -0,0 +1,15 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-09-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r137047729 --- Diff: examples/clearwater/clearwater-live-test-existing.yaml --- @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-09-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r137048061 --- Diff: examples/clearwater/clearwater-single-existing.yaml --- @@ -0,0 +1,147 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-09-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r137049267 --- Diff: examples/clearwater/scripts/ralf/create.sh --- @@ -0,0 +1,15 @@ +#!/bin/bash --- End diff -- In terms of software

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-09-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r137052935 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/data_types.py --- @@ -159,10 +159,6 @@ def get_data_type(context, presentation

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-09-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r137048035 --- Diff: examples/clearwater/clearwater-live-test-existing.yaml --- @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-09-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r137048198 --- Diff: examples/clearwater/scripts/bono/delete.sh --- @@ -0,0 +1,15 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-ariatosca pull request #191: ARIA-321 Provide Clearwater IMS examp...

2017-09-05 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/191#discussion_r137070505 --- Diff: aria/modeling/service_instance.py --- @@ -228,6 +228,80 @@ def service_template_fk(cls): :type: :class:`~datetime.datetime

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-27 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153344804 --- Diff: aria/parser/loading/uri.py --- @@ -44,6 +45,7 @@ def __init__(self, context, location, origin_location=None

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153008578 --- Diff: aria/parser/consumption/presentation.py --- @@ -86,52 +73,193 @@ def dump(self): self.context.presentation.presenter

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153009232 --- Diff: aria/parser/presentation/field_validators.py --- @@ -14,12 +14,29 @@ # limitations under the License. +from

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153012524 --- Diff: tests/extensions/aria_extension_tosca/simple_v1_0/functions/test_function_concat.py --- @@ -0,0 +1,102 @@ +# -*- coding: utf

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153013913 --- Diff: aria/parser/loading/loader.py --- @@ -32,3 +32,6 @@ def close(self): def load(self): raise

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153016106 --- Diff: aria/modeling/service_common.py --- @@ -587,12 +588,11 @@ class MetadataBase(TemplateModelMixin): :ivar name: name

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-27 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153343290 --- Diff: aria/utils/threading.py --- @@ -161,11 +242,7 @@ def close(self): self._workers = None def drain(self

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-27 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153343795 --- Diff: aria/parser/reading/reader.py --- @@ -28,16 +28,9 @@ def __init__(self, context, location, loader): def load(self

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153007941 --- Diff: aria/parser/consumption/presentation.py --- @@ -86,52 +73,193 @@ def dump(self): self.context.presentation.presenter

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153008582 --- Diff: aria/parser/consumption/presentation.py --- @@ -86,52 +73,193 @@ def dump(self): self.context.presentation.presenter

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153008552 --- Diff: aria/parser/consumption/presentation.py --- @@ -86,52 +73,193 @@ def dump(self): self.context.presentation.presenter

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153009028 --- Diff: aria/parser/presentation/context.py --- @@ -63,3 +67,12 @@ def get_from_dict(self, *names): """

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153011505 --- Diff: extensions/aria_extension_tosca/simple_v1_0/modeling/data_types.py --- @@ -318,15 +318,15 @@ def report(message, constraint

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153012904 --- Diff: tests/mechanisms/parsing/__init__.py --- @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153013856 --- Diff: aria/parser/consumption/presentation.py --- @@ -86,52 +73,193 @@ def dump(self): self.context.presentation.presenter

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153014247 --- Diff: aria/parser/presentation/presentation.py --- @@ -199,6 +199,9 @@ class Presentation(PresentationBase): """

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153008880 --- Diff: aria/parser/consumption/presentation.py --- @@ -86,52 +73,193 @@ def dump(self): self.context.presentation.presenter

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153009548 --- Diff: aria/parser/reading/yaml.py --- @@ -16,18 +16,30 @@ from .reader import Reader from .locator import Locator from

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153013051 --- Diff: tests/mechanisms/utils.py --- @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153013058 --- Diff: tests/mechanisms/utils.py --- @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153013725 --- Diff: aria/parser/consumption/presentation.py --- @@ -31,47 +32,33 @@ class Read(Consumer): instances. It supports

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153014418 --- Diff: aria/parser/reading/reader.py --- @@ -28,16 +28,9 @@ def __init__(self, context, location, loader): def load(self

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153014666 --- Diff: aria/utils/threading.py --- @@ -161,11 +242,7 @@ def close(self): self._workers = None def drain(self

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153014611 --- Diff: aria/parser/reading/yaml.py --- @@ -82,7 +84,11 @@ def read(self): # see issue here: # https

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153006807 --- Diff: aria/parser/consumption/presentation.py --- @@ -31,47 +32,33 @@ class Read(Consumer): instances. It supports

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153008314 --- Diff: aria/parser/consumption/presentation.py --- @@ -86,52 +73,193 @@ def dump(self): self.context.presentation.presenter

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153010864 --- Diff: aria/utils/collections.py --- @@ -220,27 +225,30 @@ def __setitem__(self, key, value, **_): return super(StrictDict, self

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153011903 --- Diff: tests/extensions/aria_extension_tosca/conftest.py --- @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-24 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153013980 --- Diff: aria/parser/loading/uri.py --- @@ -44,6 +45,7 @@ def __init__(self, context, location, origin_location=None

[GitHub] incubator-ariatosca issue #200: ARIA-393 Enable configuration of extension l...

2017-11-02 Thread tliron
Github user tliron commented on the issue: https://github.com/apache/incubator-ariatosca/pull/200 Could you just fix the Sphinx docstring to include the argument? ---

[GitHub] incubator-ariatosca pull request #199: ARIA-392 Failing to load ruamel.yaml

2017-11-02 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/199#discussion_r148620801 --- Diff: aria/__init__.py --- @@ -17,14 +17,45 @@ The ARIA root package provides entry points for extension and storage initialization

[GitHub] incubator-ariatosca pull request #199: ARIA-392 Failing to load ruamel.yaml

2017-11-02 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/199#discussion_r148621970 --- Diff: aria/__init__.py --- @@ -17,14 +17,45 @@ The ARIA root package provides entry points for extension and storage initialization

[GitHub] incubator-ariatosca pull request #199: ARIA-392 Failing to load ruamel.yaml

2017-11-02 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/199#discussion_r148628206 --- Diff: aria/__init__.py --- @@ -17,14 +17,45 @@ The ARIA root package provides entry points for extension and storage initialization

[GitHub] incubator-ariatosca issue #199: ARIA-392 Failing to load ruamel.yaml

2017-11-09 Thread tliron
Github user tliron commented on the issue: https://github.com/apache/incubator-ariatosca/pull/199 OK. So I guess you don't want to change the imports in `/tests/`? On Wed, Nov 8, 2017 at 4:32 PM, Maxim Orlov <notificati...@github.com> wrote: > so, i th

[GitHub] incubator-ariatosca issue #199: ARIA-392 Failing to load ruamel.yaml

2017-11-08 Thread tliron
Github user tliron commented on the issue: https://github.com/apache/incubator-ariatosca/pull/199 @mxmrlv You didn't address these: 1. Let's move this to `from aria.utils.yaml import yaml`. I don't think the aria `__init__.py` is the right place for this. 2. Let's go over

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-08 Thread tliron
Github user tliron commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r149718206 --- Diff: tests/extensions/aria_extension_tosca/simple_nfv_v1_0/test_profile.py --- @@ -0,0 +1,20 @@ +# Licensed to the Apache Software

  1   2   >