[GitHub] [arrow-site] kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags
kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags URL: https://github.com/apache/arrow-site/pull/23#discussion_r326026839 ## File path: README.md ## @@ -68,6 +68,10 @@ Run the following to generate HTML files and run the web site locally. bundle exec jekyll serve ``` +## Deployment + +On commits to the `master` branch of `apache/arrow-site`, the rendered static site will be published to the `asf-site` branch using GitHub Actions. On a fork, it will deploy to your `gh-pages` branch for deployment via GitHub Pages; this is useful for previewing changes you're proposing. To enable this deployment on your fork, you'll need to sign up for GitHub Actions [here](https://github.com/features/actions/signup). Review comment: OK. I've changed behavior on "push to master": * apache/arrow-site: push to asf-site on apache/arrow-site * forked repositories: push to gh-pages on forked repository This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [arrow-site] kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags
kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags URL: https://github.com/apache/arrow-site/pull/23#discussion_r325958591 ## File path: README.md ## @@ -68,6 +68,10 @@ Run the following to generate HTML files and run the web site locally. bundle exec jekyll serve ``` +## Deployment + +On commits to the `master` branch of `apache/arrow-site`, the rendered static site will be published to the `asf-site` branch using GitHub Actions. On a fork, it will deploy to your `gh-pages` branch for deployment via GitHub Pages; this is useful for previewing changes you're proposing. To enable this deployment on your fork, you'll need to sign up for GitHub Actions [here](https://github.com/features/actions/signup). Review comment: The current GitHub Actions configuration does the followings: * push to master: always push to `asf-site` (`apache/arrow-site` or forked repository isn't related) * create a pull request: always push to `gh-pages` of forked repository (*) (*) But this isn't work for pull request on apache/arrow-site for now. This works for pull request on forked repository if we enable GitHub Actions on forked repository. e.g. https://github.com/kou/arrow-site/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [arrow-site] kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags
kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags URL: https://github.com/apache/arrow-site/pull/23#discussion_r325475092 ## File path: .gitignore ## @@ -8,3 +8,4 @@ build/ .bundle/ ruby/ .DS_Store +themes/ Review comment: I can accept this change in this pull request but we should not put a change that isn't related to the target topic branch in general. :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [arrow-site] kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags
kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags URL: https://github.com/apache/arrow-site/pull/23#discussion_r324439945 ## File path: .gitignore ## @@ -8,3 +8,4 @@ build/ .bundle/ ruby/ .DS_Store +themes/ Review comment: Is this needed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [arrow-site] kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags
kou commented on a change in pull request #23: ARROW-6127: [Website] Add
favicons and meta tags
URL: https://github.com/apache/arrow-site/pull/23#discussion_r324440167
##
File path: build-and-deploy.sh
##
@@ -28,7 +28,13 @@ if [ "${TRAVIS_BRANCH}" = "master" ] && [
"${TRAVIS_PULL_REQUEST}" = "false" ];
# because we can infer it based on GitHub Pages conventions
if [ "${BASE_URL}" = "" ]; then
BASE_URL=$(echo $TRAVIS_REPO_SLUG | sed -e 's@.*/@/@')
+FULL_URL="https://"$(echo $TRAVIS_REPO_SLUG | sed
's@/.*@.github.io@')
+else
+# Everything is shoved into BASE_URL so this can be empty
+FULL_URL=
fi
+# FULL_URL is for the opengraph tags, which can't be relative
+perl -pe 's@^url:.*@url: '"${FULL_URL}"'@' -i _config.yml
Review comment:
How about using override config file instead of rewrite the original config
file?
```shell
custom_config_yml="_config.override.yml"
touch ${custom_config_yml}
if [ "${TRAVIS_REPO_SLUG}" = "apache/arrow-site" ]; then
# Production
TARGET_BRANCH=asf-site
BASE_URL=
else
# On a fork, so we'll deploy to GitHub Pages
TARGET_BRANCH=gh-pages
# You could supply an alternate BASE_URL, but that's not necessary
# because we can infer it based on GitHub Pages conventions
if [ "${BASE_URL}" = "" ]; then
BASE_URL=$(echo $TRAVIS_REPO_SLUG | sed -e 's@.*/@/@')
echo "url: https://$(echo $TRAVIS_REPO_SLUG | sed
's@/.*@.github.io@')" >> ${custom_config_yml}
fi
fi
# Build
JEKYLL_ENV=production \
bundle exec \
jekyll build \
--baseurl="${BASE_URL}" \
--config=_config.yml,${custom_config_yml}
```
See also:
https://jekyllrb.com/docs/configuration/options/#build-command-options
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [arrow-site] kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags
kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags URL: https://github.com/apache/arrow-site/pull/23#discussion_r324439885 ## File path: _config.yml ## @@ -50,6 +51,19 @@ sass: baseurl: plugins: + - jekyll-seo-tag Review comment: Could you sort this list in alphabetical order? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [arrow-site] kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags
kou commented on a change in pull request #23: ARROW-6127: [Website] Add favicons and meta tags URL: https://github.com/apache/arrow-site/pull/23#discussion_r324439954 ## File path: _config.yml ## @@ -36,6 +36,7 @@ exclude: - README.md - vendor - build-and-deploy.sh + - themes Review comment: Is this needed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
