This is an automated email from the ASF dual-hosted git repository. emkornfield pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push: new cb2b60d ARROW-5587: [Java] Add more style check rule for Java code cb2b60d is described below commit cb2b60dfab6ecf7dbb54e10eccf4d8707470a407 Author: tianchen <niki...@alibaba-inc.com> AuthorDate: Sat Jun 15 00:47:39 2019 -0700 ARROW-5587: [Java] Add more style check rule for Java code see [ARROW-5587](https://issues.apache.org/jira/browse/ARROW-5587). Author: tianchen <niki...@alibaba-inc.com> Closes #4567 from tianchen92/ARROW-5587 and squashes the following commits: d5cc7a353 <tianchen> fix style 104c5bb19 <tianchen> ARROW-5587: Add more style check rule for Java code --- java/dev/checkstyle/checkstyle.xml | 10 ++++++++++ .../src/main/java/org/apache/arrow/flight/ArrowMessage.java | 2 +- .../src/main/java/org/apache/arrow/flight/FlightClient.java | 1 - .../src/main/java/org/apache/arrow/flight/FlightEndpoint.java | 1 - .../org/apache/arrow/flight/example/ExampleFlightServer.java | 1 - .../flight/example/integration/IntegrationTestClient.java | 1 - .../test/java/org/apache/arrow/flight/TestBackPressure.java | 1 - .../test/java/org/apache/arrow/flight/TestBasicOperation.java | 1 - .../src/test/java/org/apache/arrow/flight/TestCallOptions.java | 1 - .../test/java/org/apache/arrow/flight/TestLargeMessage.java | 1 - .../org/apache/arrow/flight/example/TestExampleServer.java | 1 - .../org/apache/arrow/flight/perf/PerformanceTestServer.java | 1 - .../java/org/apache/arrow/gandiva/expression/DecimalNode.java | 5 ----- .../org/apache/arrow/gandiva/evaluator/BaseEvaluatorTest.java | 1 - .../org/apache/arrow/gandiva/evaluator/FilterProjectTest.java | 4 ---- .../java/org/apache/arrow/gandiva/evaluator/FilterTest.java | 9 --------- .../apache/arrow/gandiva/evaluator/ProjectorDecimalTest.java | 2 -- .../main/java/org/apache/arrow/memory/AllocationListener.java | 2 +- .../src/main/java/org/apache/arrow/memory/BaseAllocator.java | 2 +- .../main/java/org/apache/arrow/memory/ReferenceManager.java | 2 +- .../java/org/apache/arrow/vector/TimeStampMicroVector.java | 1 - .../java/org/apache/arrow/vector/complex/PromotableVector.java | 2 -- .../org/apache/arrow/vector/complex/RepeatedValueVector.java | 2 +- .../java/org/apache/arrow/vector/complex/StructVector.java | 1 - .../org/apache/arrow/vector/dictionary/DictionaryProvider.java | 4 ++-- .../java/org/apache/arrow/vector/ipc/message/ArrowMessage.java | 2 +- .../test/java/org/apache/arrow/vector/TestDecimalVector.java | 2 -- .../org/apache/arrow/vector/ipc/TestArrowReaderWriter.java | 1 - .../test/java/org/apache/arrow/vector/ipc/TestArrowStream.java | 2 -- 29 files changed, 18 insertions(+), 48 deletions(-) diff --git a/java/dev/checkstyle/checkstyle.xml b/java/dev/checkstyle/checkstyle.xml index 023756c..ec84f40 100644 --- a/java/dev/checkstyle/checkstyle.xml +++ b/java/dev/checkstyle/checkstyle.xml @@ -264,5 +264,15 @@ <module name="CommentsIndentation"/> <!-- needed so that filters can access file contents --> <module name="FileContentsHolder"/> + <module name="UnusedImports"> + <property name="severity" value="error"/> + <property name="processJavadoc" value="true"/> + <message key="import.unused" + value="Unused import: {0}."/> + </module> + <module name="RedundantModifier"> + <!-- Checks for redundant modifiers on various symbol definitions --> + <property name="tokens" value="VARIABLE_DEF, ANNOTATION_FIELD_DEF, INTERFACE_DEF, CLASS_DEF, ENUM_DEF"/> + </module> </module> </module> diff --git a/java/flight/src/main/java/org/apache/arrow/flight/ArrowMessage.java b/java/flight/src/main/java/org/apache/arrow/flight/ArrowMessage.java index 31fdd13..550f5c1 100644 --- a/java/flight/src/main/java/org/apache/arrow/flight/ArrowMessage.java +++ b/java/flight/src/main/java/org/apache/arrow/flight/ArrowMessage.java @@ -78,7 +78,7 @@ class ArrowMessage implements AutoCloseable { private static Marshaller<FlightData> NO_BODY_MARSHALLER = ProtoUtils.marshaller(FlightData.getDefaultInstance()); /** Types of messages that can be sent. */ - public static enum HeaderType { + public enum HeaderType { NONE, SCHEMA, DICTIONARY_BATCH, diff --git a/java/flight/src/main/java/org/apache/arrow/flight/FlightClient.java b/java/flight/src/main/java/org/apache/arrow/flight/FlightClient.java index aa3d029..221423e 100644 --- a/java/flight/src/main/java/org/apache/arrow/flight/FlightClient.java +++ b/java/flight/src/main/java/org/apache/arrow/flight/FlightClient.java @@ -61,7 +61,6 @@ import io.grpc.stub.StreamObserver; import io.netty.channel.EventLoopGroup; import io.netty.channel.ServerChannel; -import io.netty.handler.ssl.SslContext; import io.netty.handler.ssl.SslContextBuilder; /** diff --git a/java/flight/src/main/java/org/apache/arrow/flight/FlightEndpoint.java b/java/flight/src/main/java/org/apache/arrow/flight/FlightEndpoint.java index a34c0a5..6f986ce 100644 --- a/java/flight/src/main/java/org/apache/arrow/flight/FlightEndpoint.java +++ b/java/flight/src/main/java/org/apache/arrow/flight/FlightEndpoint.java @@ -20,7 +20,6 @@ package org.apache.arrow.flight; import java.net.URISyntaxException; import java.util.ArrayList; import java.util.List; -import java.util.stream.Collectors; import org.apache.arrow.flight.impl.Flight; diff --git a/java/flight/src/main/java/org/apache/arrow/flight/example/ExampleFlightServer.java b/java/flight/src/main/java/org/apache/arrow/flight/example/ExampleFlightServer.java index a08f74f..3da409d 100644 --- a/java/flight/src/main/java/org/apache/arrow/flight/example/ExampleFlightServer.java +++ b/java/flight/src/main/java/org/apache/arrow/flight/example/ExampleFlightServer.java @@ -21,7 +21,6 @@ import java.io.IOException; import org.apache.arrow.flight.FlightServer; import org.apache.arrow.flight.Location; -import org.apache.arrow.flight.auth.ServerAuthHandler; import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.apache.arrow.util.AutoCloseables; diff --git a/java/flight/src/main/java/org/apache/arrow/flight/example/integration/IntegrationTestClient.java b/java/flight/src/main/java/org/apache/arrow/flight/example/integration/IntegrationTestClient.java index 6222093..ccafde0 100644 --- a/java/flight/src/main/java/org/apache/arrow/flight/example/integration/IntegrationTestClient.java +++ b/java/flight/src/main/java/org/apache/arrow/flight/example/integration/IntegrationTestClient.java @@ -19,7 +19,6 @@ package org.apache.arrow.flight.example.integration; import java.io.File; import java.io.IOException; -import java.net.URISyntaxException; import java.util.Collections; import java.util.List; diff --git a/java/flight/src/test/java/org/apache/arrow/flight/TestBackPressure.java b/java/flight/src/test/java/org/apache/arrow/flight/TestBackPressure.java index b5dde67..1b40e7e 100644 --- a/java/flight/src/test/java/org/apache/arrow/flight/TestBackPressure.java +++ b/java/flight/src/test/java/org/apache/arrow/flight/TestBackPressure.java @@ -19,7 +19,6 @@ package org.apache.arrow.flight; import java.util.concurrent.atomic.AtomicLong; -import org.apache.arrow.flight.auth.ServerAuthHandler; import org.apache.arrow.flight.perf.PerformanceTestServer; import org.apache.arrow.flight.perf.TestPerf; import org.apache.arrow.memory.BufferAllocator; diff --git a/java/flight/src/test/java/org/apache/arrow/flight/TestBasicOperation.java b/java/flight/src/test/java/org/apache/arrow/flight/TestBasicOperation.java index c0d2435..f8413b0 100644 --- a/java/flight/src/test/java/org/apache/arrow/flight/TestBasicOperation.java +++ b/java/flight/src/test/java/org/apache/arrow/flight/TestBasicOperation.java @@ -24,7 +24,6 @@ import java.util.function.BiConsumer; import java.util.function.Consumer; import org.apache.arrow.flight.FlightClient.ClientStreamListener; -import org.apache.arrow.flight.auth.ServerAuthHandler; import org.apache.arrow.flight.impl.Flight; import org.apache.arrow.flight.impl.Flight.FlightDescriptor.DescriptorType; import org.apache.arrow.flight.impl.Flight.PutResult; diff --git a/java/flight/src/test/java/org/apache/arrow/flight/TestCallOptions.java b/java/flight/src/test/java/org/apache/arrow/flight/TestCallOptions.java index 6ce765e..71d9986 100644 --- a/java/flight/src/test/java/org/apache/arrow/flight/TestCallOptions.java +++ b/java/flight/src/test/java/org/apache/arrow/flight/TestCallOptions.java @@ -24,7 +24,6 @@ import java.util.Iterator; import java.util.concurrent.TimeUnit; import java.util.function.Consumer; -import org.apache.arrow.flight.auth.ServerAuthHandler; import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.junit.Assert; diff --git a/java/flight/src/test/java/org/apache/arrow/flight/TestLargeMessage.java b/java/flight/src/test/java/org/apache/arrow/flight/TestLargeMessage.java index 3996bd0..9913548 100644 --- a/java/flight/src/test/java/org/apache/arrow/flight/TestLargeMessage.java +++ b/java/flight/src/test/java/org/apache/arrow/flight/TestLargeMessage.java @@ -22,7 +22,6 @@ import java.util.List; import java.util.concurrent.Callable; import java.util.stream.Stream; -import org.apache.arrow.flight.auth.ServerAuthHandler; import org.apache.arrow.flight.impl.Flight; import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; diff --git a/java/flight/src/test/java/org/apache/arrow/flight/example/TestExampleServer.java b/java/flight/src/test/java/org/apache/arrow/flight/example/TestExampleServer.java index a580a6e..097c92c 100644 --- a/java/flight/src/test/java/org/apache/arrow/flight/example/TestExampleServer.java +++ b/java/flight/src/test/java/org/apache/arrow/flight/example/TestExampleServer.java @@ -18,7 +18,6 @@ package org.apache.arrow.flight.example; import java.io.IOException; -import java.net.URISyntaxException; import org.apache.arrow.flight.FlightClient; import org.apache.arrow.flight.FlightClient.ClientStreamListener; diff --git a/java/flight/src/test/java/org/apache/arrow/flight/perf/PerformanceTestServer.java b/java/flight/src/test/java/org/apache/arrow/flight/perf/PerformanceTestServer.java index d9d277b..d8d6e67 100644 --- a/java/flight/src/test/java/org/apache/arrow/flight/perf/PerformanceTestServer.java +++ b/java/flight/src/test/java/org/apache/arrow/flight/perf/PerformanceTestServer.java @@ -35,7 +35,6 @@ import org.apache.arrow.flight.FlightStream; import org.apache.arrow.flight.Location; import org.apache.arrow.flight.Result; import org.apache.arrow.flight.Ticket; -import org.apache.arrow.flight.auth.ServerAuthHandler; import org.apache.arrow.flight.impl.Flight.PutResult; import org.apache.arrow.flight.perf.impl.PerfOuterClass.Perf; import org.apache.arrow.flight.perf.impl.PerfOuterClass.Token; diff --git a/java/gandiva/src/main/java/org/apache/arrow/gandiva/expression/DecimalNode.java b/java/gandiva/src/main/java/org/apache/arrow/gandiva/expression/DecimalNode.java index 1b908b9..bf17aa0 100644 --- a/java/gandiva/src/main/java/org/apache/arrow/gandiva/expression/DecimalNode.java +++ b/java/gandiva/src/main/java/org/apache/arrow/gandiva/expression/DecimalNode.java @@ -17,14 +17,9 @@ package org.apache.arrow.gandiva.expression; -import java.nio.charset.Charset; - import org.apache.arrow.gandiva.exceptions.GandivaException; import org.apache.arrow.gandiva.ipc.GandivaTypes; -import com.google.protobuf.ByteString; - - /** * Used to represent expression tree nodes representing decimal constants. * Used in the expression (x + 5.0) diff --git a/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/BaseEvaluatorTest.java b/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/BaseEvaluatorTest.java index 2f44855..0d7c9e3 100644 --- a/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/BaseEvaluatorTest.java +++ b/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/BaseEvaluatorTest.java @@ -18,7 +18,6 @@ package org.apache.arrow.gandiva.evaluator; import java.math.BigDecimal; -import java.math.BigInteger; import java.time.Instant; import java.util.ArrayList; import java.util.List; diff --git a/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterProjectTest.java b/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterProjectTest.java index 33489cc..5dc788c 100644 --- a/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterProjectTest.java +++ b/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterProjectTest.java @@ -19,12 +19,9 @@ package org.apache.arrow.gandiva.evaluator; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; import java.util.ArrayList; -import java.util.Arrays; import java.util.List; -import java.util.stream.IntStream; import org.apache.arrow.gandiva.exceptions.GandivaException; import org.apache.arrow.gandiva.expression.Condition; @@ -36,7 +33,6 @@ import org.apache.arrow.vector.ipc.message.ArrowFieldNode; import org.apache.arrow.vector.ipc.message.ArrowRecordBatch; import org.apache.arrow.vector.types.pojo.Field; import org.apache.arrow.vector.types.pojo.Schema; -import org.junit.Assert; import org.junit.Test; import com.google.common.collect.Lists; diff --git a/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterTest.java b/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterTest.java index 113f70e..8f63158 100644 --- a/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterTest.java +++ b/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterTest.java @@ -17,21 +17,12 @@ package org.apache.arrow.gandiva.evaluator; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; - -import java.util.ArrayList; -import java.util.Arrays; import java.util.List; import java.util.stream.IntStream; import org.apache.arrow.gandiva.exceptions.GandivaException; import org.apache.arrow.gandiva.expression.Condition; -import org.apache.arrow.gandiva.expression.ExpressionTree; import org.apache.arrow.gandiva.expression.TreeBuilder; -import org.apache.arrow.vector.IntVector; -import org.apache.arrow.vector.ValueVector; import org.apache.arrow.vector.ipc.message.ArrowFieldNode; import org.apache.arrow.vector.ipc.message.ArrowRecordBatch; import org.apache.arrow.vector.types.pojo.Field; diff --git a/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/ProjectorDecimalTest.java b/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/ProjectorDecimalTest.java index 3a7459b..aaacffd 100644 --- a/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/ProjectorDecimalTest.java +++ b/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/ProjectorDecimalTest.java @@ -17,8 +17,6 @@ package org.apache.arrow.gandiva.evaluator; - -import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; diff --git a/java/memory/src/main/java/org/apache/arrow/memory/AllocationListener.java b/java/memory/src/main/java/org/apache/arrow/memory/AllocationListener.java index fba6a70..ff2b25d 100644 --- a/java/memory/src/main/java/org/apache/arrow/memory/AllocationListener.java +++ b/java/memory/src/main/java/org/apache/arrow/memory/AllocationListener.java @@ -25,7 +25,7 @@ package org.apache.arrow.memory; */ public interface AllocationListener { - public static final AllocationListener NOOP = new AllocationListener() {}; + AllocationListener NOOP = new AllocationListener() {}; /** * Called each time a new buffer has been requested. diff --git a/java/memory/src/main/java/org/apache/arrow/memory/BaseAllocator.java b/java/memory/src/main/java/org/apache/arrow/memory/BaseAllocator.java index c1e7a12..1f0f37d 100644 --- a/java/memory/src/main/java/org/apache/arrow/memory/BaseAllocator.java +++ b/java/memory/src/main/java/org/apache/arrow/memory/BaseAllocator.java @@ -701,7 +701,7 @@ public abstract class BaseAllocator extends Accountant implements BufferAllocato /** * Enum for logging verbosity. */ - public static enum Verbosity { + public enum Verbosity { BASIC(false, false), // only include basic information LOG(true, false), // include basic LOG_WITH_STACKTRACE(true, true) // diff --git a/java/memory/src/main/java/org/apache/arrow/memory/ReferenceManager.java b/java/memory/src/main/java/org/apache/arrow/memory/ReferenceManager.java index 6ecab49..e68ebc3 100644 --- a/java/memory/src/main/java/org/apache/arrow/memory/ReferenceManager.java +++ b/java/memory/src/main/java/org/apache/arrow/memory/ReferenceManager.java @@ -119,7 +119,7 @@ public interface ReferenceManager { */ int getAccountedSize(); - public static String NO_OP_ERROR_MESSAGE = "Operation not supported on NO_OP Reference Manager"; + String NO_OP_ERROR_MESSAGE = "Operation not supported on NO_OP Reference Manager"; // currently used for empty ArrowBufs ReferenceManager NO_OP = new ReferenceManager() { diff --git a/java/vector/src/main/java/org/apache/arrow/vector/TimeStampMicroVector.java b/java/vector/src/main/java/org/apache/arrow/vector/TimeStampMicroVector.java index ea71fb7..2a427de 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/TimeStampMicroVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/TimeStampMicroVector.java @@ -18,7 +18,6 @@ package org.apache.arrow.vector; import java.time.LocalDateTime; -import java.time.temporal.ChronoUnit; import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.vector.complex.impl.TimeStampMicroReaderImpl; diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/PromotableVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/PromotableVector.java index 6c8cba5..d4dd94a 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/complex/PromotableVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/PromotableVector.java @@ -19,8 +19,6 @@ package org.apache.arrow.vector.complex; import org.apache.arrow.vector.AddOrGetResult; import org.apache.arrow.vector.ValueVector; -import org.apache.arrow.vector.types.Types.MinorType; -import org.apache.arrow.vector.types.pojo.DictionaryEncoding; import org.apache.arrow.vector.types.pojo.FieldType; /** diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/RepeatedValueVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/RepeatedValueVector.java index 054a339..f39ab27 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/complex/RepeatedValueVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/RepeatedValueVector.java @@ -30,7 +30,7 @@ import org.apache.arrow.vector.ValueVector; */ public interface RepeatedValueVector extends ValueVector, DensityAwareVector { - static final int DEFAULT_REPEAT_PER_RECORD = 5; + int DEFAULT_REPEAT_PER_RECORD = 5; /** * Get the offset vector. diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java index 7481fa8..fddd149 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java @@ -37,7 +37,6 @@ import org.apache.arrow.vector.ipc.message.ArrowFieldNode; import org.apache.arrow.vector.types.pojo.ArrowType; import org.apache.arrow.vector.types.pojo.ArrowType.Struct; import org.apache.arrow.vector.types.pojo.DictionaryEncoding; -import org.apache.arrow.vector.types.pojo.Field; import org.apache.arrow.vector.types.pojo.FieldType; import org.apache.arrow.vector.util.CallBack; import org.apache.arrow.vector.util.OversizedAllocationException; diff --git a/java/vector/src/main/java/org/apache/arrow/vector/dictionary/DictionaryProvider.java b/java/vector/src/main/java/org/apache/arrow/vector/dictionary/DictionaryProvider.java index e99fd1c..21165c0 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/dictionary/DictionaryProvider.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/dictionary/DictionaryProvider.java @@ -27,12 +27,12 @@ import java.util.Set; public interface DictionaryProvider { /** Return the dictionary for the given ID. */ - public Dictionary lookup(long id); + Dictionary lookup(long id); /** * Implementation of {@link DictionaryProvider} that is backed by a hash-map. */ - public static class MapDictionaryProvider implements DictionaryProvider { + class MapDictionaryProvider implements DictionaryProvider { private final Map<Long, Dictionary> map; diff --git a/java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowMessage.java b/java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowMessage.java index 45c697a..441f6ec 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowMessage.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowMessage.java @@ -31,7 +31,7 @@ public interface ArrowMessage extends FBSerializable, AutoCloseable { * * @param <T> The type of value to return after visiting. */ - static interface ArrowMessageVisitor<T> { + interface ArrowMessageVisitor<T> { T visit(ArrowDictionaryBatch message); T visit(ArrowRecordBatch message); diff --git a/java/vector/src/test/java/org/apache/arrow/vector/TestDecimalVector.java b/java/vector/src/test/java/org/apache/arrow/vector/TestDecimalVector.java index 6ec7b53..e900135 100644 --- a/java/vector/src/test/java/org/apache/arrow/vector/TestDecimalVector.java +++ b/java/vector/src/test/java/org/apache/arrow/vector/TestDecimalVector.java @@ -25,9 +25,7 @@ import java.math.BigDecimal; import java.math.BigInteger; import org.apache.arrow.memory.BufferAllocator; -import org.apache.arrow.memory.RootAllocator; import org.apache.arrow.vector.types.pojo.ArrowType; -import org.apache.arrow.vector.util.DecimalUtility; import org.junit.After; import org.junit.Before; import org.junit.Test; diff --git a/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowReaderWriter.java b/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowReaderWriter.java index 7773792..f3084ad 100644 --- a/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowReaderWriter.java +++ b/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowReaderWriter.java @@ -21,7 +21,6 @@ import static java.nio.channels.Channels.newChannel; import static java.util.Arrays.asList; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertTrue; import java.io.ByteArrayOutputStream; import java.io.IOException; diff --git a/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowStream.java b/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowStream.java index c487a60..92e5276 100644 --- a/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowStream.java +++ b/java/vector/src/test/java/org/apache/arrow/vector/ipc/TestArrowStream.java @@ -27,11 +27,9 @@ import java.io.IOException; import java.nio.channels.Channels; import java.util.Collections; -import org.apache.arrow.vector.FieldVector; import org.apache.arrow.vector.IntVector; import org.apache.arrow.vector.TinyIntVector; import org.apache.arrow.vector.VectorSchemaRoot; -import org.apache.arrow.vector.dictionary.DictionaryProvider; import org.apache.arrow.vector.types.pojo.Schema; import org.junit.Assert; import org.junit.Test;