This is an automated email from the ASF dual-hosted git repository.
mhubail pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
The following commit(s) were added to refs/heads/master by this push:
new 44630dd476 [ASTERIXDB-3383][RT] resolving comments
44630dd476 is described below
commit 44630dd476f577c769b0316cfc871dc52eb4c195
Author: Ritik Raj <raj.ritik9...@gmail.com>
AuthorDate: Sun Apr 21 21:58:07 2024 +0530
[ASTERIXDB-3383][RT] resolving comments
Change-Id: I694d41db144eb8375171a0913cec837ac3fdab0e
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18245
Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ritik Raj <raj.ritik9...@gmail.com>
Reviewed-by: Murtadha Hubail <mhub...@apache.org>
---
.../main/java/org/apache/asterix/metadata/utils/DatasetUtil.java | 1 -
.../hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java | 7 +++----
.../storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java | 2 --
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
index becdbc1463..923dbd4547 100644
---
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
@@ -533,7 +533,6 @@ public class DatasetUtil {
}
RecordDescriptor outputRecordDesc = new RecordDescriptor(outputSerDes,
outputTypeTraits);
- // get the Tuple filter callback
ILSMTupleFilterCallbackFactory tupleFilterCallbackFactory =
dataset.getTupleFilterCallbackFactory();
// This allows to project only the indexed fields instead of the
entirety of the record
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java
index 05a9e1a947..c2229fbc35 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java
@@ -26,14 +26,13 @@ import
org.apache.hyracks.dataflow.common.comm.io.FrameTupleAccessor;
public interface ILSMTupleFilterCallback extends Serializable {
/**
- * Populates the state within the filter callback by fetching the state
from the provided "index"
- * and mapping it with the storage partition index, which will be utilized
for filtering
- * the tuple directed to the index "storagePartitionIdx".
+ * Initializes the filter callback
*/
void initialize(ILSMIndex index) throws HyracksDataException;
/**
- * Filter the received record based on the initialized ingestion state.
+ * This method is called on a tuple to evaluate whether the tuple meets
the criteria
+ * for filtration based on the specified filter condition.
*/
boolean filter(FrameTupleAccessor accessor, int tupleIdx);
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java
index dc271fd376..011d48f624 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java
@@ -24,8 +24,6 @@ import java.io.Serializable;
public interface ILSMTupleFilterCallbackFactory extends Serializable {
/**
* Creates a callback function that utilizes the field permutation of the
incoming tuple.
- * The field tuple contains information about the position of the record,
meta, and primary key,
- * facilitating the extraction of relevant information for filtering
purposes.
*/
ILSMTupleFilterCallback createTupleFilterCallback(int[] fieldPermutation);
}
