This is an automated email from the ASF dual-hosted git repository.

mhubail pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new a08a5a4bbf [NO ISSUE][OTH] Move compile time storage config to common 
config
a08a5a4bbf is described below

commit a08a5a4bbf892f51e37e329bd6e39b49a2ee202f
Author: Murtadha Hubail <mhub...@apache.org>
AuthorDate: Sat May 13 20:31:46 2023 +0300

    [NO ISSUE][OTH] Move compile time storage config to common config
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    
    - Move the storage properties used during compilation to
      the properties common section to avoid warning of usage
      outside NC scope.
    
    Change-Id: Iac165a252fcecd2e23bdd47cc69a67e5253edd58
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17527
    Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
    Reviewed-by: Till Westmann <ti...@apache.org>
    Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
---
 .../runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm   | 3 +++
 .../results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm   | 3 +++
 .../results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm   | 3 +++
 .../main/java/org/apache/asterix/common/config/StorageProperties.java  | 3 +++
 4 files changed, 12 insertions(+)

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
index f28c30311f..bdd3f515ef 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
@@ -51,7 +51,10 @@
     "replication\.strategy" : "none",
     "replication\.timeout" : 120,
     "ssl\.enabled" : false,
+    "storage.column.free.space.tolerance" : 0.15,
+    "storage.column.max.tuple.count" : 15000,
     "storage.compression.block" : "snappy",
+    "storage.format" : "row",
     "storage.global.cleanup.timeout" : 600,
     "storage.lsm.bloomfilter.falsepositiverate" : 0.01,
     "storage.partitioning" : "dynamic",
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
index 99001d865f..7c416e6622 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
@@ -51,7 +51,10 @@
     "replication\.strategy" : "none",
     "replication\.timeout" : 120,
     "ssl\.enabled" : false,
+    "storage.column.free.space.tolerance" : 0.15,
+    "storage.column.max.tuple.count" : 15000,
     "storage.compression.block" : "snappy",
+    "storage.format" : "row",
     "storage.global.cleanup.timeout" : 600,
     "storage.lsm.bloomfilter.falsepositiverate" : 0.01,
     "storage.partitioning" : "dynamic",
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
index f62aee38c9..a28cc11642 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
@@ -51,7 +51,10 @@
     "replication\.strategy" : "none",
     "replication\.timeout" : 120,
     "ssl\.enabled" : false,
+    "storage.column.free.space.tolerance" : 0.15,
+    "storage.column.max.tuple.count" : 15000,
     "storage.compression.block" : "snappy",
+    "storage.format" : "row",
     "storage.global.cleanup.timeout" : 600,
     "storage.lsm.bloomfilter.falsepositiverate" : 0.01,
     "storage.partitioning" : "dynamic",
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
index d61ee14273..70cd4ff65d 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
@@ -87,6 +87,9 @@ public class StorageProperties extends AbstractProperties {
                 case STORAGE_GLOBAL_CLEANUP_TIMEOUT:
                 case STORAGE_PARTITIONING:
                 case STORAGE_PARTITIONS_COUNT:
+                case STORAGE_FORMAT:
+                case STORAGE_COLUMN_MAX_TUPLE_COUNT:
+                case STORAGE_COLUMN_FREE_SPACE_TOLERANCE:
                     return Section.COMMON;
                 default:
                     return Section.NC;

Reply via email to