Repository: aurora Updated Branches: refs/heads/master b0d24f4d5 -> b00a15e48
Fix update affinity cache name In a previous review (https://reviews.apache.org/r/58636/) I introduced metrics for BiCache explicit removals and expirations. There I changed the contract to instead of passing _cache size metric name_, I require just the __cache name__. That has already up applied to all usages of Bichae. The update affinitiy patch had a merge conflict that did not pick this change, which leads to metric names such as `update_affinity_cache_size_cache_expiration_removals`, `update_affinity_cache_size_cache_explicit_removals`, `update_affinity_cache_size_cache_removals`, `update_affinity_cache_size_cache_size`. Reviewed at https://reviews.apache.org/r/59231/ Project: http://git-wip-us.apache.org/repos/asf/aurora/repo Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/b00a15e4 Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/b00a15e4 Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/b00a15e4 Branch: refs/heads/master Commit: b00a15e48dc87cbefc2912603b66173fdbc4f104 Parents: b0d24f4 Author: Reza Motamedi <reza.motam...@gmail.com> Authored: Sun May 14 21:13:51 2017 +0200 Committer: Stephan Erb <s...@apache.org> Committed: Sun May 14 21:13:51 2017 +0200 ---------------------------------------------------------------------- .../java/org/apache/aurora/scheduler/updater/UpdaterModule.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/aurora/blob/b00a15e4/src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java b/src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java index 219bb4e..3673031 100644 --- a/src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java +++ b/src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java @@ -71,7 +71,7 @@ public class UpdaterModule extends AbstractModule { protected void configure() { if (enableAffinity) { bind(BiCacheSettings.class).toInstance( - new BiCacheSettings(AFFINITY_EXPIRATION.get(), "update_affinity_cache_size")); + new BiCacheSettings(AFFINITY_EXPIRATION.get(), "update_affinity")); bind(new TypeLiteral<BiCache<IInstanceKey, TaskGroupKey>>() { }).in(Singleton.class); bind(UpdateAgentReserver.class).to(UpdateAgentReserver.UpdateAgentReserverImpl.class); bind(UpdateAgentReserver.UpdateAgentReserverImpl.class).in(Singleton.class);