Repository: beam Updated Branches: refs/heads/master ea33f2a4a -> 5c74022da
Update julia set example comments Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/7fe7732b Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/7fe7732b Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/7fe7732b Branch: refs/heads/master Commit: 7fe7732bbf7721231ef7ec072307e533f006aef3 Parents: ea33f2a Author: Ahmet Altay <al...@google.com> Authored: Wed Nov 22 11:43:05 2017 -0800 Committer: Ahmet Altay <al...@google.com> Committed: Wed Nov 22 11:49:50 2017 -0800 ---------------------------------------------------------------------- .../examples/complete/juliaset/juliaset_main.py | 2 +- .../apache_beam/examples/complete/juliaset/setup.py | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/7fe7732b/sdks/python/apache_beam/examples/complete/juliaset/juliaset_main.py ---------------------------------------------------------------------- diff --git a/sdks/python/apache_beam/examples/complete/juliaset/juliaset_main.py b/sdks/python/apache_beam/examples/complete/juliaset/juliaset_main.py index 1d521be..7289b04 100644 --- a/sdks/python/apache_beam/examples/complete/juliaset/juliaset_main.py +++ b/sdks/python/apache_beam/examples/complete/juliaset/juliaset_main.py @@ -43,7 +43,7 @@ python juliaset_main.py \ --staging_location gs://YOUR-BUCKET/juliaset/staging \ --temp_location gs://YOUR-BUCKET/juliaset/temp \ --coordinate_output gs://YOUR-BUCKET/juliaset/out \ - --grid_size 20 \ + --grid_size 20 """ http://git-wip-us.apache.org/repos/asf/beam/blob/7fe7732b/sdks/python/apache_beam/examples/complete/juliaset/setup.py ---------------------------------------------------------------------- diff --git a/sdks/python/apache_beam/examples/complete/juliaset/setup.py b/sdks/python/apache_beam/examples/complete/juliaset/setup.py index cbf5f3d..2fcde7d 100644 --- a/sdks/python/apache_beam/examples/complete/juliaset/setup.py +++ b/sdks/python/apache_beam/examples/complete/juliaset/setup.py @@ -51,7 +51,7 @@ class build(_build): # pylint: disable=invalid-name # two commands will have to be added: # # ['apt-get', 'update'], -# ['apt-get', '--assume-yes', install', 'libjpeg62'], +# ['apt-get', '--assume-yes', 'install', 'libjpeg62'], # # First, note that there is no need to use the sudo command because the setup # script runs with appropriate access. @@ -61,6 +61,14 @@ class build(_build): # pylint: disable=invalid-name # will fail with package not found errors. Note also --assume-yes option which # shortcuts the interactive confirmation. # +# Note that in this example custom commands will run after installing required +# packages. If you have a PyPI package that depends on one of the custom +# commands, move installation of the dependent package to the list of custom +# commands, e.g.: +# +# ['pip', 'install', 'my_package'], +# +# TODO(BEAM-3237): Output from the custom commands are missing from the logs. # The output of custom commands (including failures) will be logged in the # worker-startup log. CUSTOM_COMMANDS = [
