acrites commented on issue #10988: [BEAM-9382] Clean up of
TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-598997790
Apparently the failing test in the PreCommit has been "Failing for the past
11,721 builds (Since #0 )"
acrites commented on issue #10988: [BEAM-9382] Clean up of
TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-598262109
Run Python PreCommit
This is an automated message from the Apache
acrites commented on issue #10988: [BEAM-9382] Clean up of
TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-597797005
Run Python PreCommit
This is an automated message from the Apache
acrites commented on issue #10988: [BEAM-9382] Clean up of
TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-597287538
It looks like TriggerDriverTranscriptTest.test_early_late_sessions is
failing (since there's no way to sickbay that test). Am I
acrites commented on issue #10988: [BEAM-9382] Clean up of
TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-597194043
Run Python PreCommit
This is an automated message from the Apache
acrites commented on issue #10988: [BEAM-9382] Clean up of
TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-597190980
Actually, that last example doesn't fail like I would expect. So I guess the
Python direct runner sets final = true sometimes...
acrites commented on issue #10988: [BEAM-9382] Clean up of
TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-596263133
RE fixing the Python direct runner: right now we just use the return value
from on_fire for each trigger to set the final bit. This
acrites commented on issue #10988: [BEAM-9382] Clean up of
TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-593753721
Along the lines of what Kenn is saying, I had originally thought that these
tests weren't really testing whether or not
