[GitHub] [beam] chadrik commented on a change in pull request #11022: [BEAM-7746] Resolve typing issues in filesystem

2020-03-03 Thread GitBox
chadrik commented on a change in pull request #11022: [BEAM-7746] Resolve typing issues in filesystem URL: https://github.com/apache/beam/pull/11022#discussion_r387300879 ## File path: sdks/python/apache_beam/io/filesystemio.py ## @@ -175,10 +190,31 @@ def readall(self):

[GitHub] [beam] chadrik commented on a change in pull request #11022: [BEAM-7746] Resolve typing issues in filesystem

2020-03-02 Thread GitBox
chadrik commented on a change in pull request #11022: [BEAM-7746] Resolve typing issues in filesystem URL: https://github.com/apache/beam/pull/11022#discussion_r386809980 ## File path: sdks/python/apache_beam/io/localfilesystem.py ## @@ -136,10 +137,17 @@ def _path_open(

[GitHub] [beam] chadrik commented on a change in pull request #11022: [BEAM-7746] Resolve typing issues in filesystem

2020-03-02 Thread GitBox
chadrik commented on a change in pull request #11022: [BEAM-7746] Resolve typing issues in filesystem URL: https://github.com/apache/beam/pull/11022#discussion_r386809980 ## File path: sdks/python/apache_beam/io/localfilesystem.py ## @@ -136,10 +137,17 @@ def _path_open(

[GitHub] [beam] chadrik commented on a change in pull request #11022: [BEAM-7746] Resolve typing issues in filesystem

2020-03-02 Thread GitBox
chadrik commented on a change in pull request #11022: [BEAM-7746] Resolve typing issues in filesystem URL: https://github.com/apache/beam/pull/11022#discussion_r386809980 ## File path: sdks/python/apache_beam/io/localfilesystem.py ## @@ -136,10 +137,17 @@ def _path_open(

[GitHub] [beam] chadrik commented on a change in pull request #11022: [BEAM-7746] Resolve typing issues in filesystem

2020-03-02 Thread GitBox
chadrik commented on a change in pull request #11022: [BEAM-7746] Resolve typing issues in filesystem URL: https://github.com/apache/beam/pull/11022#discussion_r386809980 ## File path: sdks/python/apache_beam/io/localfilesystem.py ## @@ -136,10 +137,17 @@ def _path_open(