[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-28 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-592678321 @udim All tests passing now This is an automated message from the Apache Git

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-27 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-592164134 Do we think this is safe to merge? I've been watching master for something that looks like it could solve the current test problems, and

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-27 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-592117791 Run PythonLint PreCommit This is an automated message from the Apache Git

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591735657 @robertwb I don't think the test failures are my fault because they were passing before I rebased onto master...

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591716771 Run Python PreCommit This is an automated message from the Apache Git Service.

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591685577 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591610348 Down to 79 errors! Btw, mypy may have revealed some legitimate errors in a recent change: ```