[GitHub] [beam] kennknowles commented on issue #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests.

2020-03-13 Thread GitBox
kennknowles commented on issue #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests. URL: https://github.com/apache/beam/pull/10988#issuecomment-598878883 Yea I don't think anyone is happy about it. But it has always been that way and also is the only way we meet the spec of panes

[GitHub] [beam] kennknowles commented on issue #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests.

2020-03-10 Thread GitBox
kennknowles commented on issue #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests. URL: https://github.com/apache/beam/pull/10988#issuecomment-597288570 Yea, that's right. This is an automated message from the Apache

[GitHub] [beam] kennknowles commented on issue #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests.

2020-03-02 Thread GitBox
kennknowles commented on issue #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests. URL: https://github.com/apache/beam/pull/10988#issuecomment-593740435 Since we are doing drive by comments, perhaps a clear comment describing exactly what the test is trying to verify would allow us