[GitHub] [beam] steveniemitz commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-03-19 Thread GitBox
steveniemitz commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-601280654 so I think this was enough to get it working in dataflow: ``` diff --git

[GitHub] [beam] steveniemitz commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-03-19 Thread GitBox
steveniemitz commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-601243984 seems like this is broken/unsupported in dataflow: ``` java.lang.ClassCastException: java.lang.String cannot be

[GitHub] [beam] steveniemitz commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-03-19 Thread GitBox
steveniemitz commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-601226883 > Thank you @steveniemitz for catching this bug. Can you please mention how can I reproduce it so that I can fix this.

[GitHub] [beam] steveniemitz commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-03-19 Thread GitBox
steveniemitz commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-601221088 I think the type check for `@KeyId` breaks if the key is generic. I was trying this out and got: ```