This is an automated email from the ASF dual-hosted git repository.
lcwik pushed a commit to branch go-sdk
in repository https://gitbox.apache.org/repos/asf/beam.git
commit a86c25e372c39e6a6780fa262ad45105a46e00b9
Author: Bill Neubauer <w...@google.com>
AuthorDate: Tue Jan 16 14:29:08 2018 -0800
Remove GetId() call from under lock.
Don't want to have anything happening while holding the plan
lock that isn't obvious it can't fail.
---
sdks/go/pkg/beam/core/runtime/harness/harness.go | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sdks/go/pkg/beam/core/runtime/harness/harness.go
b/sdks/go/pkg/beam/core/runtime/harness/harness.go
index 72db1f1..335e2b3 100644
--- a/sdks/go/pkg/beam/core/runtime/harness/harness.go
+++ b/sdks/go/pkg/beam/core/runtime/harness/harness.go
@@ -176,10 +176,12 @@ func (c *control) handleInstruction(ctx context.Context,
req *fnpb.InstructionRe
if err != nil {
return fail(id, "translation failed: %v", err)
}
- log.Debugf(ctx, "Plan %v: %v", desc.GetId(), plan)
+
+ pid := desc.GetId()
+ log.Debugf(ctx, "Plan %v: %v", pid, plan)
c.mu.Lock()
- c.plans[desc.GetId()] = plan
+ c.plans[pid] = plan
c.mu.Unlock()
}
--
To stop receiving notification emails like this one, please contact
"commits@beam.apache.org" <commits@beam.apache.org>.
