This is an automated email from the ASF dual-hosted git repository.

ibzib pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new e4f37d22812 Add self-descriptive message for expected errors.
     new 2583cd466f7 Merge pull request #17254 from ibzib/red-herring
e4f37d22812 is described below

commit e4f37d22812c416b20ff9df182a8ef0d7945edc9
Author: Kyle Weaver <kcwea...@google.com>
AuthorDate: Fri Apr 1 16:42:56 2022 -0700

    Add self-descriptive message for expected errors.
    
    Ideally we would not log these in the first place, but this is an easy hack.
---
 .../apache_beam/runners/portability/fn_api_runner/fn_runner_test.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git 
a/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py 
b/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
index 12a784b8410..06b649591cd 100644
--- 
a/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
+++ 
b/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
@@ -889,7 +889,8 @@ class FnApiRunnerTest(unittest.TestCase):
       with self.create_pipeline() as p:
 
         def raise_error(x):
-          raise RuntimeError('x')
+          raise RuntimeError(
+              'This error is expected and does not indicate a test failure.')
 
         # pylint: disable=expression-not-assigned
         (
@@ -912,7 +913,8 @@ class FnApiRunnerTest(unittest.TestCase):
       return third(x)
 
     def third(x):
-      raise ValueError('x')
+      raise ValueError(
+          'This error is expected and does not indicate a test failure.')
 
     try:
       with self.create_pipeline() as p:

Reply via email to