This is an automated email from the ASF dual-hosted git repository. altay pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push: new 640ced8 Remove base tests from python precommits new 187d71e Merge pull request #9985 from aaltay/prec 640ced8 is described below commit 640ced80c15fa899b6343e645bf8cb99f9df11c5 Author: Ahmet Altay <al...@google.com> AuthorDate: Mon Nov 4 13:46:35 2019 -0800 Remove base tests from python precommits GCP and Cython test variants provide the same coverage and also ensure that test could run with or without GCP or Cython components intalled. --- sdks/python/test-suites/tox/py2/build.gradle | 3 +-- sdks/python/test-suites/tox/py35/build.gradle | 3 +-- sdks/python/test-suites/tox/py36/build.gradle | 2 -- sdks/python/test-suites/tox/py37/build.gradle | 2 -- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/sdks/python/test-suites/tox/py2/build.gradle b/sdks/python/test-suites/tox/py2/build.gradle index 7d4cd6a..04748d0 100644 --- a/sdks/python/test-suites/tox/py2/build.gradle +++ b/sdks/python/test-suites/tox/py2/build.gradle @@ -40,6 +40,7 @@ test.dependsOn testPython2 toxTask "testPy2Cython", "py27-cython" test.dependsOn testPy2Cython + // Ensure that testPy2Cython runs exclusively to other tests. This line is not // actually required, since gradle doesn't do parallel execution within a // project. @@ -61,14 +62,12 @@ toxTask "cover", "cover" task preCommitPy2() { dependsOn "docs" dependsOn "testPy2Cython" - dependsOn "testPython2" dependsOn "testPy2Gcp" } task preCommitPy2Pytest { dependsOn "docs" dependsOn "testPy2CythonPytest" - dependsOn "testPython2Pytest" dependsOn "testPy2GcpPytest" dependsOn "lint" } diff --git a/sdks/python/test-suites/tox/py35/build.gradle b/sdks/python/test-suites/tox/py35/build.gradle index 0736792..37e13f6 100644 --- a/sdks/python/test-suites/tox/py35/build.gradle +++ b/sdks/python/test-suites/tox/py35/build.gradle @@ -34,6 +34,7 @@ test.dependsOn testPy35Gcp toxTask "testPy35Cython", "py35-cython" test.dependsOn testPy35Cython + // Ensure that testPy35Cython runs exclusively to other tests. This line is not // actually required, since gradle doesn't do parallel execution within a // project. @@ -48,13 +49,11 @@ toxTask "testPy35CythonPytest", "py35-cython-pytest" testPy35CythonPytest.mustRunAfter testPython35Pytest, testPy35GcpPytest task preCommitPy35() { - dependsOn "testPython35" dependsOn "testPy35Gcp" dependsOn "testPy35Cython" } task preCommitPy35Pytest { - dependsOn "testPython35Pytest" dependsOn "testPy35GcpPytest" dependsOn "testPy35CythonPytest" dependsOn "lint" diff --git a/sdks/python/test-suites/tox/py36/build.gradle b/sdks/python/test-suites/tox/py36/build.gradle index 2422a15..8171366 100644 --- a/sdks/python/test-suites/tox/py36/build.gradle +++ b/sdks/python/test-suites/tox/py36/build.gradle @@ -49,13 +49,11 @@ toxTask "testPy36CythonPytest", "py36-cython-pytest" testPy36CythonPytest.mustRunAfter testPython36Pytest, testPy36GcpPytest task preCommitPy36() { - dependsOn "testPython36" dependsOn "testPy36Gcp" dependsOn "testPy36Cython" } task preCommitPy36Pytest { - dependsOn "testPython36Pytest" dependsOn "testPy36GcpPytest" dependsOn "testPy36CythonPytest" } diff --git a/sdks/python/test-suites/tox/py37/build.gradle b/sdks/python/test-suites/tox/py37/build.gradle index d30c393..2a57ca9 100644 --- a/sdks/python/test-suites/tox/py37/build.gradle +++ b/sdks/python/test-suites/tox/py37/build.gradle @@ -58,14 +58,12 @@ toxTask "testPy37CythonPytest", "py37-cython-pytest" testPy37CythonPytest.mustRunAfter testPython37Pytest, testPy37GcpPytest task preCommitPy37() { - dependsOn "testPython37" dependsOn "testPy37Gcp" dependsOn "testPy37Cython" dependsOn "testPy37Interactive" } task preCommitPy37Pytest { - dependsOn "testPython37Pytest" dependsOn "testPy37GcpPytest" dependsOn "testPy37CythonPytest" }