piotr-szuberski commented on a change in pull request #11122: [BEAM-9346]
Improve the efficiency of TFRecordIO
URL: https://github.com/apache/beam/pull/11122#discussion_r395475008
##
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##
@@
iemejia commented on issue #11178: [BEAM-9430] Update CHANGES.md to reflect
removal of ProcessContext#updateWatermark
URL: https://github.com/apache/beam/pull/11178#issuecomment-601605616
I am not sure if this means now that we can resolve the issue. Please do it
yourself if it is the
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine
test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601569728
Run Load Tests Java Combine Portable Flink Batch
This
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine
test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601569767
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-592441414
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-592452480
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600052646
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-599915764
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600037517
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-591962646
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600076078
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600070865
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-592476627
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-586959242
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-580731061
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-591959468
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-586256259
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-586964776
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-580198417
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-591954597
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-580728679
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-586261220
Run Load Tests Java Combine Portable Flink Batch
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine
test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601597356
@mxm I ran into a problem with TaskManagers timing out in a streaming case,
the latest failed test is an example of
mxm edited a comment on issue #10386: [BEAM-8972] Add Jenkins job with Combine
test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601606381
>@mxm I ran into a problem with TaskManagers timing out in a streaming case,
the latest failed test is an example of
mxm edited a comment on issue #10386: [BEAM-8972] Add Jenkins job with Combine
test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601606381
>@mxm I ran into a problem with TaskManagers timing out in a streaming case,
the latest failed test is an example of
mxm edited a comment on issue #10386: [BEAM-8972] Add Jenkins job with Combine
test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601606381
>@mxm I ran into a problem with TaskManagers timing out in a streaming case,
the latest failed test is an example of
alexvanboxel commented on issue #11008: Update comment to tell user this is not
secure
URL: https://github.com/apache/beam/pull/11008#issuecomment-601569348
> What should be the next action here? Should we remove it? Or add this
comment?
Personally I would close this PR as the
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601569728
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601569767
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601185879
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601567693
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600031195
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-592457334
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600106774
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-599928528
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-599965509
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600131618
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600559891
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600135623
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600656596
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600029608
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600527389
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600564536
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600613410
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600602229
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600613470
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600602288
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600564484
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600524672
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600573249
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600586885
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601048332
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600109497
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600081286
Run Load Tests Java Combine Portable Flink Batch
iemejia merged pull request #11178: [BEAM-9430] Update CHANGES.md to reflect
removal of ProcessContext#updateWatermark
URL: https://github.com/apache/beam/pull/11178
This is an automated message from the Apache Git Service.
This is an automated email from the ASF dual-hosted git repository.
iemejia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git.
from e9430a0 Merge pull request #11167 from lukecwik/proto5
add e03a992 [BEAM-9430] Update CHANGES.md to reflect
mxm commented on issue #11178: [BEAM-9430] Update CHANGES.md to reflect removal
of ProcessContext#updateWatermark
URL: https://github.com/apache/beam/pull/11178#issuecomment-601608697
Thanks @lukecwik.
@iemejia Why the quick merge if a review was still pending on me?
mxm commented on a change in pull request #11178: [BEAM-9430] Update CHANGES.md
to reflect removal of ProcessContext#updateWatermark
URL: https://github.com/apache/beam/pull/11178#discussion_r395523161
##
File path: CHANGES.md
##
@@ -58,6 +58,7 @@
## Breaking Changes
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine
test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601567693
run seed job
This is an automated message from the
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601130890
Run Load Tests Java Combine Portable Flink Batch
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-60079
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601107028
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601093845
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601057353
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601158639
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600658641
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-600133615
run seed job
This is an automated message from
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601094876
Run Load Tests Java Combine Portable Flink Streaming
mwalenia removed a comment on issue #10386: [BEAM-8972] Add Jenkins job with
Combine test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601110114
run seed job
This is an automated message from
mxm commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test
for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601606381
>@mxm I ran into a problem with TaskManagers timing out in a streaming case,
the latest failed test is an example of this.
piotr-szuberski opened a new pull request #11180: [BEAM-9563] Change
ToListCombineFn access level to private
URL: https://github.com/apache/beam/pull/11180
The access level of ToListCombineFn can be private.
But more important things were in the discussion below #11122 there were
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine
test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601616918
cc @kamilwu : Memory management changed in Flink 1.10, which might have some
impact on Flink jobs we're seeing in
iemejia commented on a change in pull request #11178: [BEAM-9430] Update
CHANGES.md to reflect removal of ProcessContext#updateWatermark
URL: https://github.com/apache/beam/pull/11178#discussion_r395572143
##
File path: CHANGES.md
##
@@ -58,6 +58,7 @@
## Breaking Changes
mxm commented on issue #11178: [BEAM-9430] Update CHANGES.md to reflect removal
of ProcessContext#updateWatermark
URL: https://github.com/apache/beam/pull/11178#issuecomment-601652327
If there was nobody assigned I think that would have been fair, but given
that less than a day had passed
rehmanmuradali commented on a change in pull request #11154: [BEAM-1819] Key
should be available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r395644552
##
File path:
mxm commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test
for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601620962
If you run your own cluster, there is a log file for each task manager in
the /logs directory.
chamikaramj commented on issue #11180: [BEAM-9563] Change ToListCombineFn
access level to private
URL: https://github.com/apache/beam/pull/11180#issuecomment-601701191
Thanks. LGTM.
Agree on discussing more regarding the original change.
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine
test for portable Java
URL: https://github.com/apache/beam/pull/10386#issuecomment-601617591
@mxm I'm guessing this:
```
08:59:51 Exception in thread "main" java.lang.RuntimeException:
iemejia commented on a change in pull request #11178: [BEAM-9430] Update
CHANGES.md to reflect removal of ProcessContext#updateWatermark
URL: https://github.com/apache/beam/pull/11178#discussion_r395572143
##
File path: CHANGES.md
##
@@ -58,6 +58,7 @@
## Breaking Changes
iemejia commented on issue #11178: [BEAM-9430] Update CHANGES.md to reflect
removal of ProcessContext#updateWatermark
URL: https://github.com/apache/beam/pull/11178#issuecomment-601649153
Oh sorry it was just obviously good so I proceeded. Next time I will wait.
kamilwu commented on a change in pull request #11136: [BEAM-7505] Add side
input load test to Python SDK
URL: https://github.com/apache/beam/pull/11136#discussion_r395594161
##
File path: sdks/python/apache_beam/testing/load_tests/sideinput_test.py
##
@@ -47,65 +49,154
mwalenia commented on issue #11154: [BEAM-1819] Key should be available in
@OnTimer methods
URL: https://github.com/apache/beam/pull/11154#issuecomment-601684571
retest this please
This is an automated message from the
mwalenia commented on issue #11154: [BEAM-1819] Key should be available in
@OnTimer methods
URL: https://github.com/apache/beam/pull/11154#issuecomment-601684734
retest this please
This is an automated message from the
mwalenia removed a comment on issue #11154: [BEAM-1819] Key should be available
in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#issuecomment-601684571
retest this please
This is an automated message from
steveniemitz commented on a change in pull request #11154: [BEAM-1819] Key
should be available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r395633155
##
File path:
steveniemitz commented on a change in pull request #11154: [BEAM-1819] Key
should be available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r395633155
##
File path:
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual
failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-601618228
LGTM, but to be on the safe side: @kennknowles can you take a look? Won't
this have any adverse or unforseen
kamilwu edited a comment on issue #11136: [BEAM-7505] Add side input load test
to Python SDK
URL: https://github.com/apache/beam/pull/11136#issuecomment-599565761
Also a note: although this PR might look like a rework of the existing side
input test, it's better to treat it as a
mwalenia commented on issue #10949: [BEAM-9371] Add SideInputLoadTest to Java
SDK
URL: https://github.com/apache/beam/pull/10949#issuecomment-601645586
@Ardagan @kennknowles Pinging again
This is an automated message from
kamilwu commented on a change in pull request #11136: [BEAM-7505] Add side
input load test to Python SDK
URL: https://github.com/apache/beam/pull/11136#discussion_r395594609
##
File path: sdks/python/apache_beam/testing/load_tests/sideinput_test.py
##
@@ -47,65 +49,154
chamikaramj commented on a change in pull request #11122: [BEAM-9346] Improve
the efficiency of TFRecordIO
URL: https://github.com/apache/beam/pull/11122#discussion_r395658938
##
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##
@@ -410,13
piotr-szuberski commented on issue #11181: [BEAM-9500] Refactor load tests
URL: https://github.com/apache/beam/pull/11181#issuecomment-601761814
I think there is a lot more to do with the part "make LoadTest parameterized
instead of a base class."
kamilwu commented on a change in pull request #11136: [BEAM-7505] Add side
input load test to Python SDK
URL: https://github.com/apache/beam/pull/11136#discussion_r395678590
##
File path: sdks/python/apache_beam/testing/load_tests/sideinput_test.py
##
@@ -47,65 +49,154
piotr-szuberski commented on issue #11181: [BEAM-9500] Refactor load tests
URL: https://github.com/apache/beam/pull/11181#issuecomment-601761169
@mwalenia
This is an automated message from the Apache Git Service.
To respond
piotr-szuberski opened a new pull request #11181: [BEAM-9500] Refactor load
tests
URL: https://github.com/apache/beam/pull/11181
Changed the input to be initialized in the base class instead of the
subclasses.
Minor:
- Replaced creating new TimeMonitors with the one from the
mxm commented on issue #11052: [BEAM-9446] Add missing parallelism and
execution mode args.
URL: https://github.com/apache/beam/pull/11052#issuecomment-601768565
@ibzib Could we try to keep the Runner options in case we are not reading
them from the job server? We wouldn't have to
kamilwu commented on a change in pull request #11136: [BEAM-7505] Add side
input load test to Python SDK
URL: https://github.com/apache/beam/pull/11136#discussion_r395594161
##
File path: sdks/python/apache_beam/testing/load_tests/sideinput_test.py
##
@@ -47,65 +49,154
je-ik commented on issue #11168: [BEAM-9542] Limit and clarify the effect of
"force" in Java build
URL: https://github.com/apache/beam/pull/11168#issuecomment-601750689
Run Java HadoopFormatIO Performance Test
This is an
je-ik commented on issue #11168: [BEAM-9542] Limit and clarify the effect of
"force" in Java build
URL: https://github.com/apache/beam/pull/11168#issuecomment-601750794
Run Dataflow ValidatesRunner
This is an automated
je-ik commented on issue #11168: [BEAM-9542] Limit and clarify the effect of
"force" in Java build
URL: https://github.com/apache/beam/pull/11168#issuecomment-601750733
Run BigQueryIO Streaming Performance Test Java
This is
1 - 100 of 220 matches
Mail list logo
