[jira] [Commented] (BEAM-1495) Move ParDo.Bound as ParDo.BoundMulti into the core runners construction module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895313#comment-15895313
 ] 

ASF GitHub Bot commented on BEAM-1495:
--

GitHub user jkff opened a pull request:

https://github.com/apache/beam/pull/2158

[BEAM-1495] Removes PTransformMatchers for ParDo.Bound

No longer necessary after ParDo.Bound is always translated to BoundMulti.

R: @tgroh 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jkff/incubator-beam rm-single-matchers

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2158


commit b4214fcef941d9150a202ca1ae9a6dd52f65c1e9
Author: Eugene Kirpichov 
Date:   2017-03-04T00:29:31Z

[BEAM-1495] Removes PTransformMatchers for ParDo.Bound




> Move ParDo.Bound as ParDo.BoundMulti into the core runners construction module
> --
>
> Key: BEAM-1495
> URL: https://issues.apache.org/jira/browse/BEAM-1495
> Project: Beam
>  Issue Type: Bug
>  Components: runner-core
>Reporter: Thomas Groh
>Assignee: Thomas Groh
>Priority: Minor
>  Labels: starter
> Fix For: 0.6.0
>
>
> This is a reasonable runner-independent override.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1495) Move ParDo.Bound as ParDo.BoundMulti into the core runners construction module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895247#comment-15895247
 ] 

ASF GitHub Bot commented on BEAM-1495:
--

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2145


> Move ParDo.Bound as ParDo.BoundMulti into the core runners construction module
> --
>
> Key: BEAM-1495
> URL: https://issues.apache.org/jira/browse/BEAM-1495
> Project: Beam
>  Issue Type: Bug
>  Components: runner-core
>Reporter: Thomas Groh
>Priority: Minor
>  Labels: starter
>
> This is a reasonable runner-independent override.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1495) Move ParDo.Bound as ParDo.BoundMulti into the core runners construction module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893163#comment-15893163
 ] 

ASF GitHub Bot commented on BEAM-1495:
--

GitHub user tgroh opened a pull request:

https://github.com/apache/beam/pull/2145

[BEAM-1495] Implement Single-Output ParDo as a composite

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---
This reduces the number of primitive transforms in the Java SDK. There
is no functional change for any pipeline as a result of this change.

TODO: Remove all references to ParDo.Bound as a primitive in all runners.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tgroh/beam only_one_par_do

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2145


commit 913afa0a5bb3376323c40d06c65ea9aadf668935
Author: Thomas Groh 
Date:   2017-03-02T22:27:29Z

Implement Single-Output ParDo as a composite

This reduces the number of primitive transforms in the Java SDK. There
is no functional change for any pipeline as a result of this change.




> Move ParDo.Bound as ParDo.BoundMulti into the core runners construction module
> --
>
> Key: BEAM-1495
> URL: https://issues.apache.org/jira/browse/BEAM-1495
> Project: Beam
>  Issue Type: Bug
>  Components: runner-core
>Reporter: Thomas Groh
>Priority: Minor
>  Labels: starter
>
> This is a reasonable runner-independent override.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1495) Move ParDo.Bound as ParDo.BoundMulti into the core runners construction module

[Thomas Groh (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868989#comment-15868989
 ] 

Thomas Groh commented on BEAM-1495:
---

It is worth instead considering implementing ParDo.Bound purely in terms of 
ParDo.BoundMulti, and having a PrimitiveParDoSingle override factory for a 
runner who wishes to implement it as a single-output primitive. This allows us 
to cut out ParDo.Bound out of the set of primitives.

[~kenn]

> Move ParDo.Bound as ParDo.BoundMulti into the core runners construction module
> --
>
> Key: BEAM-1495
> URL: https://issues.apache.org/jira/browse/BEAM-1495
> Project: Beam
>  Issue Type: Bug
>  Components: runner-core
>Reporter: Thomas Groh
>Priority: Minor
>  Labels: starter
>
> This is a reasonable runner-independent override.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)