GitHub user dhalperi opened a pull request:
https://github.com/apache/beam/pull/1937
[BEAM-1384] JmsIO: better errors during start, better testing
For BEAM-1384, the test has been failing because the error may be surfaced
in either
start() or close(), depending on execution path. The underlying bug is that
start
was implemented so that close might fail (this.connection would be set, but
this.connection.close would fail in a bad way).
Rewrite start() to fix the invariant needed by close() and also to provide
better error messages. Fixup the tests. Unfortunately, expectedException
doesn't
really support testing causes and nested caused, so the rewrite dropped its
use.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/beam jms-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1937.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1937
----
commit 522ca570e9556e41f84327adfe8f3fb1c96f47e6
Author: Dan Halperin <dhalp...@google.com>
Date: 2017-02-07T17:35:35Z
[BEAM-1384] JmsIO: better errors during start, better testing
For BEAM-1384, the test has been failing because the error may be surfaced
in either
start() or close(), depending on execution path. The underlying bug is that
start
was implemented so that close might fail (this.connection would be set, but
this.connection.close would fail in a bad way).
Rewrite start() to fix the invariant needed by close() and also to provide
better error messages. Fixup the tests. Unfortunately, expectedException
doesn't
really support testing causes and nested caused, so the rewrite dropped its
use.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
