[GitHub] beam pull request #3285: Fix race condition when outputting pushed-back elem...

[aljoscha]

Github user aljoscha closed the pull request at:

https://github.com/apache/beam/pull/3285


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3285: Fix race condition when outputting pushed-back elem...

[aljoscha]

GitHub user aljoscha opened a pull request:

https://github.com/apache/beam/pull/3285

Fix race condition when outputting pushed-back elements in Flink Runner

This affected the Flink Streaming Runner DoFnOperator. The recent fix of
emitting pushed-back data when receiving a watermark on the first input
put the emission at the end of the method. This can cause the emitted
data to become late. The fix is to move the pushed-back element emission
to the start of the method.

`CombineTest.testSessionsCombineWithContext()` was flaky, because of this. 

R: @JingsongLi 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aljoscha/beam fix-pushed-back-values-flakyness

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/3285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3285


commit 61404c878fa8ccd23e2b3f1c8d2541593f01ad51
Author: Aljoscha Krettek 
Date:   2017-06-02T13:57:01Z

Fix race condition when outputting pushed-back elements in Flink Runner

This affected the Flink Streaming Runner DoFnOperator. The recent fix of
emitting pushed-back data when receiving a watermark on the first input
put the emission at the end of the method. This can cause the emitted
data to become late. The fix is to move the pushed-back element emission
to the start of the method.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---