[beam] 02/02: rename method as suggested and declare as default methods.

[xumingming]

This is an automated email from the ASF dual-hosted git repository.

xumingming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git

commit dbaf09838c5d064fdd6d953b91ad9a1ce61af72b
Author: mingmxu <ming...@ebay.com>
AuthorDate: Mon Feb 12 08:02:31 2018 -0800

    rename method as suggested and declare as default methods.
---
 .../org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java  | 4 ++--
 .../sdk/extensions/sql/impl/transform/BeamJoinTransforms.java     | 4 ++--
 .../sql/impl/rel/BeamJoinRelUnboundedVsBoundedTest.java           | 8 --------
 3 files changed, 4 insertions(+), 12 deletions(-)

diff --git 
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java
 
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java
index 95165a5..7b256c8 100644
--- 
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java
+++ 
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java
@@ -31,7 +31,7 @@ public interface BeamSqlSeekableTable extends Serializable{
   /**
    * prepare the instance.
    */
-  void setup();
+  default void setUp(){};
 
   /**
    * return a list of {@code Row} with given key set.
@@ -41,5 +41,5 @@ public interface BeamSqlSeekableTable extends Serializable{
   /**
    * cleanup resources of the instance.
    */
-  void teardown();
+  default void tearDown(){};
 }
diff --git 
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java
 
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java
index 2b44814..1be47b4 100644
--- 
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java
+++ 
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java
@@ -222,7 +222,7 @@ public class BeamJoinTransforms {
       return input.apply("join_as_lookup", ParDo.of(new DoFn<Row, Row>(){
         @Setup
         public void setup(){
-          seekableTable.setup();
+          seekableTable.setUp();
         }
 
         @ProcessElement
@@ -237,7 +237,7 @@ public class BeamJoinTransforms {
 
         @Teardown
         public void teardown(){
-          seekableTable.teardown();
+          seekableTable.tearDown();
         }
 
         private Row extractJoinSubRow(Row factRow) {
diff --git 
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRelUnboundedVsBoundedTest.java
 
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRelUnboundedVsBoundedTest.java
index 6a06123..ca639bd 100644
--- 
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRelUnboundedVsBoundedTest.java
+++ 
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRelUnboundedVsBoundedTest.java
@@ -131,14 +131,6 @@ public class BeamJoinRelUnboundedVsBoundedTest extends 
BaseRelTest {
     public List<Row> seekRow(Row lookupSubRow) {
       return Arrays.asList(Row.withRowType(getRowType()).addValues(1, 
"SITE1").build());
     }
-
-    @Override
-    public void setup() {
-    }
-
-    @Override
-    public void teardown() {
-    }
   }
 
   @Test

-- 
To stop receiving notification emails like this one, please contact
xumingm...@apache.org.