This is an automated email from the ASF dual-hosted git repository. pabloem pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push: new b532b38 Step in cleanup of create_operation function b532b38 is described below commit b532b38958527529bf561c92d34b1f1230213395 Author: Pablo <pabl...@google.com> AuthorDate: Thu Aug 2 10:56:34 2018 -0700 Step in cleanup of create_operation function --- sdks/python/apache_beam/runners/worker/operations.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sdks/python/apache_beam/runners/worker/operations.py b/sdks/python/apache_beam/runners/worker/operations.py index ac2780a..0488fe9 100644 --- a/sdks/python/apache_beam/runners/worker/operations.py +++ b/sdks/python/apache_beam/runners/worker/operations.py @@ -572,15 +572,14 @@ class FlattenOperation(Operation): self.output(o) -def create_operation(name_context, spec, counter_factory, step_name, - state_sampler, test_shuffle_source=None, +def create_operation(name_context, spec, counter_factory, step_name=None, + state_sampler=None, test_shuffle_source=None, test_shuffle_sink=None, is_streaming=False): """Create Operation object for given operation specification.""" + + # TODO(pabloem): Document arguments to this function call. if not isinstance(name_context, common.NameContext): - # TODO(BEAM-4028): Remove ad-hoc NameContext once all has been migrated. - name_context = common.DataflowNameContext(step_name=name_context, - user_name=step_name, - system_name=None) + name_context = common.NameContext(step_name=name_context) if isinstance(spec, operation_specs.WorkerRead): if isinstance(spec.source, iobase.SourceBundle):