[
https://issues.apache.org/jira/browse/BEAM-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357719#comment-16357719
]
Kenneth Knowles edited comment on BEAM-3674 at 2/8/18 11:45 PM:
----------------------------------------------------------------
>From
>https://issues.apache.org/jira/browse/BEAM-3159?focusedCommentId=16340765&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16340765
"how could you write a test such as this one (1) with only TestPipeline and
DirectRunner (only external test capabilities over the pipeline)?
(1)
https://github.com/apache/beam/blob/87670e6f525f3a9e51f6603f072410f86be48447/sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTestCommon.java#L220";
I believe that test is probably pretty easy with TestStream. One thing that
test does is that it checks assertions in the middle of processing. But it
should be fine to test the overall results of the pipeline. I would say that it
is also probably overspecified because it verifies exactly step by step what
happens when the spec of max batch size should probably be an inequality not
exact behavior.
was (Author: kenn):
>From
>https://issues.apache.org/jira/browse/BEAM-3159?focusedCommentId=16340765&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16340765
"how could you write a test such as this one (1) with only TestPipeline and
DirectRunner (only external test capabilities over the pipeline)?
(1)
https://github.com/apache/beam/blob/87670e6f525f3a9e51f6603f072410f86be48447/sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTestCommon.java#L220";
I believe that test is probably pretty easy with TestStream. One thing that
test does is that it checks assertions in the middle of processing. But it
should be fine to test the overall results of the pipeline.
> Port ElasticSearchIOTest off DoFnTester
> ---------------------------------------
>
> Key: BEAM-3674
> URL: https://issues.apache.org/jira/browse/BEAM-3674
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-extensions
> Reporter: Kenneth Knowles
> Priority: Minor
> Labels: beginner, newbie, starter
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
