[
https://issues.apache.org/jira/browse/BEAM-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528145#comment-16528145
]
Alexey Romanenko edited comment on BEAM-4622 at 6/29/18 7:48 PM:
-----------------------------------------------------------------
[~kenn] Can I take this one? Actually, I did a refactoring and some tests are
failing because of this short-circuit. I'll try to fix it.
was (Author: aromanenko):
Can I take this one? Actually, I did a refactoring and some tests are failing
because of this short-circuit. I'll try to fix it.
> Many Beam SQL expressions never have their validation called
> ------------------------------------------------------------
>
> Key: BEAM-4622
> URL: https://issues.apache.org/jira/browse/BEAM-4622
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Priority: Major
> Labels: easyfix, newbie, starter
>
> In {{BeamSqlFnExecutor}} there is a pattern where first the returned
> expression is assigned to a variable {{ret}} and then after a giant switch
> statement the validation is invoked. But there are many code paths that just
> call {{return}} and skip validation. This should be refactored so it is
> impossible to short-circuit on accident like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
