[jira] [Commented] (BEAM-1656) DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory

2017-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924671#comment-15924671 ] ASF GitHub Bot commented on BEAM-1656: -- Github user asfgit closed the pull request at:

[jira] [Commented] (BEAM-1656) DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory

2017-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923091#comment-15923091 ] ASF GitHub Bot commented on BEAM-1656: -- GitHub user tgroh opened a pull request:

[jira] [Commented] (BEAM-1656) DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory

2017-03-08 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902452#comment-15902452 ] Kenneth Knowles commented on BEAM-1656: --- Haven't dropped into the code. But since the direct runner

[jira] [Commented] (BEAM-1656) DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory

2017-03-08 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902397#comment-15902397 ] Kenneth Knowles commented on BEAM-1656: --- Let's actually change the spec so finalize is idempotent. >

[jira] [Commented] (BEAM-1656) DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory

2017-03-08 Thread Thomas Groh (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901835#comment-15901835 ] Thomas Groh commented on BEAM-1656: --- Removing the call to {{finalizeCheckpoint}} in {{getReader}} should