[jira] [Commented] (BEAM-5669) Empty commits pushed by PostCommit_Website_Publish jenkins job
[
https://issues.apache.org/jira/browse/BEAM-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646738#comment-16646738
]
Scott Wegner commented on BEAM-5669:
The above PR is now merged, and I'm no longer seeing empty commits.
I've also removed previous empty commits from the branch using {{git rebase}}:
https://github.com/apache/beam/commits/asf-site
> Empty commits pushed by PostCommit_Website_Publish jenkins job
> --
>
> Key: BEAM-5669
> URL: https://issues.apache.org/jira/browse/BEAM-5669
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Affects Versions: 2.8.0
>Reporter: Alan Myrvold
>Assignee: Scott Wegner
>Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The isClean() call in
> https://github.com/apache/beam/blob/67562393de09e1e8e24c4a83ca5274f57c8379bb/website/build.gradle#L165
> is returning false due to unstaged .gradle and build files.
> The asf-site branch needs a .gitignore, which can be the same as the master
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (BEAM-5669) Empty commits pushed by PostCommit_Website_Publish jenkins job
[
https://issues.apache.org/jira/browse/BEAM-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642024#comment-16642024
]
Scott Wegner commented on BEAM-5669:
re: whether fixing up history would break the website publishing. It appears
not. The code for pulling down latest changes is
[here|https://github.com/apache/infrastructure-puppet/blob/bae50f68a3215c3db80e8ac1bfe4bfdf45b72663/modules/gitwcsub/files/app/gitwcsub.py#L224],
which is essentially:
{{git fetch origin/asf-site && git reset --hard origin/asf-site}}
Neither {{fetch}} or {{reset --hard}} will complain if history has been
re-written.
> Empty commits pushed by PostCommit_Website_Publish jenkins job
> --
>
> Key: BEAM-5669
> URL: https://issues.apache.org/jira/browse/BEAM-5669
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Affects Versions: 2.8.0
>Reporter: Alan Myrvold
>Assignee: Alan Myrvold
>Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The isClean() call in
> https://github.com/apache/beam/blob/67562393de09e1e8e24c4a83ca5274f57c8379bb/website/build.gradle#L165
> is returning false due to unstaged .gradle and build files.
> The asf-site branch needs a .gitignore, which can be the same as the master
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (BEAM-5669) Empty commits pushed by PostCommit_Website_Publish jenkins job
[ https://issues.apache.org/jira/browse/BEAM-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642013#comment-16642013 ] Scott Wegner commented on BEAM-5669: The implications of these empty commits is extra commit spam for notifications, during fetch, and wasted CPU cycles for the Apache daemon publishing the website. After we get this fixed, a secondary question is whether we should go back and cleanup the empty commits. It would be easy to do with a git command, but it would re-write the git history. I'm not sure if this would cause any issues with the Apache gitpubsub publishing agent. > Empty commits pushed by PostCommit_Website_Publish jenkins job > -- > > Key: BEAM-5669 > URL: https://issues.apache.org/jira/browse/BEAM-5669 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.8.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Fix For: 2.8.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The isClean() call in > https://github.com/apache/beam/blob/67562393de09e1e8e24c4a83ca5274f57c8379bb/website/build.gradle#L165 > is returning false due to unstaged .gradle and build files. > The asf-site branch needs a .gitignore, which can be the same as the master -- This message was sent by Atlassian JIRA (v7.6.3#76005)
